)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"db2ea4deb932bee57d94643a9e4a3d41a3bc8a40","unresolved":true,"context_lines":[{"line_number":21,"context_line":"any of the API DB methods (which don\u0027t use oslo.db\u0027s \u0027DBAPI\u0027 helper),"},{"line_number":22,"context_line":"and is used explicitly in what would appear to be the critical cases"},{"line_number":23,"context_line":"(via the explicit \u0027oslo_db.api.wrap_db_retry\u0027 decorator), this doesn\u0027t"},{"line_number":24,"context_line":"seem like a huge loss."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iad2e4da4546b80a016e477577d23accb2606a6e4"},{"line_number":27,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1c94bbb3_03039805","line":24,"updated":"2021-08-06 15:10:32.000000000","message":"Indeed the description of that config states \"Enable the experimental use of database reconnect on connection lost.\" \n\nWe still generate this config into our doc and sample file so a new deployer who deploys Yoga first will never encounter the reno you added here but will see the possible config in our doc and sample and might think it is usable. Can we filter this out from our config doc and sample? Or some other way let the reader know that nova ignores this config?","commit_id":"96dd2c309ccbae7be8f892579f5960635de07b33"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b035cf463c7bcbeca7e60c57095fe50da7d30a53","unresolved":true,"context_lines":[{"line_number":21,"context_line":"any of the API DB methods (which don\u0027t use oslo.db\u0027s \u0027DBAPI\u0027 helper),"},{"line_number":22,"context_line":"and is used explicitly in what would appear to be the critical cases"},{"line_number":23,"context_line":"(via the explicit \u0027oslo_db.api.wrap_db_retry\u0027 decorator), this doesn\u0027t"},{"line_number":24,"context_line":"seem like a huge loss."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iad2e4da4546b80a016e477577d23accb2606a6e4"},{"line_number":27,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"aad3bf3f_9df7cf01","line":24,"in_reply_to":"1c94bbb3_03039805","updated":"2021-08-06 15:26:12.000000000","message":"Will address this in a warning, coming right up","commit_id":"96dd2c309ccbae7be8f892579f5960635de07b33"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a5a9936b12e2f94c8bfb2e76ef7f88e099b21b0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"any of the API DB methods (which don\u0027t use oslo.db\u0027s \u0027DBAPI\u0027 helper),"},{"line_number":22,"context_line":"and is used explicitly in what would appear to be the critical cases"},{"line_number":23,"context_line":"(via the explicit \u0027oslo_db.api.wrap_db_retry\u0027 decorator), this doesn\u0027t"},{"line_number":24,"context_line":"seem like a huge loss."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iad2e4da4546b80a016e477577d23accb2606a6e4"},{"line_number":27,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ca847fa0_2dfea14d","line":24,"in_reply_to":"aad3bf3f_9df7cf01","updated":"2021-08-09 09:02:56.000000000","message":"Done in https://review.opendev.org/c/openstack/nova/+/803778/1","commit_id":"96dd2c309ccbae7be8f892579f5960635de07b33"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"48de346aafcb4b2471fa9f222056f3262c93fe47","unresolved":false,"context_lines":[{"line_number":21,"context_line":"any of the API DB methods (which don\u0027t use oslo.db\u0027s \u0027DBAPI\u0027 helper),"},{"line_number":22,"context_line":"and is used explicitly in what would appear to be the critical cases"},{"line_number":23,"context_line":"(via the explicit \u0027oslo_db.api.wrap_db_retry\u0027 decorator), this doesn\u0027t"},{"line_number":24,"context_line":"seem like a huge loss."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iad2e4da4546b80a016e477577d23accb2606a6e4"},{"line_number":27,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"555b920e_38182b87","line":24,"in_reply_to":"ca847fa0_2dfea14d","updated":"2021-08-09 13:56:07.000000000","message":"ACK thanks for this explanation and fup ✔","commit_id":"96dd2c309ccbae7be8f892579f5960635de07b33"}],"nova/conf/database.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"db2ea4deb932bee57d94643a9e4a3d41a3bc8a40","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def register_opts(conf):"},{"line_number":52,"context_line":"    # TODO(stephenfin): Enable this once we drop use of"},{"line_number":53,"context_line":"    # \u0027oslo_db.api.DBAPI.from_config\u0027"},{"line_number":54,"context_line":"    # conf.register_opts(copy.deepcopy(main_db_opts), group\u003dmain_db_group)"},{"line_number":55,"context_line":"    conf.register_opts(copy.deepcopy(api_db_opts), group\u003dapi_db_group)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"61ae4534_5264b999","side":"PARENT","line":53,"updated":"2021-08-06 15:10:32.000000000","message":"OK, the generated sample file looks correct","commit_id":"8d21d4974bbf206e69db8d81ee6f435a5859795d"}],"nova/db/main/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"db2ea4deb932bee57d94643a9e4a3d41a3bc8a40","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    return wrapper"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _check_db_access():"},{"line_number":198,"context_line":"    # disable all database access if required"},{"line_number":199,"context_line":"    if DISABLE_DB_ACCESS:"},{"line_number":200,"context_line":"        service_name \u003d \u0027nova-compute\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f30af17_0fdfc9cb","line":197,"updated":"2021-08-06 15:10:32.000000000","message":"OK this seems functionally equivalent with setting IMPL to NoDB as all DB call goes through one of the 3 pick_context_manager decorator calls below. An alternative that would avoid the global state is to poison nova.db.main.api.get_context_manager function from nova.cmd.compute.main()","commit_id":"96dd2c309ccbae7be8f892579f5960635de07b33"}]}