)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"34d99e40e271c893987cf81ddfa543f060bfa54f","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"While we continue to allow users to request a specific database"},{"line_number":23,"context_line":"migration version to upgrade to, we *do not* allow them to request a"},{"line_number":24,"context_line":"sqlalchemy-migrate-based migration version. There\u0027s no good reason to do"},{"line_number":25,"context_line":"this - the deployment won\u0027t run with an out-of-date DB schema (something"},{"line_number":26,"context_line":"that\u0027s also true of the alembic migration, fwiw) - and we want to get"},{"line_number":27,"context_line":"people off of sqlalchemy-migrate as fast as possible. A change in a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"903d75fe_296142b7","line":24,"updated":"2021-08-17 11:12:42.000000000","message":"+1. In a fast forward upgrade scenario where the deployer wants to stop at the middle of the DB migrations for some reason can still be done with Wallaby Nova and since then there was no new old style migration added to stop at. So this is cool with me","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4d4d5eb1791e2af22b5272a21ae2889ac97c7f6f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"sqlalchemy-migrate-based migration version. There\u0027s no good reason to do"},{"line_number":25,"context_line":"this - the deployment won\u0027t run with an out-of-date DB schema (something"},{"line_number":26,"context_line":"that\u0027s also true of the alembic migration, fwiw) - and we want to get"},{"line_number":27,"context_line":"people off of sqlalchemy-migrate as fast as possible. A change in a"},{"line_number":28,"context_line":"future release can remove the sqlalchemy-migrate-based migrations once"},{"line_number":29,"context_line":"we\u0027re sure that they\u0027ll have upgraded to a release including all of the"},{"line_number":30,"context_line":"sqlalchemy-migrated-based migrations (so Wallaby)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"26d65dc7_c5f1b2c0","line":27,"range":{"start_line":27,"start_character":52,"end_line":27,"end_character":53},"updated":"2021-08-17 11:04:03.000000000","message":"Another point: there have been no meaningful migrations since Train so we\u0027d gain effectively nothing by adding this additional complexity. If we end up having to backport something (which I hope and suspect we won\u0027t) then we can revisit this decision","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"34d99e40e271c893987cf81ddfa543f060bfa54f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"objects as necessary to allow us to run tests against in-memory"},{"line_number":37,"context_line":"databases, where a different connection would actually mean a different"},{"line_number":38,"context_line":"database. We also can\u0027t rely on \u0027WalkVersionsMixin\u0027 from oslo.db since"},{"line_number":39,"context_line":"that only supports sqlalchemy-migrate [1]. We instead must re-invent the"},{"line_number":40,"context_line":"wheel here somewhat."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[1] https://github.com/openstack/oslo.db/blob/10.0.0/oslo_db/sqlalchemy/test_migrations.py#L42-L44"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"db2a860c_398c49b3","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":20},"updated":"2021-08-17 11:12:42.000000000","message":"I\u0027m wondering how neutron (or other alembic users) did this.","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"716024f5fbeb3e8fe8c7079ebcd821ce4a02f9ee","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. versionchanged:: 24.0.0 (Xena)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    Migrated versioning engine to alembic. The optional ``VERSION`` argument is"},{"line_number":218,"context_line":"    now expected to be an alembic-based version. sqlalchemy-migrate-based"},{"line_number":219,"context_line":"    versions will be rejected."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"db archive_deleted_rows"},{"line_number":222,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"eb0d0b26_9e7c64fe","line":219,"range":{"start_line":217,"start_character":0,"end_line":219,"end_character":30},"updated":"2021-08-18 12:37:51.000000000","message":"Had a look around and I can\u0027t see any deployment tools using this argument at the moment FWIW.","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"}],"nova/db/migration.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"34d99e40e271c893987cf81ddfa543f060bfa54f","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    # re-use the connection rather than creating a new one"},{"line_number":110,"context_line":"    with engine.begin() as connection:"},{"line_number":111,"context_line":"        config.attributes[\u0027connection\u0027] \u003d connection"},{"line_number":112,"context_line":"        alembic_api.stamp(config, ALEMBIC_INIT_VERSION[database])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def _upgrade_alembic(engine, config, version):"}],"source_content_type":"text/x-python","patch_set":7,"id":"67031b83_57b04c77","line":112,"updated":"2021-08-17 11:12:42.000000000","message":"so stamp is the fake apply that just mark the db to be on the max version compared to upgrade that does the actual migration","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"34d99e40e271c893987cf81ddfa543f060bfa54f","unresolved":true,"context_lines":[{"line_number":141,"context_line":"    # discard the URL encoded in alembic.ini in favour of the URL configured"},{"line_number":142,"context_line":"    # for the engine by the database fixtures, casting from"},{"line_number":143,"context_line":"    # \u0027sqlalchemy.engine.url.URL\u0027 to str in the process"},{"line_number":144,"context_line":"    config.set_main_option(\u0027sqlalchemy.url\u0027, str(engine.url))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # if we\u0027re in a deployment where sqlalchemy-migrate is already present,"},{"line_number":147,"context_line":"    # then apply all the updates for that and fake apply the initial alembic"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb92997c_f5f91883","line":144,"updated":"2021-08-17 11:12:42.000000000","message":"I was wondering why we had the sqlite url in the config, but I see that we override that here","commit_id":"905c9723e9b8398010c57b3609310315a913bef1"}]}