)]}'
{"id":"openstack%2Fnova~799533","triplet_id":"openstack%2Fnova~stable%2Fpike~I5c071f70f669966e9807b38e99077c1cae5b4606","project":"openstack/nova","branch":"stable/pike","topic":"bug/1799298","hashtags":[],"change_id":"I5c071f70f669966e9807b38e99077c1cae5b4606","subject":"Use subqueryload() instead of joinedload() for (system_)metadata","status":"ABANDONED","created":"2021-07-05 17:24:20.000000000","updated":"2022-08-01 16:08:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9a577d3e5bdd842b06dbdcc7cd647d3f7841da7c","_number":799533,"virtual_id_number":799533,"owner":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-07-05 19:42:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2021-07-11 10:20:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2021-07-09 19:03:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-05 17:24:20.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2021-07-05 18:50:34.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-05 19:42:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-11 10:20:53.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"}],"messages":[{"id":"e2e641b7ad5c99c834ebbd0ffc95b9f0d561982a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-07-05 17:24:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49d52dd0ce45869a814d056b37b3ca25556c3335","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-07-05 18:50:34.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/33/799533/1/check/tempest-dsvm-full-xenial/a1d059c/ : FAILURE in 28m 48s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/33/799533/1/check/tempest-dsvm-full-xenial-py3/6b0aa95/ : FAILURE in 29m 26s","accounts_in_message":[],"_revision_number":1},{"id":"74f0d4361b9dba2b1aed2426e7f18c7d1ae24f5b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-05 19:42:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1d6a94fe1d85472489550a32cc4013ab : SUCCESS in 10m 38s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/be12f7fea1224c21ae2ddf01ad1bb026 : SUCCESS in 12m 17s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8f9b72b8265242c3ab5c9999655ec1f5 : SUCCESS in 12m 49s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/fd7244d0be274673aeb51bed6afaa505 : SUCCESS in 7m 40s\n- tempest-full https://zuul.opendev.org/t/openstack/build/ff8e741ccf894abc82b8dae45aad9aae : SUCCESS in 1h 11m 37s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7a9f672504e84f40bdef580e9bf51644 : FAILURE in 36m 52s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/03affb49effa4b7b936cdb15327db505 : SUCCESS in 50m 17s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/7a9db4e31b4a4071a6a07e81febbaf92 : SUCCESS in 2h 09m 43s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/d1f8a6087a87411a8e339f8e020affd5 : SUCCESS in 23m 37s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/4fa0637435de49e1b8b4b6b53abc4d4e : SUCCESS in 18m 02s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/f9b730f37f694cc597adc7eb8d33f338 : SUCCESS in 1h 28m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c24c6dab6f615abaf7a066be8e7d4140efe91054","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-09 19:03:28.000000000","message":"Patch Set 1: Code-Review+2\n\nClean backport from stable/queens of useful bug fix, LGTM","accounts_in_message":[],"_revision_number":1},{"id":"9ca1f2bd16c4a733c66a185f80d065814e8c2e7d","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-07-11 10:20:53.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"9a577d3e5bdd842b06dbdcc7cd647d3f7841da7c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-08-01 16:08:23.000000000","message":"Abandoned\n\nstable/pike has transitioned to End of Life for nova, open patches need to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"514e8db346b783c3c68829092d60913440a033cf","revisions":{"514e8db346b783c3c68829092d60913440a033cf":{"kind":"REWORK","_number":1,"created":"2021-07-05 17:24:20.000000000","uploader":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"ref":"refs/changes/33/799533/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/799533/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/799533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/799533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/799533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/799533/1"}}},"commit":{"parents":[{"commit":"2ed1664b12cf67cecb1d858b10d901b674a8149f","subject":"Merge \"Lowercase ironic driver hash ring and ignore case in cache\" into stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ed1664b12cf67cecb1d858b10d901b674a8149f"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-10-20 21:46:13.000000000","tz":0},"committer":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2021-07-05 17:21:56.000000000","tz":120},"subject":"Use subqueryload() instead of joinedload() for (system_)metadata","message":"Use subqueryload() instead of joinedload() for (system_)metadata\n\nCurrently, when we \"get\" a single instance from the database and we\nload metadata and system_metadata, we do so using a joinedload() which\ndoes JOINs with the respective tables. Because of the one-to-many\nrelationship between an instance and (system_)metadata records, doing\nthe database query this way can result in a large number of additional\nrows being returned unnecessarily and cause a large data transfer.\n\nThis is similar to the problem addressed by change\nI0610fb16ccce2ee95c318589c8abcc30613a3fe9 which added separate queries\nfor (system_)metadata when we \"get\" multiple instances. We don\u0027t,\nhowever, reuse the same code for this change because\n_instances_fill_metadata converts the instance database object to a\ndict, and some callers of _instance_get_by_uuid need to be able to\naccess an instance database object attached to the session (example:\ninstance_update_and_get_original).\n\nBy using subqueryload() [1], we can perform the additional queries for\n(system_)metadata to solve the problem with a similar approach.\n\nCloses-Bug: #1799298\n\n[1] https://docs.sqlalchemy.org/en/13/orm/loading_relationships.html#subquery-eager-loading\n\nChange-Id: I5c071f70f669966e9807b38e99077c1cae5b4606\n(cherry picked from commit e728fe668a6de886455f2dbaf655c8a151462c8c)\n(cherry picked from commit 63d2e62c3a223f883ca810f4c66a2a236cf3d483)\n(cherry picked from commit e7a45e0335e4cf44fec7f7b8d2505f5b95445cf9)\n(cherry picked from commit 4350074029ffbc03ab238c442ec86fab6560e365)\n(cherry picked from commit ad7e4fb8f4ea6c458af00ec7aa0b321dc37c097c)\n(cherry picked from commit 68f80d201310dcaf688d8437a46c8d272ead317d)\n(cherry picked from commit c1de4fb13e4c7d220ff2e42f24f06b4bbe53521f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/514e8db346b783c3c68829092d60913440a033cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/514e8db346b783c3c68829092d60913440a033cf"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}