)]}'
{"nova/tests/unit/db/api/test_migrations.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d992737078ae95617b4efa3af989cbc07dd273bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dcae353b_f2b5bac6","side":"PARENT","line":151,"updated":"2021-08-17 10:54:56.000000000","message":"I guess this was eventually got fixed since","commit_id":"c3e113eb31283614e391b46ec596c479add6bbf5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82819d85c90678ed275b5874a8df8226aca4b584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd601f96_02c2eafe","side":"PARENT","line":151,"in_reply_to":"dcae353b_f2b5bac6","updated":"2021-08-17 11:00:31.000000000","message":"Yeah, I don\u0027t think it applied here ever since we switched to using the mixins instead of the deprecated test cases [1], since we now control this (well, testtools does). There is still an amount of \"vomiting\" going on because of alembic but that has to be addressed separately.\n\n[1] https://github.com/openstack/oslo.db/blob/10.0.0/oslo_db/sqlalchemy/test_base.py#L95-L101","commit_id":"c3e113eb31283614e391b46ec596c479add6bbf5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d992737078ae95617b4efa3af989cbc07dd273bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"184b6433_d3b2429e","updated":"2021-08-17 10:54:56.000000000","message":"This rename affects the functional test grouping in tox [1]. I suggest to remove the now noop grouping from tox.ini in this patch.\n\n[1] https://github.com/openstack/nova/blob/370830e9445c9825d1e34e60cca01fdfe88d5d82/tox.ini#L105","commit_id":"307adc5e087d06a3ba4ae09dffb973ba83015049"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61109e141d80ea732175c995ecc90e528bfc4883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"afcec4b4_43a06850","in_reply_to":"0e98de3d_6bad38e1","updated":"2021-08-17 11:14:27.000000000","message":"Ack","commit_id":"307adc5e087d06a3ba4ae09dffb973ba83015049"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82819d85c90678ed275b5874a8df8226aca4b584","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0e98de3d_6bad38e1","in_reply_to":"184b6433_d3b2429e","updated":"2021-08-17 11:00:31.000000000","message":"I realized this too late, but I have fixed it in a follow-up [1]. Is that okay?\n\n[1] https://review.opendev.org/c/openstack/nova/+/800484/4/tox.ini","commit_id":"307adc5e087d06a3ba4ae09dffb973ba83015049"}]}