)]}'
{"id":"openstack%2Fnova~800076","triplet_id":"openstack%2Fnova~master~Ib3c8ed876791cda96486d43384f7aec0c487fd2f","project":"openstack/nova","branch":"master","topic":"bp/remove-sqlalchemy-migrate","hashtags":[],"change_id":"Ib3c8ed876791cda96486d43384f7aec0c487fd2f","subject":"db: Avoid use of ALTER in initial migration","status":"MERGED","created":"2021-07-08 16:14:57.000000000","updated":"2021-08-18 14:09:42.000000000","submitted":"2021-08-18 14:07:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"800076-bp/remove-sqlalchemy-migrate","meta_rev_id":"910e47780c1a8f0348d1a21f5343ec4b0bc83f61","_number":800076,"virtual_id_number":800076,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-18 14:07:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":2,"date":"2021-08-18 12:08:52.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-08-18 14:09:42.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":1,"date":"2021-08-18 12:08:52.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-08 16:51:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-08 17:18:36.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-08 17:59:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-08 18:01:30.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-08 19:33:42.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-07-08 19:57:14.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-08-06 16:20:50.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-08-18 12:08:52.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"}],"messages":[{"id":"487ab654ca6827702b55a9aea1df23406090876f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-08 16:14:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d1ccdf1263f1448eea3c24522b166277c456082d","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-08 16:51:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/aa99d37687004af4af4e73037220cc1f : SUCCESS in 23m 16s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/da2babeec9fb4af8b47d0585aa8b3a76 : SUCCESS in 31m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"571a98fb1c0ff696c651a42e8bbd4486e0600367","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-07-08 17:18:36.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 tempest-dsvm-full-focal-py3 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"e178696f165968f1e5772d3e1eedf51d921f79de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-08 17:59:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/e89b7571e1ae40098b2b847280174f11 : SUCCESS in 1h 06m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/907c304d49c64a43be8a654f89910366 : SUCCESS in 15m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9ea4911286c541aa8603a2ba2558f098 : SUCCESS in 16m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c61d574a70d9496e81a0093c95ce7d8b : SUCCESS in 8m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d8eb07d17ebc4dd981c4d39a4e542d6c : SUCCESS in 12m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/520c4315ed134ca0bdc3605e0a868653 : SUCCESS in 13m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/08ad983c087f421399f628a380d569c8 : SUCCESS in 16m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/242518cb163d45b8b3c859229e7f1522 : SUCCESS in 10m 08s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/72addee7ff124a0c99f45e0095bcbb09 : SUCCESS in 1h 11m 45s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/0b3423de02fd4047a3faa980922f12b5 : SUCCESS in 1h 23m 00s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/bde2b8832608432a9795677b95c44e34 : SUCCESS in 53m 47s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/46a775c645db4c4a9e06f2371896e274 : SUCCESS in 50m 58s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/9c7e6bdafc58407690cf03a2918bce99 : SUCCESS in 1h 27m 18s\n- nova-next https://zuul.opendev.org/t/openstack/build/f78d96d17e984a2187800a4892c347d4 : SUCCESS in 1h 36m 58s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/75cd8d23cd59449dad4bf249da163574 : SUCCESS in 6m 24s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/35686fe9c39946138384a6e3e299dfe1 : SUCCESS in 20m 08s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d59c0e4f9f28423e8f4e841ff0ee4da0 : SUCCESS in 20m 05s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/7f9d56f024d9483e9c1c86c22314b740 : SUCCESS in 24m 57s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4a79ba4fd31c45ea8184001f1e318bd6 : SUCCESS in 1h 15m 09s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/66dc3c487a104e9cab00def6eee5ac7c : SUCCESS in 48m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c0fa8f40c7694e7394d080653acb3182 : SUCCESS in 49m 34s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a0d451eedcb947b1bb0d0a720492d2f8 : SUCCESS in 28m 11s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/fdf0e7c0fdff4478b4e26be4de1b579b : SUCCESS in 43m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"863653683dc9fbb29884dded57cbe60da07a2a4c","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-07-08 18:01:30.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/76/800076/1/check/EMC_PowerFlex_NOVA/150de31/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"91feeea74721f09cd12257cec1187a41f1078898","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-08 19:33:42.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/76/800076/1/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/76/800076/1/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"80cb76d681fc9bcc20ee9da9639e74ff63495e9b","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-07-08 19:57:14.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/800076/1/iscsi : SUCCESS in 2h 11m 51s","accounts_in_message":[],"_revision_number":1},{"id":"a3b9fc1d633e0ebf5db24fa975bd94c775090d2a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-07-09 12:23:42.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bab1c2b5aa42e2a3cc80bea503bf27fa86724f9d","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-07-09 12:55:31.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 tempest-dsvm-full-focal-py3 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":2},{"id":"dc0618f7cb3a02df16d08624ae7045c1d7b6cda0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-09 12:56:13.000000000","message":"Patch Set 2:\n\nBuild Failed \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-direct : ABORTED\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-macvtap : ABORTED","accounts_in_message":[],"_revision_number":2},{"id":"039555c9df9248906f303f6a6f584875cea1e720","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-09 13:56:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8651b9f18af84876acf0518d564d440f : SUCCESS in 1h 00m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b6866ebaafb14462ad609388677682f2 : SUCCESS in 16m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c5ddb86691d94b64b0ee966ddedab3f4 : SUCCESS in 16m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7760881bd7834e8ba39b857ad6dc768c : SUCCESS in 9m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3c3a9bba148f41a8bee91ef2def57e72 : SUCCESS in 14m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0ad43d2ebbac42d8a49b8c3b2094db46 : SUCCESS in 13m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/dffa1e3d53834461a84e33d21ac2cb7c : SUCCESS in 14m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/900ccfa291d24ae7bf59897a5b942848 : SUCCESS in 11m 52s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7d1ac013f9fa4b1c9657d5fd2b6c4b9e : SUCCESS in 1h 10m 34s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/3d0a9400804544de9f2e3a7246fbe4cc : SUCCESS in 1h 22m 53s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/a4edc6dd9ed242568c57138636d102ee : SUCCESS in 53m 09s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/388c1d20cb064b32a35eb3132755e3ce : SUCCESS in 54m 36s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/46b840b8cf364425bfc315db07f5a125 : SUCCESS in 1h 23m 39s\n- nova-next https://zuul.opendev.org/t/openstack/build/04c709b3a9074fa0931033198f764df1 : SUCCESS in 1h 25m 13s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/79f862d5309549939855a3167bb40073 : SUCCESS in 7m 15s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/216859e35bdc4257b14f8b421630536b : SUCCESS in 22m 48s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/19777221af614ca8b7beb88a3044d02f : SUCCESS in 21m 16s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/486aa89ca90d44d19dc40bb96af5d115 : SUCCESS in 21m 58s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/14946567437f4c1981574f71a18c4bfd : SUCCESS in 1h 08m 46s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/84ed2f9288a0474185a51ec65a2854b3 : SUCCESS in 54m 38s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/78e10233fa6940fca83e61ee5f09a043 : SUCCESS in 45m 30s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f2703c4c5c114feb9bfa48e229fac7de : SUCCESS in 39m 34s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/6b91a222da4a4814b3e397feca939b03 : SUCCESS in 42m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fa6a4e6dadf3795891fdfb0b1dc38e2b489d9fd4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-09 14:01:30.000000000","message":"Patch Set 2:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4255d666b6a7eb4bd97c59ea00699970277b97c7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-09 14:19:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/c165f3647c0343828109e9d9e95c4f9c : SUCCESS in 29m 54s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f73f39fa90534156a00d8691e9bb0732 : SUCCESS in 39m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"55a549ed72765ba76c18f2f5762c6450d5191cc3","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-07-09 15:32:24.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/800076/2/iscsi : FAILURE in 2h 33m 56s","accounts_in_message":[],"_revision_number":2},{"id":"4fc7451e14c2e31faa9b49acc6b90d00f9c09b9d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-07-09 17:38:46.000000000","message":"Patch Set 2:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/76/800076/2/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"46a177965c5afda68c1cbee7d02f05a30117d34d","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-06 16:20:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0ba0b18738e4a1c7437ec73ddf75c328dd7678d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-08-09 14:37:59.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"8575d45d95ef936fe52d24f04218a2d9fce7ec7a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-09 15:19:37.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/c0ed8fbe289844dcb5d5a91b6343ab12 : SUCCESS in 22m 32s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6d1309a5629c46f2823d4e32bf39ef0f : SUCCESS in 22m 34s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"83f47abc72de39457e9846324b697f84713d4d07","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-09 16:09:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/803e161347dd452ea71bdf8a5438055f : SUCCESS in 1h 06m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e70dcc9f3d974514850c7e6959b05bd1 : SUCCESS in 20m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1052c0e8bc81413c9072d8d199a0cd3f : SUCCESS in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c64c3585678c4d31918c14420d91da4e : SUCCESS in 10m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/37cada8ab47b4b3ea06bf6727779730f : SUCCESS in 12m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ecd4c48abb784c04b2a9a671888a0d38 : SUCCESS in 12m 22s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8e7eeee08b8a4569a2b715d25848d645 : SUCCESS in 13m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7b9d5885ccda40128a9c06243ed4a721 : SUCCESS in 10m 56s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b6f9e44ac59346d381cf7786b45b9c0a : SUCCESS in 1h 24m 02s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c659bfdad9cf445da589d02a42088274 : SUCCESS in 1h 06m 40s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/58f1ba7a103d426492410e5aa0454ef6 : SUCCESS in 53m 22s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/7c24bb844eff495fbd9bdcea738632fa : SUCCESS in 50m 49s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8a4fe25339a748769c7cf563ad50eeff : SUCCESS in 1h 23m 06s\n- nova-next https://zuul.opendev.org/t/openstack/build/972ed1896fd84847a77663c99e93f0cb : SUCCESS in 1h 23m 59s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/5e5b08804ea043079c3d414515a312e4 : SUCCESS in 6m 51s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/df0446cb28a741ee8d6a86213dc81383 : SUCCESS in 18m 50s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7efd89bfe5c4449ba1fb4b35e794f8ee : SUCCESS in 18m 30s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/41dd5f29c21641d68d2792d5a207f9eb : SUCCESS in 19m 33s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/466f40d3496d41e3af420aa669b1a0a4 : SUCCESS in 1h 12m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/476c8fce29e24bbabfd2baf9a47d94bd : SUCCESS in 46m 26s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f65b40e5ba634184b856e6f17cc6533b : SUCCESS in 40m 10s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/38c7a40044124167b03e31bcd3364df0 : SUCCESS in 38m 12s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/5ab7f11fd2cf49f6851dc1e1060989a0 : SUCCESS in 39m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6829d6a9ab6555137e480148bc7968c615a97c96","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-08-09 16:10:32.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/76/800076/3/check/EMC_PowerFlex_NOVA/5ce5295/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":3},{"id":"b6527c5e0e01625ddf31bf79fefdafb7342cd6b1","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-09 17:48:26.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/800076/3/iscsi : SUCCESS in 2h 40m 16s","accounts_in_message":[],"_revision_number":3},{"id":"247a211b807674c6a1e1eefbbd8d0b5ca6a8c75f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-09 18:51:49.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/800076/3/check/tempest-dsvm-full-focal-py3/de95637/ : FAILURE in 2h 26m 18s","accounts_in_message":[],"_revision_number":3},{"id":"442a051ec64bdd76f40d68f70dcaec799a1ad79c","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-08-18 12:08:52.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"95532653a3a1025ad3672e53aa2c6c21a15f5442","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-18 12:09:37.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"8798d8690c89be10d68ca7169320147c98c086da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-18 14:07:25.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/b99f7d36c10343f4adb630f25635727b : SUCCESS in 1h 31m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4cca912e9d8e44c292229f179125f2d8 : SUCCESS in 14m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8e0324916854457b094af085506ace0 : SUCCESS in 10m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ee2ec5d6f8cc4ab1a0f221991a74d3e6 : SUCCESS in 12m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e3e06ddb30994e06a3df0c71f4f95312 : SUCCESS in 13m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0a84c725c68d4cfca3f1c1c353fb50e5 : SUCCESS in 10m 19s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/76c55f1db41d4c4b92ccdb1f76d95f76 : SUCCESS in 50m 13s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/19fe93295aac4f2aa49d27b0a319f578 : SUCCESS in 55m 20s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/89599995184d439086994f8dcb37b4e0 : SUCCESS in 19m 24s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a03e03ae69e848fe9208ae0bbd5293b5 : SUCCESS in 19m 03s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/5f6a3639b2374e3781abba59c6305936 : SUCCESS in 1h 28m 06s\n- nova-next https://zuul.opendev.org/t/openstack/build/e5b1cf557429405e941f2253bc86184d : SUCCESS in 1h 14m 42s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/76cb61c644db4fe08b44f97920a084f7 : SUCCESS in 8m 10s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/a50150b4b6594d4098d33927dbf03f77 : SUCCESS in 1h 14m 25s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/7334959214354e0ebb61c3d667fa0c35 : SUCCESS in 1h 23m 11s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c86cc11d7ed244a38719c9304b0b1fcf : SUCCESS in 50m 55s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4506bd98f93745b481de379fea7ae3df : SUCCESS in 44m 28s","accounts_in_message":[],"_revision_number":3},{"id":"d2b265088d21f8ffc07d0bcb28048d4e6ce080ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-18 14:07:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"09452d61108cb77fc5babc613886c90ec642866c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-18 14:09:42.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d6ec4f55fdad47e38c5b385069ac1243 : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"21c5ced0ba3219d396b354f5fdca629950c63e0c","revisions":{"692d35bd48be1e65247af945f1aef4762875a6cf":{"kind":"REWORK","_number":1,"created":"2021-07-08 16:14:57.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/800076/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/800076/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/800076/1"}}},"commit":{"parents":[{"commit":"53262f19193dce8ef67465507d247cf1a56ffbaf","subject":"db: Post reshuffle cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/53262f19193dce8ef67465507d247cf1a56ffbaf"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-08 10:59:01.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-08 11:32:32.000000000","tz":60},"subject":"db: Avoid use of ALTER in initial migration","message":"db: Avoid use of ALTER in initial migration\n\nWe have a class of bugs in our current database schema that were\nintroduced by now-squashed migrations, whereby we applied a new\nconstraint to a column but forgot to apply the same change to the column\nin the shadow table. Currently, we preserve the behavior of these bugs\nthrough use of the \u0027ALTER\u0027 statement. This results in more complex SQL\nfor the initial migration, however, more importantly, the ALTER\nstatement is not actually supported by SQLite and the underlying\nmigration engine must instead mimic behavior by creating a new table\nwith the updated schema and a temporary name, copy across all data from\nthe old table to the new table, delete the old table and rename the new\ntable.\n\nWhile sqlalchemy-migrate handled this transparently for us, therefore\nallowing us to mostly ignore the issue, alembic makes this lack of\nsupport in SQLite explicit by insisting on the \u0027batch_alter_table\u0027\ncontext manager [1] wrapping any ALTER statements. This is context\nmanager is \"a little tricky\" (zzzeek\u0027s words, not mine) and is therefore\nbest avoided. Fortunately, this is easily done through the addition of a\ncouple of checks within the \u0027_create_shadow_tables\u0027 helper that simply\nmodify the affected columns before creating the table.\n\n[1] https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.batch_alter_table\n\nChange-Id: Ib3c8ed876791cda96486d43384f7aec0c487fd2f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/692d35bd48be1e65247af945f1aef4762875a6cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/692d35bd48be1e65247af945f1aef4762875a6cf"}]},"branch":"refs/heads/master"},"036f79aaba0886c5dfa724e3213b8adf26471c43":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-07-09 12:23:42.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/800076/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/800076/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/800076/2"}}},"commit":{"parents":[{"commit":"c69423dd8f02dd9789a18d9fb29131ec48b4d8b9","subject":"db: Post reshuffle cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c69423dd8f02dd9789a18d9fb29131ec48b4d8b9"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-08 10:59:01.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-09 10:24:57.000000000","tz":60},"subject":"db: Avoid use of ALTER in initial migration","message":"db: Avoid use of ALTER in initial migration\n\nWe have a class of bugs in our current database schema that were\nintroduced by now-squashed migrations, whereby we applied a new\nconstraint to a column but forgot to apply the same change to the column\nin the shadow table. Currently, we preserve the behavior of these bugs\nthrough use of the \u0027ALTER\u0027 statement. This results in more complex SQL\nfor the initial migration, however, more importantly, the ALTER\nstatement is not actually supported by SQLite and the underlying\nmigration engine must instead mimic behavior by creating a new table\nwith the updated schema and a temporary name, copy across all data from\nthe old table to the new table, delete the old table and rename the new\ntable.\n\nWhile sqlalchemy-migrate handled this transparently for us, therefore\nallowing us to mostly ignore the issue, alembic makes this lack of\nsupport in SQLite explicit by insisting on the \u0027batch_alter_table\u0027\ncontext manager [1] wrapping any ALTER statements. This is context\nmanager is \"a little tricky\" (zzzeek\u0027s words, not mine) and is therefore\nbest avoided. Fortunately, this is easily done through the addition of a\ncouple of checks within the \u0027_create_shadow_tables\u0027 helper that simply\nmodify the affected columns before creating the table.\n\n[1] https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.batch_alter_table\n\nChange-Id: Ib3c8ed876791cda96486d43384f7aec0c487fd2f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/036f79aaba0886c5dfa724e3213b8adf26471c43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/036f79aaba0886c5dfa724e3213b8adf26471c43"}]},"branch":"refs/heads/master"},"21c5ced0ba3219d396b354f5fdca629950c63e0c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-08-09 14:37:59.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/76/800076/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/800076/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/800076/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/800076/3"}}},"commit":{"parents":[{"commit":"43b253cd60bd68bce108969d6b3adc0565b8f95e","subject":"db: Post reshuffle cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/43b253cd60bd68bce108969d6b3adc0565b8f95e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-07-08 10:59:01.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-08-09 14:34:40.000000000","tz":60},"subject":"db: Avoid use of ALTER in initial migration","message":"db: Avoid use of ALTER in initial migration\n\nWe have a class of bugs in our current database schema that were\nintroduced by now-squashed migrations, whereby we applied a new\nconstraint to a column but forgot to apply the same change to the column\nin the shadow table. Currently, we preserve the behavior of these bugs\nthrough use of the \u0027ALTER\u0027 statement. This results in more complex SQL\nfor the initial migration, however, more importantly, the ALTER\nstatement is not actually supported by SQLite and the underlying\nmigration engine must instead mimic behavior by creating a new table\nwith the updated schema and a temporary name, copy across all data from\nthe old table to the new table, delete the old table and rename the new\ntable.\n\nWhile sqlalchemy-migrate handled this transparently for us, therefore\nallowing us to mostly ignore the issue, alembic makes this lack of\nsupport in SQLite explicit by insisting on the \u0027batch_alter_table\u0027\ncontext manager [1] wrapping any ALTER statements. This is context\nmanager is \"a little tricky\" (zzzeek\u0027s words, not mine) and is therefore\nbest avoided. Fortunately, this is easily done through the addition of a\ncouple of checks within the \u0027_create_shadow_tables\u0027 helper that simply\nmodify the affected columns before creating the table.\n\n[1] https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.batch_alter_table\n\nChange-Id: Ib3c8ed876791cda96486d43384f7aec0c487fd2f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21c5ced0ba3219d396b354f5fdca629950c63e0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21c5ced0ba3219d396b354f5fdca629950c63e0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}