)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"610e25a0ab99629d756c11ea6eb03e3cdc8a766c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"neutron API extension is present."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that we have to keep the old logic in place to support the scenario"},{"line_number":17,"context_line":"when Nova is upgraded first and therefore Neutron still using the old"},{"line_number":18,"context_line":"resource_request format."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: If7b80c8725d9a8183d2df05c824461e8ee5f45d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f77fc49e_3805b1fa","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"updated":"2021-07-20 17:42:14.000000000","message":"is still","commit_id":"1a08b1def7913c436867aafa637cfa6c9f2b0a39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"83c56ec77bb246c917adb6ad1ac9beb078896de8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"neutron API extension is present."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that we have to keep the old logic in place to support the scenario"},{"line_number":17,"context_line":"when Nova is upgraded first and therefore Neutron still using the old"},{"line_number":18,"context_line":"resource_request format."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: If7b80c8725d9a8183d2df05c824461e8ee5f45d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4b0053b7_01b09582","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":55},"in_reply_to":"f77fc49e_3805b1fa","updated":"2021-07-22 13:21:31.000000000","message":"Done","commit_id":"1a08b1def7913c436867aafa637cfa6c9f2b0a39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c67d443aaa6f9dbaf91f5627bc8c3c8e08ddfbb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"been changed by the extended_resource_request Neutron API extension."},{"line_number":11,"context_line":"This patch adds a new factory method for RequestGroup to parse the data"},{"line_number":12,"context_line":"and create the RequestGroup objects corresponding to the request. Also"},{"line_number":13,"context_line":"the neutron interface of nova changed to use the new factory if the new"},{"line_number":14,"context_line":"neutron API extension is present."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that we have to keep the old logic in place to support the scenario"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3ce72238_05dc4962","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":30},"updated":"2021-07-27 16:28:04.000000000","message":"is","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8df6ff54b362704d28290ac2586f90a43269dce2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"been changed by the port-resource-request-groups Neutron API extension."},{"line_number":11,"context_line":"This patch adds a new factory method for RequestGroup to parse the data"},{"line_number":12,"context_line":"and create the RequestGroup objects corresponding to the request. Also"},{"line_number":13,"context_line":"the neutron interface of nova changed to use the new factory if the new"},{"line_number":14,"context_line":"neutron API extension is present."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that we have to keep the old logic in place to support the scenario"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7e0c69da_e95f55e4","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":30},"updated":"2021-08-27 12:47:19.000000000","message":"is","commit_id":"d6cd4420bb33501e267b10ccc3a1f26ab2c8c85b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0aa137bb466246f574fefca041f212b307151762","unresolved":false,"context_lines":[{"line_number":17,"context_line":"when Nova is upgraded first and therefore Neutron is still using the old"},{"line_number":18,"context_line":"resource_request format."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Also note that some of the so far skipped functional tests started to"},{"line_number":21,"context_line":"pass as they are negative tests resulting in an unsuccessful operation due to"},{"line_number":22,"context_line":"not related reasons and the code already works good enough to hit those"},{"line_number":23,"context_line":"negative code paths."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"blueprint: qos-minimum-guaranteed-packet-rate"},{"line_number":26,"context_line":"Change-Id: If7b80c8725d9a8183d2df05c824461e8ee5f45d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e2df3445_c5bfce3c","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":20},"updated":"2021-08-27 10:11:35.000000000","message":"nit - I was about to ask why you\u0027re removing these tests, why not just comment them out?","commit_id":"d6cd4420bb33501e267b10ccc3a1f26ab2c8c85b"}],"nova/network/neutron.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c67d443aaa6f9dbaf91f5627bc8c3c8e08ddfbb","unresolved":false,"context_lines":[{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":2038,"context_line":"        has_extended_resource_request_extension \u003d ("},{"line_number":2039,"context_line":"            self._has_extended_resource_request_extension(context, neutron))"},{"line_number":2040,"context_line":"        resource_requests \u003d []"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        for request_net in requested_networks:"}],"source_content_type":"text/x-python","patch_set":9,"id":"25579df6_aa433d6b","line":2039,"updated":"2021-07-27 16:28:04.000000000","message":"nit: I\u0027m pretty sure this is cached by default, so we\u0027re not saving a lot by caching this. No big deal though","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c67d443aaa6f9dbaf91f5627bc8c3c8e08ddfbb","unresolved":false,"context_lines":[{"line_number":2059,"context_line":"                    context, neutron, network_id)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"                if (has_extended_resource_request_extension and"},{"line_number":2062,"context_line":"                        resource_request):"},{"line_number":2063,"context_line":"                    # need to handle the new resource request format"},{"line_number":2064,"context_line":"                    resource_requests.extend("},{"line_number":2065,"context_line":"                        objects.RequestGroup.from_extended_port_request("}],"source_content_type":"text/x-python","patch_set":9,"id":"8bf2995e_f6952516","line":2062,"updated":"2021-07-27 16:28:04.000000000","message":"nit:\n\n  if resource_request:\n      if has_extended_resource_request_extension:\n          ...\n      else:\n          ...","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"384656fc7fbb6da3d020bfdee3215bece9f08cb9","unresolved":false,"context_lines":[{"line_number":2059,"context_line":"                    context, neutron, network_id)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"                if (has_extended_resource_request_extension and"},{"line_number":2062,"context_line":"                        resource_request):"},{"line_number":2063,"context_line":"                    # need to handle the new resource request format"},{"line_number":2064,"context_line":"                    resource_requests.extend("},{"line_number":2065,"context_line":"                        objects.RequestGroup.from_extended_port_request("}],"source_content_type":"text/x-python","patch_set":9,"id":"36bd36ac_2a6f2ebe","line":2062,"in_reply_to":"8bf2995e_f6952516","updated":"2021-08-16 19:31:43.000000000","message":"Done","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c67d443aaa6f9dbaf91f5627bc8c3c8e08ddfbb","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                        resource_request):"},{"line_number":2063,"context_line":"                    # need to handle the new resource request format"},{"line_number":2064,"context_line":"                    resource_requests.extend("},{"line_number":2065,"context_line":"                        objects.RequestGroup.from_extended_port_request("},{"line_number":2066,"context_line":"                            context\u003dNone,"},{"line_number":2067,"context_line":"                            port_resource_request\u003dresource_request))"},{"line_number":2068,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"15a959a6_b46876c8","line":2065,"updated":"2021-07-27 16:28:04.000000000","message":"Could do with the same NOTE from below here","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"384656fc7fbb6da3d020bfdee3215bece9f08cb9","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"                        resource_request):"},{"line_number":2063,"context_line":"                    # need to handle the new resource request format"},{"line_number":2064,"context_line":"                    resource_requests.extend("},{"line_number":2065,"context_line":"                        objects.RequestGroup.from_extended_port_request("},{"line_number":2066,"context_line":"                            context\u003dNone,"},{"line_number":2067,"context_line":"                            port_resource_request\u003dresource_request))"},{"line_number":2068,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"19d8e2bb_31037d7e","line":2065,"in_reply_to":"15a959a6_b46876c8","updated":"2021-08-16 19:31:43.000000000","message":"Done","commit_id":"4752e4eda032b2e2fa058a8bb8e6d347fb0216c3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0aa137bb466246f574fefca041f212b307151762","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"        tunneled \u003d False"},{"line_number":2066,"context_line":""},{"line_number":2067,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":2068,"context_line":"        has_extended_resource_request_extension \u003d ("},{"line_number":2069,"context_line":"            self._has_extended_resource_request_extension(context, neutron))"},{"line_number":2070,"context_line":"        resource_requests \u003d []"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"        for request_net in requested_networks:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f4d1bd1_58d23ff0","line":2069,"range":{"start_line":2068,"start_character":0,"end_line":2069,"end_character":76},"updated":"2021-08-27 10:11:35.000000000","message":"nit - Slightly odd to do this when it\u0027s only used once.","commit_id":"d6cd4420bb33501e267b10ccc3a1f26ab2c8c85b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8df6ff54b362704d28290ac2586f90a43269dce2","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"        tunneled \u003d False"},{"line_number":2066,"context_line":""},{"line_number":2067,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":2068,"context_line":"        has_extended_resource_request_extension \u003d ("},{"line_number":2069,"context_line":"            self._has_extended_resource_request_extension(context, neutron))"},{"line_number":2070,"context_line":"        resource_requests \u003d []"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"        for request_net in requested_networks:"}],"source_content_type":"text/x-python","patch_set":11,"id":"f9f2a0dc_30340f4a","line":2069,"range":{"start_line":2068,"start_character":0,"end_line":2069,"end_character":76},"in_reply_to":"9f4d1bd1_58d23ff0","updated":"2021-08-27 12:47:19.000000000","message":"Way ahead of you 😉 https://review.opendev.org/c/openstack/nova/+/800085/9..11/nova/network/neutron.py#b2038","commit_id":"d6cd4420bb33501e267b10ccc3a1f26ab2c8c85b"}]}