)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8ed94ba7f30fcc77b38447a8b2024870b5a97386","unresolved":true,"context_lines":[{"line_number":15,"context_line":"* Add service version check to the API"},{"line_number":16,"context_line":"* Remove blind rejection of the operation from the API"},{"line_number":17,"context_line":"* unit test coverage"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I73e6acf5adfffa9203efa3374671ec18f4ea79eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"df31d155_1db9a954","line":18,"updated":"2021-08-03 12:00:37.000000000","message":"blueprint: qos-minimum-guaranteed-packet-rate","commit_id":"8b96e6c80a7f131f3679a5124dbe3ae8fe74e285"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8207a234d043fc0bb0f0d18a01b5e1841c5f65e5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* Add service version check to the API"},{"line_number":16,"context_line":"* Remove blind rejection of the operation from the API"},{"line_number":17,"context_line":"* unit test coverage"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I73e6acf5adfffa9203efa3374671ec18f4ea79eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ed349eba_f35c74dd","line":18,"in_reply_to":"df31d155_1db9a954","updated":"2021-08-04 08:57:01.000000000","message":"Done","commit_id":"8b96e6c80a7f131f3679a5124dbe3ae8fe74e285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9b72b9237dd22da261d35e28019f5f0cb24965","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-04 18:41:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support interaface attach / detach with new resource request format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The interface attach and detach logic is now fully adapted to the new"},{"line_number":10,"context_line":"extended resource request format, and supports more than one request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"2b5e1433_440965a5","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":18},"updated":"2021-08-06 15:34:31.000000000","message":"interface","commit_id":"e18eab4d19c6a75b8b20591df80cc1a8d6676cd3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3fa0e5b013624c1ebf1f7a2a4666c393db9af86d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-04 18:41:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support interaface attach / detach with new resource request format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The interface attach and detach logic is now fully adapted to the new"},{"line_number":10,"context_line":"extended resource request format, and supports more than one request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"54abcba9_a2aa34f4","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":18},"in_reply_to":"2b5e1433_440965a5","updated":"2021-08-16 19:32:12.000000000","message":"Done","commit_id":"e18eab4d19c6a75b8b20591df80cc1a8d6676cd3"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bdd603b78174926dfdcf52c4ad69c00e975e4cdf","unresolved":true,"context_lines":[{"line_number":7638,"context_line":"        # are multiple groups. The policy can only come from the flavor today"},{"line_number":7639,"context_line":"        # and a new flavor is not provided with an interface attach request and"},{"line_number":7640,"context_line":"        # the instance\u0027s current flavor might not have a policy. So simply use"},{"line_number":7641,"context_line":"        # the \u0027none\u0027 as default as that is less"},{"line_number":7642,"context_line":"        rr \u003d scheduler_utils.ResourceRequest.from_request_groups("},{"line_number":7643,"context_line":"            request_groups, request_level_params, group_policy\u003d\u0027none\u0027)"},{"line_number":7644,"context_line":"        res \u003d self.reportclient.get_allocation_candidates(context, rr)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4ecdab5e_05512b5b","line":7641,"range":{"start_line":7641,"start_character":31,"end_line":7641,"end_character":47},"updated":"2021-07-19 12:30:39.000000000","message":"drop","commit_id":"0a96be92f8845af9e453d6cf6bf7ea4d6337c373"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"882d360966401740918e35fcb8448903c315ef2b","unresolved":true,"context_lines":[{"line_number":7642,"context_line":"        # one so we specify the least restrictive now."},{"line_number":7643,"context_line":"        rr \u003d scheduler_utils.ResourceRequest.from_request_groups("},{"line_number":7644,"context_line":"            request_groups, request_level_params, group_policy\u003d\u0027none\u0027)"},{"line_number":7645,"context_line":"        res \u003d self.reportclient.get_allocation_candidates(context, rr)"},{"line_number":7646,"context_line":"        alloc_reqs, provider_sums, version \u003d res"},{"line_number":7647,"context_line":""},{"line_number":7648,"context_line":"        if not alloc_reqs:"},{"line_number":7649,"context_line":"            # no allocation candidates available, we run out of free resources"}],"source_content_type":"text/x-python","patch_set":20,"id":"7231379c_20c69c1a","line":7646,"range":{"start_line":7645,"start_character":8,"end_line":7646,"end_character":48},"updated":"2021-08-06 10:50:17.000000000","message":"res could be None if connecting to placement failed. this is a bug since Wallaby when interface attach with qos was added here. I should file a bug and propose a fix separately.","commit_id":"e18eab4d19c6a75b8b20591df80cc1a8d6676cd3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e37123b288e22e37c6572ce60f3b3ab270c993c6","unresolved":false,"context_lines":[{"line_number":7642,"context_line":"        # one so we specify the least restrictive now."},{"line_number":7643,"context_line":"        rr \u003d scheduler_utils.ResourceRequest.from_request_groups("},{"line_number":7644,"context_line":"            request_groups, request_level_params, group_policy\u003d\u0027none\u0027)"},{"line_number":7645,"context_line":"        res \u003d self.reportclient.get_allocation_candidates(context, rr)"},{"line_number":7646,"context_line":"        alloc_reqs, provider_sums, version \u003d res"},{"line_number":7647,"context_line":""},{"line_number":7648,"context_line":"        if not alloc_reqs:"},{"line_number":7649,"context_line":"            # no allocation candidates available, we run out of free resources"}],"source_content_type":"text/x-python","patch_set":20,"id":"1022eac6_c5569e7c","line":7646,"range":{"start_line":7645,"start_character":8,"end_line":7646,"end_character":48},"in_reply_to":"7231379c_20c69c1a","updated":"2021-08-07 10:42:55.000000000","message":"handled in https://bugs.launchpad.net/nova/+bug/1939193","commit_id":"e18eab4d19c6a75b8b20591df80cc1a8d6676cd3"}],"nova/network/neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bdd603b78174926dfdcf52c4ad69c00e975e4cdf","unresolved":true,"context_lines":[{"line_number":1709,"context_line":"        if port:"},{"line_number":1710,"context_line":"            # if there is resource associated to this port then that needs to"},{"line_number":1711,"context_line":"            # be deallocated so lets return info about such allocation"},{"line_number":1712,"context_line":"            # TODO(gibi): need to adapt this to the new resource_request format"},{"line_number":1713,"context_line":"            # and remove the assumption that only one group of resources is"},{"line_number":1714,"context_line":"            # requested per port"},{"line_number":1715,"context_line":"            resource_request \u003d port.get(constants.RESOURCE_REQUEST, {})"},{"line_number":1716,"context_line":"            profile \u003d get_binding_profile(port)"},{"line_number":1717,"context_line":"            if self._has_extended_resource_request_extension(context, neutron):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b79a2371_1d578ad5","line":1714,"range":{"start_line":1712,"start_character":0,"end_line":1714,"end_character":32},"updated":"2021-07-19 12:30:39.000000000","message":"drop it","commit_id":"0a96be92f8845af9e453d6cf6bf7ea4d6337c373"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8207a234d043fc0bb0f0d18a01b5e1841c5f65e5","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"            LOG.debug(\u0027VirtualInterface not found for port: %s\u0027,"},{"line_number":1709,"context_line":"                      port_id, instance\u003dinstance)"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"        port_allocation \u003d {}"},{"line_number":1712,"context_line":"        if port:"},{"line_number":1713,"context_line":"            # if there is resource associated to this port then that needs to"},{"line_number":1714,"context_line":"            # be deallocated so lets return info about such allocation"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa12b01_eca5f51d","line":1711,"updated":"2021-08-04 08:57:01.000000000","message":"drop this due to L1685","commit_id":"f20ccfb25df5763060e14e3f15d7a64c7d3f9e53"}],"nova/tests/unit/scheduler/test_utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8207a234d043fc0bb0f0d18a01b5e1841c5f65e5","unresolved":true,"context_lines":[{"line_number":1367,"context_line":"            rgs, req_lvl_params, \u0027none\u0027)"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        self.assertEqual("},{"line_number":1370,"context_line":"            f\u0027group_policy\u003dnone\u0026\u0027"},{"line_number":1371,"context_line":"            f\u0027limit\u003d1000\u0026\u0027"},{"line_number":1372,"context_line":"            f\u0027required{uuids.group1}\u003d\u0027"},{"line_number":1373,"context_line":"                f\u0027CUSTOM_PHYSNET_2%2C\u0027"},{"line_number":1374,"context_line":"                f\u0027CUSTOM_VNIC_TYPE_NORMAL\u0026\u0027"},{"line_number":1375,"context_line":"            f\u0027required{uuids.group2}\u003d\u0027"},{"line_number":1376,"context_line":"                f\u0027CUSTOM_VNIC_TYPE_NORMAL\u0026\u0027"},{"line_number":1377,"context_line":"            f\u0027resources{uuids.group1}\u003d\u0027"},{"line_number":1378,"context_line":"                f\u0027NET_BW_EGR_KILOBIT_PER_SEC%3A1000%2C\u0027"},{"line_number":1379,"context_line":"                f\u0027NET_BW_IGR_KILOBIT_PER_SEC%3A1000\u0026\u0027"},{"line_number":1380,"context_line":"            f\u0027resources{uuids.group2}\u003d\u0027"},{"line_number":1381,"context_line":"                f\u0027NET_PACKET_RATE_KILOPACKET_PER_SEC%3A100\u0026\u0027"},{"line_number":1382,"context_line":"            f\u0027root_required\u003dCUSTOM_BLUE%2C%21CUSTOM_DIRTY\u0026\u0027"},{"line_number":1383,"context_line":"            f\u0027same_subtree\u003d{uuids.group1}%2C{uuids.group2}\u0027,"},{"line_number":1384,"context_line":"            rr.to_querystring())"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def test_resource_request_add_group_inserts_the_group(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"0c4e3832_dd7286c5","line":1383,"range":{"start_line":1370,"start_character":2,"end_line":1383,"end_character":59},"updated":"2021-08-04 08:57:01.000000000","message":"the order of the things in the query seems random :/","commit_id":"f4ef40f205a51acd03c6bb9becaa5470cfe0af1c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"66dfe228b5e1b1527b228ab3a0b76124a05d465d","unresolved":false,"context_lines":[{"line_number":1367,"context_line":"            rgs, req_lvl_params, \u0027none\u0027)"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        self.assertEqual("},{"line_number":1370,"context_line":"            f\u0027group_policy\u003dnone\u0026\u0027"},{"line_number":1371,"context_line":"            f\u0027limit\u003d1000\u0026\u0027"},{"line_number":1372,"context_line":"            f\u0027required{uuids.group1}\u003d\u0027"},{"line_number":1373,"context_line":"                f\u0027CUSTOM_PHYSNET_2%2C\u0027"},{"line_number":1374,"context_line":"                f\u0027CUSTOM_VNIC_TYPE_NORMAL\u0026\u0027"},{"line_number":1375,"context_line":"            f\u0027required{uuids.group2}\u003d\u0027"},{"line_number":1376,"context_line":"                f\u0027CUSTOM_VNIC_TYPE_NORMAL\u0026\u0027"},{"line_number":1377,"context_line":"            f\u0027resources{uuids.group1}\u003d\u0027"},{"line_number":1378,"context_line":"                f\u0027NET_BW_EGR_KILOBIT_PER_SEC%3A1000%2C\u0027"},{"line_number":1379,"context_line":"                f\u0027NET_BW_IGR_KILOBIT_PER_SEC%3A1000\u0026\u0027"},{"line_number":1380,"context_line":"            f\u0027resources{uuids.group2}\u003d\u0027"},{"line_number":1381,"context_line":"                f\u0027NET_PACKET_RATE_KILOPACKET_PER_SEC%3A100\u0026\u0027"},{"line_number":1382,"context_line":"            f\u0027root_required\u003dCUSTOM_BLUE%2C%21CUSTOM_DIRTY\u0026\u0027"},{"line_number":1383,"context_line":"            f\u0027same_subtree\u003d{uuids.group1}%2C{uuids.group2}\u0027,"},{"line_number":1384,"context_line":"            rr.to_querystring())"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def test_resource_request_add_group_inserts_the_group(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"696a2c34_31fde6ce","line":1383,"range":{"start_line":1370,"start_character":2,"end_line":1383,"end_character":59},"in_reply_to":"0c4e3832_dd7286c5","updated":"2021-08-04 16:51:25.000000000","message":"The query generation has been implemented to generate stable query string if run from the same input. To do that the value of the same_tree params are sorted. As the testcase run generates uuids randomly this does not make the generated query staring stable between test case runs.","commit_id":"f4ef40f205a51acd03c6bb9becaa5470cfe0af1c"}]}