)]}'
{"nova/virt/libvirt/volume/iscsi.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2fb141be15bd6ff676301e124cb8ed7ef6b4e3d8","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        \"\"\"Extend the volume.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"calling os-brick to extend iSCSI Volume\", instance\u003dinstance)"},{"line_number":86,"context_line":"        new_size \u003d self.connector.extend_volume(connection_info[\u0027data\u0027])"},{"line_number":87,"context_line":"        LOG.debug(\"Extend iSCSI Volume: new_size\u003d%s\","},{"line_number":88,"context_line":"                  new_size, instance\u003dinstance)"},{"line_number":89,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"52c63230_f4b417df","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":46},"updated":"2021-07-27 20:04:35.000000000","message":"In the context of LibvirtISCSIVolumeDriver we should always have connection_info[\u0027data\u0027][\u0027device_path\u0027] when extend_volume is called as prior to this connect_volume above should be called, populating the device_path.\n\nI think the fact we haven\u0027t for some reason in your env is the actual bug we need to address here. This relies on the connection_info being passed in here actually being saved to the BDM later within the virt block device layer:\n\nhttps://github.com/openstack/nova/blob/b5aa1de0abba959065e15d1b55fc13dae0b24f21/nova/virt/block_device.py#L609-L619\n\nThis is awful but AFAIK should be working.\n\nCan you update the bug with an example `openstack server event list $instance` where you see connection_info[\u0027data\u0027][\u0027device_path\u0027] unset?","commit_id":"ad60f23be3d562422b350aade04aa92ade39fb32"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"052ef459f22dfc489cfb92bbf7ed04d9c658340d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\"Extend the volume.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"calling os-brick to extend iSCSI Volume\", instance\u003dinstance)"},{"line_number":86,"context_line":"        new_size \u003d self.connector.extend_volume(connection_info[\u0027data\u0027])"},{"line_number":87,"context_line":"        LOG.debug(\"Extend iSCSI Volume: new_size\u003d%s\","},{"line_number":88,"context_line":"                  new_size, instance\u003dinstance)"},{"line_number":89,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"a33808e5_0508e9a5","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":46},"in_reply_to":"2a58d695_aef2fc30","updated":"2021-08-30 14:40:04.000000000","message":"Nice cooperation. Thanks!","commit_id":"ad60f23be3d562422b350aade04aa92ade39fb32"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"80fa89715ed24a98dfa9d8d8bf9092db98dff632","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        \"\"\"Extend the volume.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"calling os-brick to extend iSCSI Volume\", instance\u003dinstance)"},{"line_number":86,"context_line":"        new_size \u003d self.connector.extend_volume(connection_info[\u0027data\u0027])"},{"line_number":87,"context_line":"        LOG.debug(\"Extend iSCSI Volume: new_size\u003d%s\","},{"line_number":88,"context_line":"                  new_size, instance\u003dinstance)"},{"line_number":89,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"2a58d695_aef2fc30","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":46},"in_reply_to":"52c63230_f4b417df","updated":"2021-08-10 20:08:48.000000000","message":"Okay so https://bugs.launchpad.net/nova/+bug/1936439/comments/4 details an example where this can happen and I\u0027ve drafted a func regression test that I think asserts this, I\u0027ll write up a bug tomorrow and get that posted but this now LGTM as a quick short term fix.","commit_id":"ad60f23be3d562422b350aade04aa92ade39fb32"}]}