)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ac0c53dea04d4c1249603ccb13ccffad7e034c2c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fz9E%3D","line":9,"updated":"2014-03-13 16:53:19.000000000","message":"\"add new variables in\" -\u003e \"adds new elements to\"","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"313cdf1b21fb5184ea2133b1231d449ee7c420c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2F30U%3D","line":10,"updated":"2014-03-13 08:45:43.000000000","message":"Hi shuangtai, what\u0027s the libvirt version you are using when you got this bug?","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"0b5afdec1d58c88c0d1b2c0c0c6072b56a6ef59e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FwNM%3D","line":10,"in_reply_to":"AAAAWH%2F%2F1cI%3D","updated":"2014-03-14 01:47:04.000000000","message":"Intel\u0027s new CPU has a new feature Cache Qos Monitoring, you can see the detail in Haswell ref. We are try to add this feature in kernel ,xen, libvirt and openstack now. When I use my draft patches, I found this problem. Though waiting the kernel now, maybe next libvirt version can use this:)","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c6e6661b8d79f0c815bb17f43173d6092eb37830","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2F1cI%3D","line":10,"in_reply_to":"AAAAWH%2F%2F30U%3D","updated":"2014-03-13 14:11:03.000000000","message":"Good point, I also like to know the version. That would be a good info to review.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"c00be0a6689debbaf4575244bbe6ec1baa2fa1d7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FuAM%3D","line":10,"in_reply_to":"AAAAWH%2F%2Fu0Y%3D","updated":"2014-03-14 08:49:40.000000000","message":"I agree with you now, but your description of this problem should be updated.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"17e5150d62e90af34485b29d2c663c488d875c0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FlRw%3D","line":10,"in_reply_to":"AAAAWH%2F%2FuAM%3D","updated":"2014-03-16 07:14:03.000000000","message":"I agree  with Wangpan - please update the description of the problem.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"51aa30d36e3d99b6231edafe9df856e3e8992af1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FvkI%3D","line":10,"in_reply_to":"AAAAWH%2F%2Fv18%3D","updated":"2014-03-14 03:27:00.000000000","message":"I don\u0027t think so, in case the libvirt interface changes, openstack will fail. It doesn\u0027t make sense!","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"51dbc607b93916b2730a225bd71f9b53be6f48ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fu0Y%3D","line":10,"in_reply_to":"AAAAWH%2F%2FvUc%3D","updated":"2014-03-14 06:33:52.000000000","message":"I think this just a  minor problem only in openstack side,  using a list or a tuple is  fine in code format , why not use a safe way if  the risk  exist?  And we also use the list in the driver.py, keeping consistency may be good.\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1218","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0b19c669cb7130212db114ddad0747f09f0cd809","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FvUc%3D","line":10,"in_reply_to":"AAAAWH%2F%2FvkI%3D","updated":"2014-03-14 05:39:48.000000000","message":"Although not likely if the API changes your change might not work as well - we need a libvirt version so we can test it.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e6d7b8bcfee11a8817f3aba9d3bd41d5dee747f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FvhA%3D","line":10,"in_reply_to":"AAAAWH%2F%2FvkI%3D","updated":"2014-03-14 03:38:19.000000000","message":"There is time between the libvirt patch merger and a new libvirt release, and OpenStack takes a libvirt release version, not the trunk version.\nI feel we can wait for the libvirt patch merger.\n\nand also it is difficult to review this before the merger, because now the change of libvirt is not fixed and it would be possible to take the other way for this purpose on libvirt side.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"fde180410a3df64bc798609760479b96d32419bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t change list to tuple when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fv18%3D","line":10,"in_reply_to":"AAAAWH%2F%2FwNM%3D","updated":"2014-03-14 02:43:43.000000000","message":"I see now, but I think it\u0027s better to change this after your patch is merged into libvirt.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ac0c53dea04d4c1249603ccb13ccffad7e034c2c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0271a260a53fe8f5fc17b2934ebe3a3c9ee0c130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fz9g%3D","line":11,"updated":"2014-03-13 16:53:19.000000000","message":"\"information\" is misspelled. Also, this should read \"When we get...\"","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ac0c53dea04d4c1249603ccb13ccffad7e034c2c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0271a260a53fe8f5fc17b2934ebe3a3c9ee0c130"},{"line_number":15,"context_line":"Closes-Bug: #1291805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2Fz9c%3D","line":12,"updated":"2014-03-13 16:53:19.000000000","message":"I don\u0027t think we\u0027re converting it to a tuple from a list, so I don\u0027t think this is accurate. I think you should pick some other wording.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"0b5afdec1d58c88c0d1b2c0c0c6072b56a6ef59e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the libvirt add new variables in the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When get infomation from libvirt, we should not change"},{"line_number":12,"context_line":"list to tuple."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0271a260a53fe8f5fc17b2934ebe3a3c9ee0c130"},{"line_number":15,"context_line":"Closes-Bug: #1291805"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FwIg%3D","line":12,"in_reply_to":"AAAAWH%2F%2Fz9c%3D","updated":"2014-03-14 01:47:04.000000000","message":"@Dan, thanks, will do later.","commit_id":"21db4b82a16d21115b3964c15fb126fa8cc61ef2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3086b284be10e441a9f4bcbbcb12eedb286f10a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shuangtai Tian \u003cshuangtai.tian@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-16 21:21:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use the list when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt adds new elements to the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FiFM%3D","line":7,"updated":"2014-03-17 09:14:35.000000000","message":"infomation \u003d\u003e information","commit_id":"e433e0f15005d0a722c6a5db6aab822530241658"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"4b52a97c9a5e9dd290cdc2dec4cc4503dce4d6a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use the list when get infomation from libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the libvirt adds new elements to the domain info struct or others,"},{"line_number":10,"context_line":"when use the new libvirt, there will be a valueError (to many values"},{"line_number":11,"context_line":"to unpack). When we get information from libvirt, we should use the"},{"line_number":12,"context_line":"original variable format."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FkR0%3D","line":10,"updated":"2014-03-16 21:30:11.000000000","message":"nit: to-\u003e too","commit_id":"e433e0f15005d0a722c6a5db6aab822530241658"}]}