)]}'
{"nova/api/ec2/__init__.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"c2930bee409f259d1ae4246160ba4348a5aaa22a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"flags.DECLARE(\u0027use_forwarded_for\u0027, \u0027nova.api.auth\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"## Fault Wrapper around all EC2 requests ##"},{"line_number":54,"context_line":"class FaultWrapper(wsgi.Middleware):"},{"line_number":55,"context_line":"    \"\"\"Calls the middleware stack, captures any exceptions into faults.\"\"\""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAACn%2F%2F%2FEw%3D","line":53,"updated":"2011-11-10 23:24:06.000000000","message":"I think this is what docstrings are normally for, but not going to hold this up on that.","commit_id":"68111826afed69076d8b09363bb1191ecebe3b53"}],"nova/api/ec2/faults.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"56ca07aa4f661bc21c23cfcf0359a36a56addabc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import webob.dec"},{"line_number":16,"context_line":"import webob.exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.api.openstack import wsgi"},{"line_number":19,"context_line":"from nova import utils"},{"line_number":20,"context_line":"from nova import context"},{"line_number":21,"context_line":"from nova import flags"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F9Tw%3D","line":18,"updated":"2011-10-08 19:26:10.000000000","message":"Please don\u0027t import from the OSAPI in EC2 API, all code should be kept 100% separate or should be shared in another library.","commit_id":"235035f158662b15f52fe2889c598884b585cafa"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"56ca07aa4f661bc21c23cfcf0359a36a56addabc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Create a response for the given webob.exc.exception.\"\"\""},{"line_number":31,"context_line":"        self.wrapped_exc \u003d exception"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":34,"context_line":"    def __call__(self, req):"},{"line_number":35,"context_line":"        \"\"\"Generate a WSGI response based on the exception passed to ctor.\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F9Ts%3D","line":33,"updated":"2011-10-08 19:26:10.000000000","message":"It doesn\u0027t seem like you\u0027re using any features of wsgi.Request, so you should be able to replace this line with:\n\n@webob.dec.wsgify\n\nand then remove the import from nova.api.openstack.wsgi in my previous note.","commit_id":"235035f158662b15f52fe2889c598884b585cafa"},{"author":{"_account_id":1775,"name":"Ahmad Hassan","email":"ahmad.hassan@hp.com","username":"ahmad-hassan-q"},"change_message_id":"058320f139efebb3169f57a625131ce5fdeaa607","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Create a response for the given webob.exc.exception.\"\"\""},{"line_number":31,"context_line":"        self.wrapped_exc \u003d exception"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":34,"context_line":"    def __call__(self, req):"},{"line_number":35,"context_line":"        \"\"\"Generate a WSGI response based on the exception passed to ctor.\"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8Rg%3D","line":33,"in_reply_to":"AAAACX%2F%2F9Ts%3D","updated":"2011-10-20 09:17:39.000000000","message":"Thanks Brian for the suggestions. You are absolutely right. I will make these changes and pushed back the branch for review again. Ahmad","commit_id":"235035f158662b15f52fe2889c598884b585cafa"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"56ca07aa4f661bc21c23cfcf0359a36a56addabc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if code \u003d\u003d 501:"},{"line_number":44,"context_line":"            message \u003d \"The requested function is not supported\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        # Cast code into string"},{"line_number":47,"context_line":"        code \u003d str(code)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if \u0027AWSAccessKeyId\u0027 not in req.params:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F9To%3D","line":46,"updated":"2011-10-08 19:26:10.000000000","message":"In general this and the above comments aren\u0027t needed in the final product IMO. If they were removed this code is simple enough to speak for itself. I\u0027m not requesting you remove them, just that I personally think they might be over-documenting. :)","commit_id":"235035f158662b15f52fe2889c598884b585cafa"}],"nova/api/openstack/__init__.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"13e5d67fa69169478e5c06d59937ff8eadd034e0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        except Exception as ex:"},{"line_number":66,"context_line":"            LOG.exception(_(\"Caught error: %s\"), unicode(ex))"},{"line_number":67,"context_line":"            exc \u003d webob.exc.HTTPInternalServerError("},{"line_number":68,"context_line":"                  explanation\u003d\"Server Error, please try again later.\")"},{"line_number":69,"context_line":"            return faults.Fault(exc)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6hU%3D","line":68,"updated":"2011-10-26 15:44:22.000000000","message":"I don\u0027t think you need to specify an explanation here (or in the ec2 fault wrapper). If it\u0027s going to be constant, just let the message defined by webob take over.","commit_id":"235035f158662b15f52fe2889c598884b585cafa"}]}