)]}'
{"nova/tests/functional/regressions/test_bug_1937375.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5d4a857a89b9ad623281a40df5426558d488d93","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # TODO(lyarwood): Copied from test_bug_1675570.py, move both into"},{"line_number":37,"context_line":"    # _IntegratedTestBase."},{"line_number":38,"context_line":"    def _wait_for_volume_attach(self, server_id, volume_id):"},{"line_number":39,"context_line":"        timeout \u003d 0.0"},{"line_number":40,"context_line":"        server \u003d self.api.get_server(server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b663bb3_27de4d67","line":37,"updated":"2021-07-23 13:59:22.000000000","message":"I\u0027ll happily review a follow-up patch to do this while it\u0027s fresh in our minds, if you want to post one?","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b28bbb3043b14ab2c9703a5f3da6f5a338afc26","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # TODO(lyarwood): Copied from test_bug_1675570.py, move both into"},{"line_number":37,"context_line":"    # _IntegratedTestBase."},{"line_number":38,"context_line":"    def _wait_for_volume_attach(self, server_id, volume_id):"},{"line_number":39,"context_line":"        timeout \u003d 0.0"},{"line_number":40,"context_line":"        server \u003d self.api.get_server(server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b2e81cc_aee70cb1","line":37,"in_reply_to":"0b663bb3_27de4d67","updated":"2021-07-27 20:54:52.000000000","message":"ACK sure I\u0027ll do that now.","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"35c5aa4929f6b2ea241b4b9fdc796e7339133f9b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # TODO(lyarwood): Copied from test_bug_1675570.py, move both into"},{"line_number":37,"context_line":"    # _IntegratedTestBase."},{"line_number":38,"context_line":"    def _wait_for_volume_attach(self, server_id, volume_id):"},{"line_number":39,"context_line":"        timeout \u003d 0.0"},{"line_number":40,"context_line":"        server \u003d self.api.get_server(server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d128f4f0_7f17f656","line":37,"in_reply_to":"4b2e81cc_aee70cb1","updated":"2021-07-27 21:21:58.000000000","message":"I345dce93c6e2593c1ff1b863425f9a854c49ab9d","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"5885953dfe9dc5d7bc4848d6aa1c5467f80045ca","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            # reserve_block_device_name on the compute manager and call it"},{"line_number":68,"context_line":"            # twice to mimic two callers racing each other after the checks on"},{"line_number":69,"context_line":"            # the api."},{"line_number":70,"context_line":"            original_reserve_name(*args, **kwargs)"},{"line_number":71,"context_line":"            return original_reserve_name(*args, **kwargs)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        with mock.patch.object("},{"line_number":74,"context_line":"            self.compute.manager,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7e1ffb3_8a0f5bcb","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":57},"updated":"2021-07-23 13:38:57.000000000","message":"I guess that technically we should return the first bdm but it doesn\u0027t appear to matter in our functional tests as we aren\u0027t asserting anything about the way in which the volume is actually attached.\n\nIn reality returning the second bdm would leave us attached under vdc in the bdm but vdb in the instance.","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b28bbb3043b14ab2c9703a5f3da6f5a338afc26","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # reserve_block_device_name on the compute manager and call it"},{"line_number":68,"context_line":"            # twice to mimic two callers racing each other after the checks on"},{"line_number":69,"context_line":"            # the api."},{"line_number":70,"context_line":"            original_reserve_name(*args, **kwargs)"},{"line_number":71,"context_line":"            return original_reserve_name(*args, **kwargs)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        with mock.patch.object("},{"line_number":74,"context_line":"            self.compute.manager,"}],"source_content_type":"text/x-python","patch_set":2,"id":"856fbd8c_b3cb099b","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":57},"in_reply_to":"b7e1ffb3_8a0f5bcb","updated":"2021-07-27 20:54:52.000000000","message":"Done","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5d4a857a89b9ad623281a40df5426558d488d93","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        ):"},{"line_number":78,"context_line":"            self.api.post_server_volume("},{"line_number":79,"context_line":"                server_id, {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":80,"context_line":"            )"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Wait for a volume to be attached"},{"line_number":83,"context_line":"        self._wait_for_volume_attach(server_id, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad0be4b_5af4f271","line":80,"updated":"2021-07-23 13:59:22.000000000","message":"This could move to the client","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b28bbb3043b14ab2c9703a5f3da6f5a338afc26","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        ):"},{"line_number":78,"context_line":"            self.api.post_server_volume("},{"line_number":79,"context_line":"                server_id, {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":80,"context_line":"            )"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Wait for a volume to be attached"},{"line_number":83,"context_line":"        self._wait_for_volume_attach(server_id, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a39ea20b_5e934285","line":80,"in_reply_to":"5ad0be4b_5af4f271","updated":"2021-07-27 20:54:52.000000000","message":"Do you mean _IntegratedTestBase? Seems a little weird to wrap such a simple call there tbh.","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b8560c0433aa2f38dbe8a3124dcc367c4c2e81b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        ):"},{"line_number":78,"context_line":"            self.api.post_server_volume("},{"line_number":79,"context_line":"                server_id, {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":80,"context_line":"            )"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Wait for a volume to be attached"},{"line_number":83,"context_line":"        self._wait_for_volume_attach(server_id, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f37f8abe_c45feb79","line":80,"in_reply_to":"a39ea20b_5e934285","updated":"2021-07-28 10:09:34.000000000","message":"I meant \u0027TestOpenStackClient\u0027. That\u0027s what defines \u0027post_server_volume\u0027 but if there aren\u0027t any other top-level keys accepted by this API besides \u0027volumeAttachment\u0027 then we could at least fold that in. It\u0027s a nit though in any case and this probably doesn\u0027t warrant a wrapper, that\u0027s true.","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5d4a857a89b9ad623281a40df5426558d488d93","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":87,"context_line":"            ctxt, server_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # FIXME(lyarwood): This is bug #, we now have 3 bdms for the instance,"},{"line_number":90,"context_line":"        # the original root disk and two duplicate volume bdms for the same"},{"line_number":91,"context_line":"        # volume attachment."},{"line_number":92,"context_line":"        self.assertEqual(3, len(bdms))"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1f61036_2399d007","line":89,"range":{"start_line":89,"start_character":39,"end_line":89,"end_character":41},"updated":"2021-07-23 13:59:22.000000000","message":"whoops","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b28bbb3043b14ab2c9703a5f3da6f5a338afc26","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":87,"context_line":"            ctxt, server_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # FIXME(lyarwood): This is bug #, we now have 3 bdms for the instance,"},{"line_number":90,"context_line":"        # the original root disk and two duplicate volume bdms for the same"},{"line_number":91,"context_line":"        # volume attachment."},{"line_number":92,"context_line":"        self.assertEqual(3, len(bdms))"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdca50a0_9fb5aa69","line":89,"range":{"start_line":89,"start_character":39,"end_line":89,"end_character":41},"in_reply_to":"a1f61036_2399d007","updated":"2021-07-27 20:54:52.000000000","message":"Done","commit_id":"7253136cd1072cc7e3939c4c8863f8e215beaf25"}]}