)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8a86fb83dd743807ea1dbf2c72d258d3f147281","unresolved":true,"context_lines":[{"line_number":31,"context_line":"change values returned in the API to admins doing an instance show this"},{"line_number":32,"context_line":"will need to be done behind a new microversion to ensure backward"},{"line_number":33,"context_line":"compatibility with the previous behaviour and meaning of the HostStatus."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #1938326"},{"line_number":36,"context_line":"Change-Id: I45fd908b458e00b5e18848f624043ceb88b04825"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a08a098a_cca6e3ba","line":34,"updated":"2021-08-05 09:59:16.000000000","message":"thanks!","commit_id":"b8396f3f9401d1dd092b0ca2b95ffc3913b92236"}],"nova/compute/api.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"118fb27334d20605557c47315a26df76e15dbad0","unresolved":true,"context_lines":[{"line_number":5604,"context_line":"            alive \u003d self.servicegroup_api.service_is_up(service)"},{"line_number":5605,"context_line":"            # NOTE(lyarwood): Only mark disabled services that are still alive"},{"line_number":5606,"context_line":"            # as in MAINTENANCE to avoid requests to these services failing."},{"line_number":5607,"context_line":"            if service.disabled and alive:"},{"line_number":5608,"context_line":"                return fields_obj.HostStatus.MAINTENANCE"},{"line_number":5609,"context_line":""},{"line_number":5610,"context_line":"            if alive:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b43aab20_a0ed4fc4","line":5607,"updated":"2021-07-30 10:08:15.000000000","message":"nit:\n\n  if alive:\n    if service.disabled:\n      return fields_obj.HostStatus.MAINTENANCE\n    return fields_obj.HostStatus.UP\n  return fields_obj.HostStatus.UNKNOWN","commit_id":"8d4345f2d88947657c96f775f67472f6ee338777"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ddff074e91fb4aeeeecc33ada5ae6529bfd4a93","unresolved":true,"context_lines":[{"line_number":5605,"context_line":"            # NOTE(lyarwood): Only mark disabled services that are still alive"},{"line_number":5606,"context_line":"            # as in MAINTENANCE to avoid requests to these services failing."},{"line_number":5607,"context_line":"            if service.disabled and alive:"},{"line_number":5608,"context_line":"                return fields_obj.HostStatus.MAINTENANCE"},{"line_number":5609,"context_line":""},{"line_number":5610,"context_line":"            if alive:"},{"line_number":5611,"context_line":"                return fields_obj.HostStatus.UP"}],"source_content_type":"text/x-python","patch_set":3,"id":"87b7eab6_e57149ee","line":5608,"range":{"start_line":5608,"start_character":45,"end_line":5608,"end_character":56},"updated":"2021-08-04 12:22:03.000000000","message":"Please update the documentation of the HostStatus enum so that MAINTENANCE means disabled but up.","commit_id":"21dd572ac305da2fc647096540901be75e9cb05d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5b1fc723e0cb92a5c06d3d3781f0ba26baf64654","unresolved":true,"context_lines":[{"line_number":4866,"context_line":"            instance_actions.DETACH_VOLUME)"},{"line_number":4867,"context_line":"        detach_volume(self, context, instance, bdms)"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"    @check_instance_host(check_is_up\u003dTrue)"},{"line_number":4870,"context_line":"    def _detach_volume(self, context, instance, volume):"},{"line_number":4871,"context_line":"        try:"},{"line_number":4872,"context_line":"            self.volume_api.begin_detaching(context, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ec8e1e5_6d6f7dea","line":4869,"updated":"2021-08-05 13:45:35.000000000","message":"This is the only other place that the check_is_up param is used, and it should also obey the same logic of \"make sure host is *actually* running\", so no issues here...","commit_id":"b8396f3f9401d1dd092b0ca2b95ffc3913b92236"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72293f50a5c17dc2613fb74b7ecb2cbb4169e2d9","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    At a minimum this method will check that the instance.host is set."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    :param check_is_up: If True, check that the instance.host status is UP"},{"line_number":199,"context_line":"        or MAINTENANCE (disabled but not down)."},{"line_number":200,"context_line":"    :raises: InstanceNotReady if the instance.host is not set"},{"line_number":201,"context_line":"    :raises: ServiceUnavailable if check_is_up\u003dTrue and the instance.host"},{"line_number":202,"context_line":"        compute service status is not UP or MAINTENANCE"}],"source_content_type":"text/x-python","patch_set":8,"id":"806e1248_7df139fb","line":199,"range":{"start_line":198,"start_character":72,"end_line":199,"end_character":46},"updated":"2021-08-25 02:16:47.000000000","message":"At first I thought this needs to be updated but service_is_up essentially does this, so it doesn\u0027t seem an incorrect way to describe the check.","commit_id":"da6af3fb224d5033980537f8a677437c464c12b1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72293f50a5c17dc2613fb74b7ecb2cbb4169e2d9","unresolved":true,"context_lines":[{"line_number":212,"context_line":"                service \u003d ["},{"line_number":213,"context_line":"                    service for service in instance.services"},{"line_number":214,"context_line":"                        if service.binary \u003d\u003d \u0027nova-compute\u0027][0]"},{"line_number":215,"context_line":"                if not self.servicegroup_api.service_is_up(service):"},{"line_number":216,"context_line":"                    # ComputeServiceUnavailable would make more sense here but"},{"line_number":217,"context_line":"                    # we do not want to leak hostnames to end users."},{"line_number":218,"context_line":"                    raise exception.ServiceUnavailable()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5bacddbb_4d417b0b","line":215,"range":{"start_line":215,"start_character":45,"end_line":215,"end_character":58},"updated":"2021-08-25 02:16:47.000000000","message":"Note to self: this is a subset of what get_instance_host_status does.","commit_id":"da6af3fb224d5033980537f8a677437c464c12b1"}]}