)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"1629a21d517c07c16117916c5aed8299f5bfd3a5","unresolved":false,"context_lines":[{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.RESCUED"},{"line_number":1190,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"    def test_destroy(self):"},{"line_number":1193,"context_line":"        self._create_vm()"},{"line_number":1194,"context_line":"        info \u003d self.conn.get_info({\u0027uuid\u0027: self.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FUcg%3D","line":1191,"updated":"2014-03-18 16:50:18.000000000","message":"is there something to be checked here to make sure the rescue disk was destroyed?","commit_id":"1205916a1cf7f3c73ec89d07dea2d766ea26f589"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"703847856bdc9327e8ec17b251c83c5b6ba9d6e1","unresolved":false,"context_lines":[{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.RESCUED"},{"line_number":1190,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"    def test_destroy(self):"},{"line_number":1193,"context_line":"        self._create_vm()"},{"line_number":1194,"context_line":"        info \u003d self.conn.get_info({\u0027uuid\u0027: self.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FURc%3D","line":1191,"in_reply_to":"AAAAWH%2F%2FUcg%3D","updated":"2014-03-18 17:06:41.000000000","message":"Done","commit_id":"1205916a1cf7f3c73ec89d07dea2d766ea26f589"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d81d9b111a4cb95e7f6765b4a55f5df804cee2b2","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"    def destroy_rescued(self, fake_func):"},{"line_number":1180,"context_line":"        self._rescue()"},{"line_number":1181,"context_line":"        self.stubs.Set(self.conn._volumeops, \"detach_disk_from_vm\","},{"line_number":1182,"context_line":"                       fake_func)"},{"line_number":1183,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.RESCUED"},{"line_number":1184,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1185,"context_line":"        inst_file_path \u003d \u0027[%s] %s/%s.vmdk\u0027 % (self.ds, self.uuid, self.uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAWH%2F9s3o%3D","line":1182,"updated":"2014-04-02 17:47:34.000000000","message":"Can we use mock instead of mox for new tests? Doing so would also mean you wouldn\u0027t need to use fake functions and instead could just use the mock object\u0027s assert_called_once_with() assertions.","commit_id":"1597830e7d28de7f4f5d32fcf847a0fa932b0ceb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"25db9f2d5e23d665a057baa7923b60c9266ae559","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"    def destroy_rescued(self, fake_func):"},{"line_number":1180,"context_line":"        self._rescue()"},{"line_number":1181,"context_line":"        self.stubs.Set(self.conn._volumeops, \"detach_disk_from_vm\","},{"line_number":1182,"context_line":"                       fake_func)"},{"line_number":1183,"context_line":"        self.instance[\u0027vm_state\u0027] \u003d vm_states.RESCUED"},{"line_number":1184,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1185,"context_line":"        inst_file_path \u003d \u0027[%s] %s/%s.vmdk\u0027 % (self.ds, self.uuid, self.uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAWH%2F9sjo%3D","line":1182,"in_reply_to":"AAAAWH%2F9s3o%3D","updated":"2014-04-02 18:20:55.000000000","message":"Done","commit_id":"1597830e7d28de7f4f5d32fcf847a0fa932b0ceb"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"a94295aa5a89d4aa7d448d745e3e9f2e69061787","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    def destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":1068,"context_line":"                instance_name\u003dNone):"},{"line_number":1069,"context_line":"        # If there is a rescue VM then we need to destroy that one too"},{"line_number":1070,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1071,"context_line":"            rescue_name \u003d instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1072,"context_line":"            self._destroy(instance, network_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fz%2FY%3D","line":1069,"updated":"2014-03-13 16:49:48.000000000","message":"If this one is public, shouldn\u0027t it be the one with the public documentation?","commit_id":"c1ad553a0ead913bd3859b353ec38deacde1f9b0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9cf4ccc81d2fcd43b0d34dcba0ed4b14d3432c5b","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    def destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":1068,"context_line":"                instance_name\u003dNone):"},{"line_number":1069,"context_line":"        # If there is a rescue VM then we need to destroy that one too"},{"line_number":1070,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1071,"context_line":"            rescue_name \u003d instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1072,"context_line":"            self._destroy(instance, network_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FzD0%3D","line":1069,"in_reply_to":"AAAAWH%2F%2Fz%2FY%3D","updated":"2014-03-13 18:40:37.000000000","message":"This is public for the vmops. I have added a comment.","commit_id":"c1ad553a0ead913bd3859b353ec38deacde1f9b0"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"2c2b32fdb0e960c8043a775f5e33b8f1c30a8866","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        1. Power off the VM, if it is in poweredOn state."},{"line_number":994,"context_line":"        2. Un-register a VM."},{"line_number":995,"context_line":"        3. Delete the contents of the folder holding the VM related data."},{"line_number":996,"context_line":"        \"\"\""},{"line_number":997,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":998,"context_line":"        # for example when the spawn of a rescue instance takes place."},{"line_number":999,"context_line":"        if not instance_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fy2A%3D","line":996,"updated":"2014-03-13 19:09:13.000000000","message":"I *think* you should remove lines 992 to 996 but I\u0027m not 100% certain it\u0027s important. I think you want to remove those lines because it seems like you intend on making this a \"hidden\" method that people don\u0027t use.","commit_id":"b80e825b3f1792750c35710bed34fd6cf2790bb9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0ce5637e006757cf6fbcf92d23bfcb2f03d023be","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        1. Power off the VM, if it is in poweredOn state."},{"line_number":994,"context_line":"        2. Un-register a VM."},{"line_number":995,"context_line":"        3. Delete the contents of the folder holding the VM related data."},{"line_number":996,"context_line":"        \"\"\""},{"line_number":997,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":998,"context_line":"        # for example when the spawn of a rescue instance takes place."},{"line_number":999,"context_line":"        if not instance_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FuJg%3D","line":996,"in_reply_to":"AAAAWH%2F%2Fy2A%3D","updated":"2014-03-14 08:27:46.000000000","message":"Not really sure what you mean by this comment. The method is a private method and can be used by any method internally in vmops.","commit_id":"b80e825b3f1792750c35710bed34fd6cf2790bb9"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"426f205bafac8f11d84c106158ee77460fe182c8","unresolved":false,"context_lines":[{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def _destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":991,"context_line":"                 instance_name\u003dNone):"},{"line_number":992,"context_line":"        \"\"\"Destroy a VM instance.\"\"\""},{"line_number":993,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":994,"context_line":"        # for example when the spawn of a rescue instance takes place."},{"line_number":995,"context_line":"        if not instance_name:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Fe0I%3D","line":992,"updated":"2014-03-17 16:39:14.000000000","message":"If this is a private method, I\u0027m going to block on \"No Docstring\" here. I can be convinced otherwise, but I think we should have a policy of \"#\" documentation on private methods.","commit_id":"7dd5a21446c6c53d0e956d14ece823149d5bb3ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7433ce73206eb39913a36bdd3f7b943c25a449c6","unresolved":false,"context_lines":[{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def _destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":991,"context_line":"                 instance_name\u003dNone):"},{"line_number":992,"context_line":"        \"\"\"Destroy a VM instance.\"\"\""},{"line_number":993,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":994,"context_line":"        # for example when the spawn of a rescue instance takes place."},{"line_number":995,"context_line":"        if not instance_name:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FY04%3D","line":992,"in_reply_to":"AAAAWH%2F%2Fe0I%3D","updated":"2014-03-18 07:46:29.000000000","message":"I have removed the docstring. I suggest that you write a mail to the list to get a global project consensus for this. wair","commit_id":"7dd5a21446c6c53d0e956d14ece823149d5bb3ec"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"1629a21d517c07c16117916c5aed8299f5bfd3a5","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"            LOG.exception(exc, instance\u003dinstance)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def _destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":1009,"context_line":"                 instance_name\u003dNone):"},{"line_number":1010,"context_line":"        # Destroy a VM instance"},{"line_number":1011,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":1012,"context_line":"        # for example when the spawn of a rescue instance takes place."}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FUdA%3D","line":1009,"updated":"2014-03-18 16:50:18.000000000","message":"Im thinking it would be clearer to name this destroy_instance.  Its confusing to me to call it _destroy and then have a destroy method that calls it.  I like that you pulled the rescue stuff into a new destroy method though.","commit_id":"1205916a1cf7f3c73ec89d07dea2d766ea26f589"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"703847856bdc9327e8ec17b251c83c5b6ba9d6e1","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"            LOG.exception(exc, instance\u003dinstance)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def _destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":1009,"context_line":"                 instance_name\u003dNone):"},{"line_number":1010,"context_line":"        # Destroy a VM instance"},{"line_number":1011,"context_line":"        # Get the instance name. In some cases this may differ from the \u0027uuid\u0027,"},{"line_number":1012,"context_line":"        # for example when the spawn of a rescue instance takes place."}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2FUVs%3D","line":1009,"in_reply_to":"AAAAWH%2F%2FUdA%3D","updated":"2014-03-18 17:06:41.000000000","message":"very good idea","commit_id":"1205916a1cf7f3c73ec89d07dea2d766ea26f589"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"80bff165d3e6b3ec96a62abcab8a72c382c1300c","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"        LOG.debug(_(\"Destroying instance\"), instance\u003dinstance)"},{"line_number":1092,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1093,"context_line":"            LOG.debug(_(\"Rescue VM configured\"), instance\u003dinstance)"},{"line_number":1094,"context_line":"            self.unrescue(instance, power_on\u003dFalse)"},{"line_number":1095,"context_line":"            LOG.debug(_(\"Rescue VM detroyed\"), instance\u003dinstance)"},{"line_number":1096,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1097,"context_line":"                               destroy_disks\u003ddestroy_disks)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2FUIs%3D","line":1094,"updated":"2014-03-18 17:16:57.000000000","message":"What if unrescue fails? Why not just delete both VMs?","commit_id":"784cc4636626bfce181593c26e3035b137a8c665"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8037cdf363075240839a5d982827762a5b3b5107","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"        LOG.debug(_(\"Destroying instance\"), instance\u003dinstance)"},{"line_number":1092,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1093,"context_line":"            LOG.debug(_(\"Rescue VM configured\"), instance\u003dinstance)"},{"line_number":1094,"context_line":"            self.unrescue(instance, power_on\u003dFalse)"},{"line_number":1095,"context_line":"            LOG.debug(_(\"Rescue VM detroyed\"), instance\u003dinstance)"},{"line_number":1096,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1097,"context_line":"                               destroy_disks\u003ddestroy_disks)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2FTzI%3D","line":1094,"in_reply_to":"AAAAWH%2F%2FUIs%3D","updated":"2014-03-18 17:53:11.000000000","message":"the unrescue is a lot cleaner - it detaches a disk. i\u0027ll add in the treatment if it fails","commit_id":"784cc4636626bfce181593c26e3035b137a8c665"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1cc725694688ad78b739283e7ea7d61403f12adf","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                self._destroy_instance(instance, network_info,"},{"line_number":1099,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1100,"context_line":"                                       instance_name\u003drescue_name)"},{"line_number":1101,"context_line":"            LOG.debug(_(\"Rescue VM detroyed\"), instance\u003dinstance)"},{"line_number":1102,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1103,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1104,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2FSQk%3D","line":1101,"updated":"2014-03-18 21:37:42.000000000","message":"s/detroyed/destroyed/","commit_id":"ed1e598432cb787408ce1a81a5c68461b91accd1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"90f096ad62c3fe80b884a4084ad9d59957f7365f","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                self._destroy_instance(instance, network_info,"},{"line_number":1099,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1100,"context_line":"                                       instance_name\u003drescue_name)"},{"line_number":1101,"context_line":"            LOG.debug(_(\"Rescue VM detroyed\"), instance\u003dinstance)"},{"line_number":1102,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1103,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1104,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAWH%2F%2FPSk%3D","line":1101,"in_reply_to":"AAAAWH%2F%2FSQk%3D","updated":"2014-03-19 07:25:30.000000000","message":"Done","commit_id":"ed1e598432cb787408ce1a81a5c68461b91accd1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"5a6730551b65e87c186221e5ee3352b126a8a587","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1073,"context_line":"            LOG.debug(_(\"Rescue VM configured\"), instance\u003dinstance)"},{"line_number":1074,"context_line":"            try:"},{"line_number":1075,"context_line":"                self.unrescue(instance, power_on\u003dFalse)"},{"line_number":1076,"context_line":"            except Exception:"},{"line_number":1077,"context_line":"                rescue_name \u003d instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1078,"context_line":"                self._destroy_instance(instance, network_info,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAWH%2F93Dc%3D","line":1075,"updated":"2014-04-01 15:40:52.000000000","message":"Shouldn\u0027t unrescue handle making sure the destroy happens? instead of the code just below this?","commit_id":"4195756ceb17fcc3e3cc5fb9340463926414866c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"57f4d69531147987e05bb371408b45bd033f3cf7","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        if instance[\u0027vm_state\u0027] \u003d\u003d vm_states.RESCUED:"},{"line_number":1073,"context_line":"            LOG.debug(_(\"Rescue VM configured\"), instance\u003dinstance)"},{"line_number":1074,"context_line":"            try:"},{"line_number":1075,"context_line":"                self.unrescue(instance, power_on\u003dFalse)"},{"line_number":1076,"context_line":"            except Exception:"},{"line_number":1077,"context_line":"                rescue_name \u003d instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1078,"context_line":"                self._destroy_instance(instance, network_info,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAWH%2F9xNo%3D","line":1075,"in_reply_to":"AAAAWH%2F93Dc%3D","updated":"2014-04-02 08:58:55.000000000","message":"i think that these are 2 different cases. in the unrescue if an exception occurs we should elevate that to the user.\nin this case the original vm is being deleted and we want to make sure that tthe datastore files and the image are actually deleted for the rescue vm.. that is why we have this exception handling here.","commit_id":"4195756ceb17fcc3e3cc5fb9340463926414866c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"025e875352f64423afc0f3a4bb523ebdfe9b0d5a","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                datastore_name, vmx_file_path \u003d _ds_path"},{"line_number":1012,"context_line":"            # Power off the VM if it is in PoweredOn state."},{"line_number":1013,"context_line":"            if pwr_state \u003d\u003d \"poweredOn\":"},{"line_number":1014,"context_line":"                LOG.debug(_(\"Powering off the VM\"), instance\u003dinstance)"},{"line_number":1015,"context_line":"                poweroff_task \u003d self._session._call_method("},{"line_number":1016,"context_line":"                       self._session._get_vim(),"},{"line_number":1017,"context_line":"                       \"PowerOffVM_Task\", vm_ref)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9w2c%3D","line":1014,"updated":"2014-04-02 09:46:11.000000000","message":"Can you use the new _power_off_vm_ref method introduced by Ib1f387a41abe2b52357854e90c2535ebb7b43f18 ?","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"46c8d0fd9b003b46cf391f48a1700f3846a83dfe","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                datastore_name, vmx_file_path \u003d _ds_path"},{"line_number":1012,"context_line":"            # Power off the VM if it is in PoweredOn state."},{"line_number":1013,"context_line":"            if pwr_state \u003d\u003d \"poweredOn\":"},{"line_number":1014,"context_line":"                LOG.debug(_(\"Powering off the VM\"), instance\u003dinstance)"},{"line_number":1015,"context_line":"                poweroff_task \u003d self._session._call_method("},{"line_number":1016,"context_line":"                       self._session._get_vim(),"},{"line_number":1017,"context_line":"                       \"PowerOffVM_Task\", vm_ref)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9wc8%3D","line":1014,"in_reply_to":"AAAAWH%2F9w2c%3D","updated":"2014-04-02 10:31:14.000000000","message":"this code is based on that code. not sure what you mean here","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5b8f423e8389770529bf0921118e0770cc8fd1b","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                datastore_name, vmx_file_path \u003d _ds_path"},{"line_number":1012,"context_line":"            # Power off the VM if it is in PoweredOn state."},{"line_number":1013,"context_line":"            if pwr_state \u003d\u003d \"poweredOn\":"},{"line_number":1014,"context_line":"                LOG.debug(_(\"Powering off the VM\"), instance\u003dinstance)"},{"line_number":1015,"context_line":"                poweroff_task \u003d self._session._call_method("},{"line_number":1016,"context_line":"                       self._session._get_vim(),"},{"line_number":1017,"context_line":"                       \"PowerOffVM_Task\", vm_ref)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9wHM%3D","line":1014,"in_reply_to":"AAAAWH%2F9wc8%3D","updated":"2014-04-02 11:38:32.000000000","message":"I though to replace the lines 1015-1018 by self._power_off_vm_ref(vm_ref)\n\ndoes it make sense?","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"025e875352f64423afc0f3a4bb523ebdfe9b0d5a","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            except Exception as excep:"},{"line_number":1028,"context_line":"                LOG.warn(_(\"In vmwareapi:vmops:_destroy_instance, got this \""},{"line_number":1029,"context_line":"                           \"exception while un-registering the VM: %s\"),"},{"line_number":1030,"context_line":"                         str(excep))"},{"line_number":1031,"context_line":"            # Delete the folder holding the VM related content on"},{"line_number":1032,"context_line":"            # the datastore."},{"line_number":1033,"context_line":"            if destroy_disks and datastore_name:"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9w5E%3D","line":1030,"updated":"2014-04-02 09:46:11.000000000","message":"nit: because you are updating the log message, using six.text_type could be nice but not necessary since we don\u0027t really have rules for py3 compatibility","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"025e875352f64423afc0f3a4bb523ebdfe9b0d5a","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                               {\u0027datastore_name\u0027: datastore_name},"},{"line_number":1051,"context_line":"                              instance\u003dinstance)"},{"line_number":1052,"context_line":"                except Exception as excep:"},{"line_number":1053,"context_line":"                    LOG.warn(_(\"In vmwareapi:vmops:_destroy_instance, \""},{"line_number":1054,"context_line":"                                \"got this exception while deleting \""},{"line_number":1055,"context_line":"                                \"the VM contents from the disk: %s\"),"},{"line_number":1056,"context_line":"                             str(excep))"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9w48%3D","line":1053,"updated":"2014-04-02 09:46:11.000000000","message":"ditto","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"025e875352f64423afc0f3a4bb523ebdfe9b0d5a","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"                                adapter_type, disk_type, vmdk_path)"},{"line_number":1161,"context_line":"        self._power_on(instance, vm_ref\u003drescue_vm_ref)"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    def unrescue(self, instance, power_on\u003dTrue):"},{"line_number":1164,"context_line":"        \"\"\"Unrescue the specified instance.\"\"\""},{"line_number":1165,"context_line":"        # Get the original vmdk_path"},{"line_number":1166,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9w0Y%3D","line":1163,"updated":"2014-04-02 09:46:11.000000000","message":"Sorry but i\u0027m not sure to understand why you have introduced this new parameter?","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5b8f423e8389770529bf0921118e0770cc8fd1b","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"                                adapter_type, disk_type, vmdk_path)"},{"line_number":1161,"context_line":"        self._power_on(instance, vm_ref\u003drescue_vm_ref)"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    def unrescue(self, instance, power_on\u003dTrue):"},{"line_number":1164,"context_line":"        \"\"\"Unrescue the specified instance.\"\"\""},{"line_number":1165,"context_line":"        # Get the original vmdk_path"},{"line_number":1166,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAWH%2F9wGY%3D","line":1163,"in_reply_to":"AAAAWH%2F9w0Y%3D","updated":"2014-04-02 11:38:32.000000000","message":"and about this new arg?","commit_id":"997f85abe2ec557bd53c4873931fda17a9542ca2"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d81d9b111a4cb95e7f6765b4a55f5df804cee2b2","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                self._destroy_instance(instance, network_info,"},{"line_number":1079,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1080,"context_line":"                                       instance_name\u003drescue_name)"},{"line_number":1081,"context_line":"            LOG.debug(_(\"Rescue VM destroyed\"), instance\u003dinstance)"},{"line_number":1082,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1083,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1084,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAWH%2F9s2I%3D","line":1081,"updated":"2014-04-02 17:47:34.000000000","message":"This log line should go right under line 1075 within the try block.","commit_id":"1597830e7d28de7f4f5d32fcf847a0fa932b0ceb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"25db9f2d5e23d665a057baa7923b60c9266ae559","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                self._destroy_instance(instance, network_info,"},{"line_number":1079,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1080,"context_line":"                                       instance_name\u003drescue_name)"},{"line_number":1081,"context_line":"            LOG.debug(_(\"Rescue VM destroyed\"), instance\u003dinstance)"},{"line_number":1082,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1083,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1084,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAWH%2F9ssw%3D","line":1081,"in_reply_to":"AAAAWH%2F9s2I%3D","updated":"2014-04-02 18:20:55.000000000","message":"Done","commit_id":"1597830e7d28de7f4f5d32fcf847a0fa932b0ceb"}]}