)]}'
{"id":"openstack%2Fnova~803094","triplet_id":"openstack%2Fnova~stable%2Fussuri~I546d376869a992601b443fb95acf1034da2a8f36","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1927677","hashtags":[],"change_id":"I546d376869a992601b443fb95acf1034da2a8f36","subject":"Reduce mocking in test_reject_open_redirect for compat","status":"MERGED","created":"2021-07-31 01:00:28.000000000","updated":"2021-09-14 18:28:19.000000000","submitted":"2021-09-14 18:22:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"803094-bug/1927677","meta_rev_id":"23e59d259f784df0d6764db5cd10602cda37d227","_number":803094,"virtual_id_number":803094,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-14 18:22:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2021-09-08 15:44:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2021-09-08 15:01:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2021-09-14 15:46:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-31 01:25:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-31 03:39:44.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-09-08 15:01:48.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-09-08 15:44:12.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"}],"messages":[{"id":"36863d2b473fe0cc217f6a69e929bf8106ab0702","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-31 01:00:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d49224e8ef3c3d7f766347f0398904509edf6214","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-31 01:25:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5063a0b9465448f1aff8d3cc42896705 : SUCCESS in 16m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0f6212e5ca8f4e458012dcc5437377a2 : SUCCESS in 15m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1190c23fe9a54f739293aa9d7690144e : FAILURE in 8m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fd62d02296774ad290fe7933e3709d30 : SUCCESS in 14m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/dc1a9b040bc847608fac687c3d1d706b : SUCCESS in 14m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5bb25ffae0e84651ab90938c15d554db : SUCCESS in 15m 48s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/89ac98deab874e35a3c440aad379a0f5 : SUCCESS in 19m 30s","accounts_in_message":[],"_revision_number":1},{"id":"5e42f64e6ec7a2806a081edf75a2e2aeecb53fe4","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-07-31 03:39:44.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/803094/1/iscsi : SUCCESS in 2h 37m 02s","accounts_in_message":[],"_revision_number":1},{"id":"6d82a00246e4557a5c0e27e49c3f29c1f20da5e2","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-09-08 15:01:48.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick of a test-only, follow up change from stable/victoria, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"1644524d285db11bc2515b6cb9df5b867420d519","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-09-08 15:02:21.000000000","message":"Patch Set 1:\n\nrecheck - the patch has merged in stable/victoria, pep8 should pass now","accounts_in_message":[],"_revision_number":1},{"id":"e30fec1c1bc579e37bd0ca95aa9144c4989c6fd9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-08 15:25:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/36aceffb50ae43e082cb205f934c18a1 : SUCCESS in 17m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ca8825c48f3e4b319bbc161529fe4373 : SUCCESS in 15m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44da24d2fcfc4489ad1d96d6da42e015 : SUCCESS in 9m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1fe8608201ec4863913ff3912309e54e : SUCCESS in 13m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/da9ef7982c574e70a01916c982170fdb : SUCCESS in 15m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e310798363284cd391edba9dbc8041da : SUCCESS in 12m 52s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/cfdf42ec86b4472ab17188a1e89ac56d : SUCCESS in 16m 48s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/70c4b83efae846c2b496d64f396d405d : SUCCESS in 6m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7d45a64e9b44ef3ae8959b42d852896fff758721","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-09-08 15:44:12.000000000","message":"Patch Set 1: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"6e5edd1c28e84a9f978f9e46bdad196549f81de2","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-09-08 17:54:59.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/803094/1/iscsi : SUCCESS in 2h 41m 17s","accounts_in_message":[],"_revision_number":1},{"id":"8960a8c9dbb2c901cd2741082f08e8d55f90eace","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-09-14 15:46:45.000000000","message":"Patch Set 1: Workflow+1\n\nWell, considering that\n* this patch is a test-only follow-up patch\n* clean backport\n* coming from melwitt, who is also a nova stable core\n* has another +1 review from Takashi\nlet\u0027s fast approve it now.","accounts_in_message":[],"_revision_number":1},{"id":"15af47b3ec635a98a20c46e8fedd3e715fb1ef1d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-14 15:48:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0b110aa4ee20595ca83c4df053f4cbd77866b305","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-14 18:22:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e324571972d94317ae3efc5b768140c2 : SUCCESS in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/41e13f6f635244d79ba095a33a22e8e3 : SUCCESS in 11m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aab3ff57b4bf44c48d978540f958f86c : SUCCESS in 14m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7750d3efd87440989a0f2b0d0f91d432 : SUCCESS in 14m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e29f9adf58114fd9833330a98201fcbb : SUCCESS in 12m 38s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/5e7aaecd7de04114bf51e49d7e935c87 : SUCCESS in 18m 46s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/6aa6fac138d9421db2401365f61e03b1 : SUCCESS in 8m 19s","accounts_in_message":[],"_revision_number":1},{"id":"47b859639292ab179478b7b324aa53c6fea8ecfd","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-14 18:22:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"23e59d259f784df0d6764db5cd10602cda37d227","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-14 18:28:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a503ef3b4d642a6a680a56b2a986856 : SUCCESS in 1m 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d43b88a33407b1253e7bce70f720a44f7688141f","revisions":{"d43b88a33407b1253e7bce70f720a44f7688141f":{"kind":"REWORK","_number":1,"created":"2021-07-31 01:00:28.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/94/803094/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/94/803094/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/803094/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/803094/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/94/803094/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/94/803094/1"}}},"commit":{"parents":[{"commit":"719e651e6be277950632e0c2cf5cc9a018344e7b","subject":"Reject open redirection in the console proxy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/719e651e6be277950632e0c2cf5cc9a018344e7b"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-31 00:30:16.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-31 01:00:00.000000000","tz":0},"subject":"Reduce mocking in test_reject_open_redirect for compat","message":"Reduce mocking in test_reject_open_redirect for compat\n\nThis is a followup for change Ie36401c782f023d1d5f2623732619105dc2cfa24\nto reduce mocking in the unit test coverage for it.\n\nWhile backporting the bug fix, it was found to be incompatible with\nearlier versions of Python \u003c 3.6 due to a difference in internal\nimplementation [1].\n\nThis reduces the mocking in the unit test to be more agnostic to the\ninternals of the StreamRequestHandler (ancestor of\nSimpleHTTPRequestHandler) and work across Python versions \u003e\u003d 2.7.\n\nRelated-Bug: #1927677\n\n[1] https://github.com/python/cpython/commit/34eeed42901666fce099947f93dfdfc05411f286\n\nChange-Id: I546d376869a992601b443fb95acf1034da2a8f36\n(cherry picked from commit 214cabe6848a1fdb4f5941d994c6cc11107fc4af)\n(cherry picked from commit 9c2f29783734cb5f9cb05a08d328c10e1d16c4f1)\n(cherry picked from commit 94e265f3ca615aa18de0081a76975019997b8709)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d43b88a33407b1253e7bce70f720a44f7688141f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d43b88a33407b1253e7bce70f720a44f7688141f"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}