)]}'
{"id":"openstack%2Fnova~803787","triplet_id":"openstack%2Fnova~master~Ica30dd0250b8996ff6762712d5dfdc98c35a45d9","project":"openstack/nova","branch":"master","topic":"mypy-integration","hashtags":[],"change_id":"Ica30dd0250b8996ff6762712d5dfdc98c35a45d9","subject":"mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67","status":"ABANDONED","created":"2021-08-06 16:39:23.000000000","updated":"2022-03-22 14:20:46.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e63a1fcdaeff4bc0861a5227b7c42025aee1730c","_number":803787,"virtual_id_number":803787,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-08-06 18:21:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-06 17:06:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-06 17:11:55.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-06 18:21:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-06 21:37:10.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-08-07 04:26:29.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"c00345539a5419ed5528ea895a6a7117d7b82ee8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-08-06 16:39:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a8262eb5ee51cc05ea68a93cb22ff1e48f01e6a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-06 17:06:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/a5e1ed7c9f1a41f6b7c99302899b7061 : SUCCESS in 23m 52s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/be24c813520c497e8edbbddbf066e83f : SUCCESS in 21m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1cacd5d0644426879565a7532fb22362a8081dd3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-06 17:11:55.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 tempest-dsvm-full-focal-py3 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"c572940bbb5d9d26c24a76da619cb175eed78c21","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-06 18:21:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/e80c830e25ee4a799c67177b1b2a27d0 : SUCCESS in 1h 12m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f170a74d28f54adcb09284792208b604 : SUCCESS in 25m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a1d1b9d33d504102a2429e248553efd6 : FAILURE in 14m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/abac8f6b30fb4d65b22d63950f9bbb1c : SUCCESS in 10m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bb68c418514541149972a58e174b2260 : SUCCESS in 12m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e2ebeacd15b349fe87597b24366669de : SUCCESS in 12m 16s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e8ccc020f12246d981959f77c6ca3504 : SUCCESS in 14m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23362a6aa99441b986a2f13bf5ee539c : SUCCESS in 11m 40s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/20558c54ea1d478984e9389b13c08a52 : SUCCESS in 1h 21m 10s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8e0a9a772ec34ff0b5973ff4481fff5a : SUCCESS in 1h 39m 02s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/35fa3448e57c48528e2cadff016611fc : SUCCESS in 49m 53s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/8096780d23eb4ac581cb10da68c96b1a : SUCCESS in 45m 39s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/088ccb2f2a214244b419e89b3c3a1a9c : SUCCESS in 1h 13m 03s\n- nova-next https://zuul.opendev.org/t/openstack/build/d6e089e7232f4f5e8322aa367487412b : SUCCESS in 1h 18m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/7b53a4582de845bfabd138459e6ccd5e : SUCCESS in 6m 12s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/204dc7a5857e479f8dabbf67c86c3c09 : SUCCESS in 22m 18s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/08273a764fea4b4ab1c2bd7f0cd3f979 : SUCCESS in 26m 03s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/8c94912d8d414d8483ffc66af15393b8 : SUCCESS in 18m 11s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/cb1db6b004f54cdca7ea4d619140d670 : SUCCESS in 1h 18m 21s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/40bcc379134c47018c623a3162c3ce50 : SUCCESS in 52m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0af87dbb112e494aaa445fd6f208a8bf : SUCCESS in 1h 01m 17s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/0554c5fe3e9f41b998843e999ff5c62d : SUCCESS in 26m 50s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/4d192bbd309c4195bf6368c07d07661b : SUCCESS in 38m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"564908dac0eee7d33c9f3a82943a03d5d7831da2","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-06 21:37:10.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/803787/1/iscsi : FAILURE in 2h 06m 34s","accounts_in_message":[],"_revision_number":1},{"id":"7f0e9c327942abb97c6dad4c22cc825dddb14c3d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-08-07 04:26:29.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/87/803787/1/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/87/803787/1/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e63a1fcdaeff4bc0861a5227b7c42025aee1730c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-03-22 14:20:46.000000000","message":"Abandoned\n\nSquashed into the main patch","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cd3ebefa5602dd1f0dc3b27f7bd9b37062add427","revisions":{"cd3ebefa5602dd1f0dc3b27f7bd9b37062add427":{"kind":"REWORK","_number":1,"created":"2021-08-06 16:39:23.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/87/803787/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/803787/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/803787/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/803787/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/803787/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/803787/1"}}},"commit":{"parents":[{"commit":"9b5294afe3960266fb1062832125beb9370497c5","subject":"trivial: Clean manager.Manager, service.Service signatures","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b5294afe3960266fb1062832125beb9370497c5"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-08-06 16:38:29.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-08-06 16:38:29.000000000","tz":60},"subject":"mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67","message":"mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67\n\nAdd some type hints missed in the aforementioned change.\n\nChange-Id: Ica30dd0250b8996ff6762712d5dfdc98c35a45d9\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd3ebefa5602dd1f0dc3b27f7bd9b37062add427"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd3ebefa5602dd1f0dc3b27f7bd9b37062add427"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
