)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f89b0fd3b03725dd9dbd0d6256aef2e88bfd35aa","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: The previous change require develper to install multiple spcific version python "},{"line_number":12,"context_line":"locally to run the test envs and it arbitrally pins lower constratins to the "},{"line_number":13,"context_line":"oldest python we support but lower contratis shoudl work with the newwst python we support too."},{"line_number":14,"context_line":"on fedora or other operating systems that ship with default python version that exceed our supported"},{"line_number":15,"context_line":"versions test can be run with tox -e py38 if required."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"05469b56_ea797130","line":13,"updated":"2021-08-12 09:34:34.000000000","message":"Says who? This certainly won\u0027t be true when newer versions of Python such as 3.9 are added as those are currently failing on Fedora hosts","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f89b0fd3b03725dd9dbd0d6256aef2e88bfd35aa","unresolved":true,"context_lines":[{"line_number":12,"context_line":"locally to run the test envs and it arbitrally pins lower constratins to the "},{"line_number":13,"context_line":"oldest python we support but lower contratis shoudl work with the newwst python we support too."},{"line_number":14,"context_line":"on fedora or other operating systems that ship with default python version that exceed our supported"},{"line_number":15,"context_line":"versions test can be run with tox -e py38 if required."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"similarly our updated constratins shoudl work with the older python."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c483d388_bac2bccb","line":15,"updated":"2021-08-12 09:34:34.000000000","message":"Unit tests and functional tests can be run this way. Anything else that depends on the default basepython cannot. tox doesn\u0027t provide a way to say e.g.\n\n  basepython \u003d \u003e\u003dpython3.6,\u003cpython3.9\n\nSo this seems a reasonable way to do this.\n\nWhat is this breaking for you? The current configuration is broken for users with Fedora 34, which fwict is a significant proportion of active nova developers. I suspect this will break the ability of Ubuntu 20.04 users to run lower-constraints jobs and of CentOS 8 users to run the jobs using the default Python version. The former doesn\u0027t seem like a massive deal, though I imagine the latter could be annoying. If the latter is the big issue, how about doing a partial revert of the top-level basepython change and keeping the one in lower-constraints (which is the real issue I wanted to solve - the other part was just so Fedora users could run \u0027tox -e functional\u0027 again)?\n\nUltimately I want a situation when \u0027tox -e lower-constraints\u0027 doesn\u0027t attempt to use Python 3.9 and fail. Whatever gets us there will wfm.","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc43d05a5fd014756fcf282a4ba1473db2f305f9","unresolved":true,"context_lines":[{"line_number":12,"context_line":"locally to run the test envs and it arbitrally pins lower constratins to the "},{"line_number":13,"context_line":"oldest python we support but lower contratis shoudl work with the newwst python we support too."},{"line_number":14,"context_line":"on fedora or other operating systems that ship with default python version that exceed our supported"},{"line_number":15,"context_line":"versions test can be run with tox -e py38 if required."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"similarly our updated constratins shoudl work with the older python."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e4dfa58b_f7a2f111","line":15,"in_reply_to":"c483d388_bac2bccb","updated":"2021-08-16 11:11:53.000000000","message":"So unit and functional tests targets works with any python version in the supported range if specified explicitly e.g: tox -e py37 So there I don\u0027t think here the original change introduced a big break. I.e. explicit is always better than implicit. (I personally used explicit versions for unit and functional tests always and therefore I did not have any issue with the original change.)\n\nAfter the original patch the lower-constraints target only runs if you have py36 installed. I consider this as breaking change as I could run that before (implicitly using the highest python version installed) without py36. Can we simply resolve this by adding explicit targets like lower-constraint-py38 ?\n\nInterestingly if I revert the lower-constraints part of the original change then for some unknown reason in my debian env where py39 is the default python interpreter tox does not try to use that for the lower-constraints target, but selects py38 instead.","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"21a9d0282620c0bd97266a2aea6d503ffd25444d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"locally to run the test envs and it arbitrally pins lower constratins to the "},{"line_number":13,"context_line":"oldest python we support but lower contratis shoudl work with the newwst python we support too."},{"line_number":14,"context_line":"on fedora or other operating systems that ship with default python version that exceed our supported"},{"line_number":15,"context_line":"versions test can be run with tox -e py38 if required."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"similarly our updated constratins shoudl work with the older python."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9780d499_65435f64","line":15,"in_reply_to":"e4dfa58b_f7a2f111","updated":"2021-08-16 17:12:48.000000000","message":"hm there are other targets that cannot be explicitly called with python version. like at least fast8, pep8, mypy. So the original change breaks thing there too.","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f89b0fd3b03725dd9dbd0d6256aef2e88bfd35aa","unresolved":true,"context_lines":[{"line_number":14,"context_line":"on fedora or other operating systems that ship with default python version that exceed our supported"},{"line_number":15,"context_line":"versions test can be run with tox -e py38 if required."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"similarly our updated constratins shoudl work with the older python."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I358ff8128746c9d0c584a03381e55817c4aace3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9e9e927e_1a2204bc","line":17,"updated":"2021-08-12 09:34:34.000000000","message":"Um, they do?\n\n  tox -e py36","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d378a3ced227b7ba29c000efa8b61b1e993a7a8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c8ebc48_486253b9","updated":"2021-10-20 13:20:05.000000000","message":"I am ok with this, if we get failure in higher python like 3.10 or so then it is good early signal to know and fix.","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"771ff242d2c477de77e496c8948c2793bf973837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34b0518b_51b73ab3","updated":"2021-11-08 12:11:58.000000000","message":"Okay lets do this but I might end up crying again when 3.10 becomes the default on Fedora and tox -e functional starts failing.","commit_id":"1e02c81721ec15737cfd9d5e62831da030cc22ad"}]}