)]}'
{"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"894c0dd609ae101f3f7ece0596682a2664abcd4c","unresolved":true,"context_lines":[{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":37,"context_line":"  - id: attachment_id_required"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"},{"line_number":40,"context_line":"  - device: attachment_device_resp"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f147902_5669bb0b","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":7},"updated":"2021-08-24 08:16:55.000000000","message":"\"Available until version 2.88\" should be described.","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf13d13f7dc13923c84bfe041314e50790451393","unresolved":false,"context_lines":[{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":37,"context_line":"  - id: attachment_id_required"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"},{"line_number":40,"context_line":"  - device: attachment_device_resp"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"303f897a_f0240cb6","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":7},"in_reply_to":"5f147902_5669bb0b","updated":"2021-08-24 08:39:30.000000000","message":"Done","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"894c0dd609ae101f3f7ece0596682a2664abcd4c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  - volumeId: volumeId_resp"},{"line_number":40,"context_line":"  - device: attachment_device_resp"},{"line_number":41,"context_line":"  - tag: device_tag_bdm_attachment_resp"},{"line_number":42,"context_line":"  - delete_on_termination: delete_on_termination_attachments_resp"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"**Example List volume attachments for an instance: JSON response**"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"04ca20a1_82b09a08","line":42,"updated":"2021-08-24 08:16:55.000000000","message":"\"attachment_id\" and \"bdm_uuid\" should be added.","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf13d13f7dc13923c84bfe041314e50790451393","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  - volumeId: volumeId_resp"},{"line_number":40,"context_line":"  - device: attachment_device_resp"},{"line_number":41,"context_line":"  - tag: device_tag_bdm_attachment_resp"},{"line_number":42,"context_line":"  - delete_on_termination: delete_on_termination_attachments_resp"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"**Example List volume attachments for an instance: JSON response**"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"d4128f73_778d5dd9","line":42,"in_reply_to":"04ca20a1_82b09a08","updated":"2021-08-24 08:39:30.000000000","message":"Done","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"894c0dd609ae101f3f7ece0596682a2664abcd4c","unresolved":true,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":157,"context_line":"  - id: attachment_id_required"},{"line_number":158,"context_line":"  - serverId: server_id"},{"line_number":159,"context_line":"  - volumeId: volumeId_resp"},{"line_number":160,"context_line":"  - device: attachment_device_resp"},{"line_number":161,"context_line":"  - tag: device_tag_bdm_attachment_resp"},{"line_number":162,"context_line":"  - delete_on_termination: delete_on_termination_attachments_resp"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"**Example Show a detail of a volume attachment: JSON response**"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"179bc92a_8c8c9c32","line":162,"range":{"start_line":156,"start_character":0,"end_line":162,"end_character":65},"updated":"2021-08-24 08:16:55.000000000","message":"ditto","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf13d13f7dc13923c84bfe041314e50790451393","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":157,"context_line":"  - id: attachment_id_required"},{"line_number":158,"context_line":"  - serverId: server_id"},{"line_number":159,"context_line":"  - volumeId: volumeId_resp"},{"line_number":160,"context_line":"  - device: attachment_device_resp"},{"line_number":161,"context_line":"  - tag: device_tag_bdm_attachment_resp"},{"line_number":162,"context_line":"  - delete_on_termination: delete_on_termination_attachments_resp"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"**Example Show a detail of a volume attachment: JSON response**"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"b19f750a_f23bd391","line":162,"range":{"start_line":156,"start_character":0,"end_line":162,"end_character":65},"in_reply_to":"179bc92a_8c8c9c32","updated":"2021-08-24 08:39:30.000000000","message":"Done","commit_id":"f19dccc17c638b850ab2e432064bf8209ce6981f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f2e8cba762369fa755186586493ca255f7bf65e9","unresolved":true,"context_lines":[{"line_number":156,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":159,"context_line":"  - id: volume_attachment_id_resp"},{"line_number":160,"context_line":"  - serverId: server_id"},{"line_number":161,"context_line":"  - volumeId: volumeId_resp"},{"line_number":162,"context_line":"  - device: attachment_device_resp"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"f6db4fe3_d79854fb","line":159,"updated":"2021-08-24 11:00:06.000000000","message":"is this patch dropping this field? Should we note that in the doc that it is removed in 2.89?","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"619d4a3bcad33ab8b6a1a98b036fb29f2b88e64c","unresolved":false,"context_lines":[{"line_number":156,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":159,"context_line":"  - id: volume_attachment_id_resp"},{"line_number":160,"context_line":"  - serverId: server_id"},{"line_number":161,"context_line":"  - volumeId: volumeId_resp"},{"line_number":162,"context_line":"  - device: attachment_device_resp"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"857fff42_9cd4e076","line":159,"in_reply_to":"c2deddc4_c9d75530","updated":"2021-08-24 12:50:35.000000000","message":"ups. I did not notice that. The generated doc looks good to me.","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e77eb07afab8bb0b7b1d21da155d7616ac944515","unresolved":true,"context_lines":[{"line_number":156,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":159,"context_line":"  - id: volume_attachment_id_resp"},{"line_number":160,"context_line":"  - serverId: server_id"},{"line_number":161,"context_line":"  - volumeId: volumeId_resp"},{"line_number":162,"context_line":"  - device: attachment_device_resp"}],"source_content_type":"text/x-c++src","patch_set":9,"id":"c2deddc4_c9d75530","line":159,"in_reply_to":"f6db4fe3_d79854fb","updated":"2021-08-24 11:09:05.000000000","message":"I tagged the parameter with  ``max_version: 2.88``, that should be enough right?","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f2e8cba762369fa755186586493ca255f7bf65e9","unresolved":true,"context_lines":[{"line_number":7378,"context_line":"  type: object"},{"line_number":7379,"context_line":"volume_attachment_id_resp:"},{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The UUID of the attachment. (This duplicates volumeId)."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e2c911aa_23c77879","line":7381,"updated":"2021-08-24 11:00:06.000000000","message":"What does this really mean. If it duplicates the volumeId then I guess it is the volumeId itself. Then why we need to talk about attachments here?","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"619d4a3bcad33ab8b6a1a98b036fb29f2b88e64c","unresolved":false,"context_lines":[{"line_number":7378,"context_line":"  type: object"},{"line_number":7379,"context_line":"volume_attachment_id_resp:"},{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The UUID of the attachment. (This duplicates volumeId)."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"119a8e14_559792a0","line":7381,"in_reply_to":"55ed1cc5_f23446ce","updated":"2021-08-24 12:50:35.000000000","message":"Ack","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e77eb07afab8bb0b7b1d21da155d7616ac944515","unresolved":true,"context_lines":[{"line_number":7378,"context_line":"  type: object"},{"line_number":7379,"context_line":"volume_attachment_id_resp:"},{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The UUID of the attachment. (This duplicates volumeId)."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"55ed1cc5_f23446ce","line":7381,"in_reply_to":"e2c911aa_23c77879","updated":"2021-08-24 11:09:05.000000000","message":"Yeah that\u0027s fair, I used the legacy term here while also noting the reality that it\u0027s just the volumeId, I can respin this to just state the latter to avoid any confusion.","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"19919e596dfa1033e9a39620c9590c7e25d019a1","unresolved":true,"context_lines":[{"line_number":1780,"context_line":"  description: |"},{"line_number":1781,"context_line":"    The UUID of the block device mapping record in Nova for the attachment."},{"line_number":1782,"context_line":"  in: body"},{"line_number":1783,"context_line":"  required: false"},{"line_number":1784,"context_line":"  type: string"},{"line_number":1785,"context_line":"  min_version: 2.89"},{"line_number":1786,"context_line":"attachment_device_put_req:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f578c0c_46ec8e99","line":1783,"range":{"start_line":1783,"start_character":12,"end_line":1783,"end_character":17},"updated":"2021-08-24 13:02:12.000000000","message":"true","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c0e293af8cd1aa256af5c4deffd13a8347b19df9","unresolved":false,"context_lines":[{"line_number":1780,"context_line":"  description: |"},{"line_number":1781,"context_line":"    The UUID of the block device mapping record in Nova for the attachment."},{"line_number":1782,"context_line":"  in: body"},{"line_number":1783,"context_line":"  required: false"},{"line_number":1784,"context_line":"  type: string"},{"line_number":1785,"context_line":"  min_version: 2.89"},{"line_number":1786,"context_line":"attachment_device_put_req:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0bd3e2c5_04504ab0","line":1783,"range":{"start_line":1783,"start_character":12,"end_line":1783,"end_character":17},"in_reply_to":"5f578c0c_46ec8e99","updated":"2021-08-24 18:05:15.000000000","message":"Done","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"19919e596dfa1033e9a39620c9590c7e25d019a1","unresolved":true,"context_lines":[{"line_number":1826,"context_line":"  description: |"},{"line_number":1827,"context_line":"    The UUID of the associated volume attachment in Cinder."},{"line_number":1828,"context_line":"  in: body"},{"line_number":1829,"context_line":"  required: false"},{"line_number":1830,"context_line":"  type: string"},{"line_number":1831,"context_line":"  min_version: 2.89"},{"line_number":1832,"context_line":"attachment_volumeId_resp:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"340ceeb6_09630e97","line":1829,"range":{"start_line":1829,"start_character":12,"end_line":1829,"end_character":17},"updated":"2021-08-24 13:02:12.000000000","message":"true","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c0e293af8cd1aa256af5c4deffd13a8347b19df9","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"  description: |"},{"line_number":1827,"context_line":"    The UUID of the associated volume attachment in Cinder."},{"line_number":1828,"context_line":"  in: body"},{"line_number":1829,"context_line":"  required: false"},{"line_number":1830,"context_line":"  type: string"},{"line_number":1831,"context_line":"  min_version: 2.89"},{"line_number":1832,"context_line":"attachment_volumeId_resp:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ddd2ea94_5a8bc4eb","line":1829,"range":{"start_line":1829,"start_character":12,"end_line":1829,"end_character":17},"in_reply_to":"340ceeb6_09630e97","updated":"2021-08-24 18:05:15.000000000","message":"Done","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"19919e596dfa1033e9a39620c9590c7e25d019a1","unresolved":true,"context_lines":[{"line_number":7378,"context_line":"  type: object"},{"line_number":7379,"context_line":"volume_attachment_id_resp:"},{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The volumeId of the attachment."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d4176a3e_90bf06d2","line":7381,"range":{"start_line":7381,"start_character":8,"end_line":7381,"end_character":16},"updated":"2021-08-24 13:02:12.000000000","message":"volume ID","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c0e293af8cd1aa256af5c4deffd13a8347b19df9","unresolved":false,"context_lines":[{"line_number":7378,"context_line":"  type: object"},{"line_number":7379,"context_line":"volume_attachment_id_resp:"},{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The volumeId of the attachment."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"de8e7e83_f5396396","line":7381,"range":{"start_line":7381,"start_character":8,"end_line":7381,"end_character":16},"in_reply_to":"d4176a3e_90bf06d2","updated":"2021-08-24 18:05:15.000000000","message":"Done","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"19919e596dfa1033e9a39620c9590c7e25d019a1","unresolved":true,"context_lines":[{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The volumeId of the attachment."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"},{"line_number":7385,"context_line":"  max_version: 2.88"},{"line_number":7386,"context_line":"volume_id:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6d3a5f1b_46366e72","line":7383,"range":{"start_line":7383,"start_character":12,"end_line":7383,"end_character":17},"updated":"2021-08-24 13:02:12.000000000","message":"true","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c0e293af8cd1aa256af5c4deffd13a8347b19df9","unresolved":false,"context_lines":[{"line_number":7380,"context_line":"  description: |"},{"line_number":7381,"context_line":"    The volumeId of the attachment."},{"line_number":7382,"context_line":"  in: body"},{"line_number":7383,"context_line":"  required: false"},{"line_number":7384,"context_line":"  type: string"},{"line_number":7385,"context_line":"  max_version: 2.88"},{"line_number":7386,"context_line":"volume_id:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"66afc43d_6fbd56d0","line":7383,"range":{"start_line":7383,"start_character":12,"end_line":7383,"end_character":17},"in_reply_to":"6d3a5f1b_46366e72","updated":"2021-08-24 18:05:15.000000000","message":"Done","commit_id":"ac21c6674c8444edc5afd25b7d63936182fe3580"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c89b47ef531f15346b6283bf198c5a9dd6926efd","unresolved":true,"context_lines":[{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":".. _microversion 2.89:"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"2.89 (Maximum in Xena)"},{"line_number":1184,"context_line":"----------------------"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"``attachment_id`` is now included in the responses for ``GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6431b2f1_312eff6c","line":1183,"range":{"start_line":1183,"start_character":5,"end_line":1183,"end_character":22},"updated":"2021-08-18 23:25:58.000000000","message":"we still not feature freezed yet or exception. may be we can add Maximum thing later.","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e7cb13e193ca2b33db34018169b6f3ef5f76b36","unresolved":false,"context_lines":[{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":".. _microversion 2.89:"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"2.89 (Maximum in Xena)"},{"line_number":1184,"context_line":"----------------------"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"``attachment_id`` is now included in the responses for ``GET"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1b0044d1_f1dfd1a7","line":1183,"range":{"start_line":1183,"start_character":5,"end_line":1183,"end_character":22},"in_reply_to":"6431b2f1_312eff6c","updated":"2021-08-19 09:16:34.000000000","message":"It\u0027s easier to move this along with each change IMHO.","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89e8989486ad069edfc42347d26d745acdb41e0","unresolved":true,"context_lines":[{"line_number":1183,"context_line":"2.89 (Maximum in Xena)"},{"line_number":1184,"context_line":"----------------------"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"``attachment_id`` is now included in the responses for ``GET"},{"line_number":1187,"context_line":"/servers/{server_id}/os-volume_attachments`` and ``GET"},{"line_number":1188,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``."},{"line_number":1189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"8a358134_b477c19e","line":1186,"range":{"start_line":1186,"start_character":0,"end_line":1186,"end_character":33},"updated":"2021-08-20 22:44:06.000000000","message":"``attachment_id``, ``bdm_uuid`` are now included and ``id`` is removed from the..","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cb7388d736b2fd82d82235fc06eb67be90de1679","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"2.89 (Maximum in Xena)"},{"line_number":1184,"context_line":"----------------------"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"``attachment_id`` is now included in the responses for ``GET"},{"line_number":1187,"context_line":"/servers/{server_id}/os-volume_attachments`` and ``GET"},{"line_number":1188,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``."},{"line_number":1189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"8a974c39_93edc5c4","line":1186,"range":{"start_line":1186,"start_character":0,"end_line":1186,"end_character":33},"in_reply_to":"8a358134_b477c19e","updated":"2021-08-23 12:54:19.000000000","message":"Done","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f2e8cba762369fa755186586493ca255f7bf65e9","unresolved":true,"context_lines":[{"line_number":1186,"context_line":"``attachment_id`` and ``bdm_uuid`` are now included in the responses for ``GET"},{"line_number":1187,"context_line":"/servers/{server_id}/os-volume_attachments`` and ``GET"},{"line_number":1188,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``. Additionally the"},{"line_number":1189,"context_line":"``id`` field is dropped from the response as it duplciates the ``volumeId``"},{"line_number":1190,"context_line":"field and ``bdm_uuid``."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae6ff14_c10d3f56","line":1189,"range":{"start_line":1189,"start_character":48,"end_line":1189,"end_character":58},"updated":"2021-08-24 11:00:06.000000000","message":"nit:duplicates","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e77eb07afab8bb0b7b1d21da155d7616ac944515","unresolved":false,"context_lines":[{"line_number":1186,"context_line":"``attachment_id`` and ``bdm_uuid`` are now included in the responses for ``GET"},{"line_number":1187,"context_line":"/servers/{server_id}/os-volume_attachments`` and ``GET"},{"line_number":1188,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``. Additionally the"},{"line_number":1189,"context_line":"``id`` field is dropped from the response as it duplciates the ``volumeId``"},{"line_number":1190,"context_line":"field and ``bdm_uuid``."}],"source_content_type":"text/x-rst","patch_set":9,"id":"340a0c5f_d4607f27","line":1189,"range":{"start_line":1189,"start_character":48,"end_line":1189,"end_character":58},"in_reply_to":"1ae6ff14_c10d3f56","updated":"2021-08-24 11:09:05.000000000","message":"Done","commit_id":"d2f06c0158c80552dbec50de76349f332bb43e39"}],"nova/api/openstack/compute/volumes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c89b47ef531f15346b6283bf198c5a9dd6926efd","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b3f90fba_926038de","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"updated":"2021-08-18 23:25:58.000000000","message":"this was most confusing also in this API where we just return volume id in \u0027id\u0027 as well as in \u0027volumeId\u0027 field. and this was many times understood as attachment id. As we have the new field \u0027attachment_id\u0027 now can we remove this field now?\n\nor","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f8a187e56e21c7f9453b63809d4443e14390cda5","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f5230259_94f94001","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"67673b9b_e0b7b87f","updated":"2021-08-20 12:44:10.000000000","message":"Thanks, https://review.opendev.org/c/openstack/nova-specs/+/805374","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdd7143bc1b573f621ce933d9ac2294b40266f5a","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"67673b9b_e0b7b87f","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"82f9e120_b3d47e88","updated":"2021-08-19 17:32:59.000000000","message":"+1 on renaming. can you please append the spec also with this change https://review.opendev.org/c/openstack/nova-specs/+/794799","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef74d9fff3b5f7b716405aa461c523495cefdef9","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b58a62ff_b1d4b0bb","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"9fc0bdb1_483ec6be","updated":"2021-08-19 07:38:13.000000000","message":"as we already have a volume_id in the response as volumeId I think we can drop the id field from the response. I don\u0027t think we need to expose the internal BlockDeviceMapping id at all to the end user.","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe40962c7dabd371fe0bc8a7da80cebf2ee2d1f9","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fc0bdb1_483ec6be","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"b3f90fba_926038de","updated":"2021-08-18 23:51:00.000000000","message":"saw similar discussion on this in spec, replied there too https://review.opendev.org/c/openstack/nova-specs/+/794799/2/specs/xena/approved/add-attachmentId-to-responses-of-the-os-volume_attachments-api.rst#73\n\n\u0027id\u0027 field returned volume_id always not the BlockDeviceMapping id https://github.com/openstack/nova/blob/a6690e8a3e6e4b009fb821257170cf1bd06fab7d/nova/api/openstack/compute/volumes.py#L231\n\nI feel we should cleanup the \u0027id\u0027 field in this microversion either remove it or rename it and return BlockDeviceMapping\u0027s id","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3e7cb13e193ca2b33db34018169b6f3ef5f76b36","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"82f9e120_b3d47e88","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"b58a62ff_b1d4b0bb","updated":"2021-08-19 09:16:34.000000000","message":"I don\u0027t think it\u0027s useful to end users but it would be extremely useful to ops or devs when debugging issues so I\u0027ll switch this over to be the bdm id and rename the field.","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f762dcbddb69e8bc7b964193aee5f7bbc7deb938","unresolved":true,"context_lines":[{"line_number":251,"context_line":"def _translate_attachment_summary_view(volume_id, instance_uuid, mountpoint):"},{"line_number":252,"context_line":"    \"\"\"Maps keys for attachment summary view.\"\"\""},{"line_number":253,"context_line":"    d \u003d {}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    # NOTE(justinsb): We use the volume id as the id of the attachment object"},{"line_number":256,"context_line":"    d[\u0027id\u0027] \u003d volume_id"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    d[\u0027volumeId\u0027] \u003d volume_id"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fd634fe9_dc8fe138","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":23},"in_reply_to":"f5230259_94f94001","updated":"2021-08-21 07:15:12.000000000","message":"If you think bdm_uuid is useful then go for it!","commit_id":"8bf112e4bafbd0fca3b53c91d1acae7bfffb8729"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89e8989486ad069edfc42347d26d745acdb41e0","unresolved":true,"context_lines":[{"line_number":73,"context_line":"                \u0027id\u0027: vol[\u0027id\u0027],"},{"line_number":74,"context_line":"                \u0027volumeId\u0027: vol[\u0027id\u0027],"},{"line_number":75,"context_line":"                \u0027serverId\u0027: attachment[0],"},{"line_number":76,"context_line":"                \u0027device\u0027: attachment[1].get(\u0027mountpoint\u0027)"},{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ]"},{"line_number":79,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"18da294d_cfd000cd","line":76,"range":{"start_line":76,"start_character":16,"end_line":76,"end_character":57},"updated":"2021-08-20 22:44:06.000000000","message":"\u0027device\u0027 was added when we have mountpoint otherwise not - L252. we need to add same condition here too","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cb7388d736b2fd82d82235fc06eb67be90de1679","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                \u0027id\u0027: vol[\u0027id\u0027],"},{"line_number":74,"context_line":"                \u0027volumeId\u0027: vol[\u0027id\u0027],"},{"line_number":75,"context_line":"                \u0027serverId\u0027: attachment[0],"},{"line_number":76,"context_line":"                \u0027device\u0027: attachment[1].get(\u0027mountpoint\u0027)"},{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ]"},{"line_number":79,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a5db06dc_01fb028d","line":76,"range":{"start_line":76,"start_character":16,"end_line":76,"end_character":57},"in_reply_to":"18da294d_cfd000cd","updated":"2021-08-23 12:54:19.000000000","message":"Done","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89e8989486ad069edfc42347d26d745acdb41e0","unresolved":true,"context_lines":[{"line_number":311,"context_line":"        show_tag \u003d api_version_request.is_supported(req, \u00272.70\u0027)"},{"line_number":312,"context_line":"        show_delete_on_termination \u003d api_version_request.is_supported("},{"line_number":313,"context_line":"            req, \u00272.79\u0027)"},{"line_number":314,"context_line":"        show_attachment_id \u003d show_bdm_uuid \u003d api_version_request.is_supported("},{"line_number":315,"context_line":"            req, \u00272.89\u0027)"},{"line_number":316,"context_line":"        for bdm in limited_list:"},{"line_number":317,"context_line":"            if bdm.volume_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5950e102_94bc9120","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":42},"updated":"2021-08-20 22:44:06.000000000","message":"nit: we can have only one variable show_attachment_and_bdm_id","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cb7388d736b2fd82d82235fc06eb67be90de1679","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        show_tag \u003d api_version_request.is_supported(req, \u00272.70\u0027)"},{"line_number":312,"context_line":"        show_delete_on_termination \u003d api_version_request.is_supported("},{"line_number":313,"context_line":"            req, \u00272.79\u0027)"},{"line_number":314,"context_line":"        show_attachment_id \u003d show_bdm_uuid \u003d api_version_request.is_supported("},{"line_number":315,"context_line":"            req, \u00272.89\u0027)"},{"line_number":316,"context_line":"        for bdm in limited_list:"},{"line_number":317,"context_line":"            if bdm.volume_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7b1ebc50_6555f2a6","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":42},"in_reply_to":"5950e102_94bc9120","updated":"2021-08-23 12:54:19.000000000","message":"Done","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"}],"nova/tests/unit/api/openstack/compute/test_volumes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89e8989486ad069edfc42347d26d745acdb41e0","unresolved":true,"context_lines":[{"line_number":1566,"context_line":"        req \u003d self._get_req(body\u003d{}, microversion\u003d\u00272.88\u0027)"},{"line_number":1567,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1568,"context_line":"        result \u003d self.attachments.show(req, FAKE_UUID, FAKE_UUID_A)"},{"line_number":1569,"context_line":"        self.assertNotIn(\u0027attachment_id\u0027, result[\u0027volumeAttachment\u0027])"},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"    @mock.patch(\u0027nova.objects.BlockDeviceMappingList.get_by_instance_uuid\u0027)"},{"line_number":1572,"context_line":"    def test_list(self, mock_get_bdms):"}],"source_content_type":"text/x-python","patch_set":6,"id":"450c7a25_bc43b9d4","line":1569,"range":{"start_line":1569,"start_character":68,"end_line":1569,"end_character":69},"updated":"2021-08-20 22:44:06.000000000","message":"let\u0027s check other two fields too:\n\n        self.assertNotIn(\u0027bdm_uuid\u0027, result[\u0027volumeAttachment\u0027])\n        self.assertIn(\u0027id\u0027, result[\u0027volumeAttachment\u0027])","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cb7388d736b2fd82d82235fc06eb67be90de1679","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"        req \u003d self._get_req(body\u003d{}, microversion\u003d\u00272.88\u0027)"},{"line_number":1567,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1568,"context_line":"        result \u003d self.attachments.show(req, FAKE_UUID, FAKE_UUID_A)"},{"line_number":1569,"context_line":"        self.assertNotIn(\u0027attachment_id\u0027, result[\u0027volumeAttachment\u0027])"},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"    @mock.patch(\u0027nova.objects.BlockDeviceMappingList.get_by_instance_uuid\u0027)"},{"line_number":1572,"context_line":"    def test_list(self, mock_get_bdms):"}],"source_content_type":"text/x-python","patch_set":6,"id":"39a602c3_8ece9879","line":1569,"range":{"start_line":1569,"start_character":68,"end_line":1569,"end_character":69},"in_reply_to":"450c7a25_bc43b9d4","updated":"2021-08-23 12:54:19.000000000","message":"Done","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d89e8989486ad069edfc42347d26d745acdb41e0","unresolved":true,"context_lines":[{"line_number":1593,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1594,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        result \u003d self.attachments.index(req, FAKE_UUID)"},{"line_number":1597,"context_line":"        self.assertNotIn(\u0027attachment_id\u0027, result[\u0027volumeAttachments\u0027][0])"},{"line_number":1598,"context_line":"        self.assertNotIn(\u0027bdm_uuid\u0027, result[\u0027volumeAttachments\u0027][0])"},{"line_number":1599,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f8e78ff0_79395a0e","line":1596,"range":{"start_line":1596,"start_character":54,"end_line":1596,"end_character":55},"updated":"2021-08-20 22:44:06.000000000","message":"we can add \u0027id\u0027 presence also explicitly\n\nself.assertIn(\u0027id\u0027, result[\u0027volumeAttachments\u0027][0])","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cb7388d736b2fd82d82235fc06eb67be90de1679","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1594,"context_line":"        req.headers[\u0027content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"        result \u003d self.attachments.index(req, FAKE_UUID)"},{"line_number":1597,"context_line":"        self.assertNotIn(\u0027attachment_id\u0027, result[\u0027volumeAttachments\u0027][0])"},{"line_number":1598,"context_line":"        self.assertNotIn(\u0027bdm_uuid\u0027, result[\u0027volumeAttachments\u0027][0])"},{"line_number":1599,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"b193928d_1387d05c","line":1596,"range":{"start_line":1596,"start_character":54,"end_line":1596,"end_character":55},"in_reply_to":"f8e78ff0_79395a0e","updated":"2021-08-23 12:54:19.000000000","message":"Done","commit_id":"e2878e171958022cdd96299593ac803f6f7eeba8"}]}