)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad86d57813fec8d29263d32b205d86566738e296","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"        \"\"\"Convert BDI to the old format for drivers that need it.\"\"\""},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        if self.use_legacy_block_device_info:"},{"line_number":1946,"context_line":"            ephemerals \u003d driver_block_device.legacy_block_devices("},{"line_number":1947,"context_line":"                driver.block_device_info_get_ephemerals(block_device_info))"},{"line_number":1948,"context_line":"            mapping \u003d driver_block_device.legacy_block_devices("},{"line_number":1949,"context_line":"                driver.block_device_info_get_mapping(block_device_info))"}],"source_content_type":"text/x-python","patch_set":3,"id":"96a79735_515561d6","side":"PARENT","line":1946,"range":{"start_line":1946,"start_character":25,"end_line":1946,"end_character":65},"updated":"2021-08-20 10:34:41.000000000","message":"this had no other callers and has been deleted","commit_id":"ce128798f54d1c0ee7ab09b8189eda93830cd69b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad86d57813fec8d29263d32b205d86566738e296","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        if self.use_legacy_block_device_info:"},{"line_number":1946,"context_line":"            ephemerals \u003d driver_block_device.legacy_block_devices("},{"line_number":1947,"context_line":"                driver.block_device_info_get_ephemerals(block_device_info))"},{"line_number":1948,"context_line":"            mapping \u003d driver_block_device.legacy_block_devices("},{"line_number":1949,"context_line":"                driver.block_device_info_get_mapping(block_device_info))"},{"line_number":1950,"context_line":"            swap \u003d block_device_info[\u0027swap\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"19efcb38_7e8a2748","side":"PARENT","line":1947,"range":{"start_line":1947,"start_character":22,"end_line":1947,"end_character":55},"updated":"2021-08-20 10:34:41.000000000","message":"...but this function has other callers and needs to stay","commit_id":"ce128798f54d1c0ee7ab09b8189eda93830cd69b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad86d57813fec8d29263d32b205d86566738e296","unresolved":true,"context_lines":[{"line_number":1946,"context_line":"            ephemerals \u003d driver_block_device.legacy_block_devices("},{"line_number":1947,"context_line":"                driver.block_device_info_get_ephemerals(block_device_info))"},{"line_number":1948,"context_line":"            mapping \u003d driver_block_device.legacy_block_devices("},{"line_number":1949,"context_line":"                driver.block_device_info_get_mapping(block_device_info))"},{"line_number":1950,"context_line":"            swap \u003d block_device_info[\u0027swap\u0027]"},{"line_number":1951,"context_line":"            if swap:"},{"line_number":1952,"context_line":"                swap \u003d swap.legacy()"}],"source_content_type":"text/x-python","patch_set":3,"id":"774867f1_2dcaa20b","side":"PARENT","line":1949,"range":{"start_line":1949,"start_character":23,"end_line":1949,"end_character":52},"updated":"2021-08-20 10:34:41.000000000","message":"likewise","commit_id":"ce128798f54d1c0ee7ab09b8189eda93830cd69b"}],"nova/virt/block_device.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad86d57813fec8d29263d32b205d86566738e296","unresolved":true,"context_lines":[{"line_number":885,"context_line":""},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"def legacy_block_devices(block_device_mapping):"},{"line_number":888,"context_line":"    bdms \u003d [bdm.legacy() for bdm in block_device_mapping]"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    # Re-enumerate ephemeral devices"},{"line_number":891,"context_line":"    if all(isinstance(bdm, DriverEphemeralBlockDevice)"}],"source_content_type":"text/x-python","patch_set":3,"id":"624c7f60_10d8f382","side":"PARENT","line":888,"range":{"start_line":888,"start_character":16,"end_line":888,"end_character":24},"updated":"2021-08-20 10:34:41.000000000","message":"You haven\u0027t removed this yet, even though I don\u0027t see any remaining callers that we actually want to keep:\n\n  $ ag -Q \u0027.legacy(\u0027                                                                                                                                                                                                                       \n  nova/block_device.py\n  323:            legacy_block_device \u003d BlockDeviceDict(bdm).legacy()\n\n  nova/virt/block_device.py\n  259:        legacy_bdm \u003d super(DriverEphemeralBlockDevice, self).legacy()\n\n  nova/tests/unit/test_block_device.py\n  663:                matchers.IsSubDictOf(new.legacy()))\n  675:                self.assertThat(legacy, matchers.IsSubDictOf(new.legacy()))\n\nInspecting these one by one:\n\n  nova/block_device.py\n  323:            legacy_block_device \u003d BlockDeviceDict(bdm).legacy()\n\nthis is part of the \u0027legacy_mapping\u0027 helper which is similarly unused (outside of unit tests) and can therefore go\n\n  nova/virt/block_device.py\n  259:        legacy_bdm \u003d super(DriverEphemeralBlockDevice, self).legacy()\n\nthis is another implementation of the \u0027legacy()\u0027 helper, of course\n\n  nova/tests/unit/test_block_device.py\n  663:                matchers.IsSubDictOf(new.legacy()))\n  675:                self.assertThat(legacy, matchers.IsSubDictOf(new.legacy()))\n\nand this is a test.\n\nSo I think you can remove all implementations of the \u0027legacy()\u0027 helpers along with the \u0027nove.block_device.legacy_mapping\u0027 function also.","commit_id":"ce128798f54d1c0ee7ab09b8189eda93830cd69b"}]}