)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f3118eb_eedf060c","updated":"2021-11-09 15:11:53.000000000","message":"Moving to a -1. I still think this is way more complicated that necessary. All we really need here is the versioned lower-constraint target. Everything else is superfluous IMO","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b514191097595cdc6eb463fc316deaeb32e3c827","unresolved":true,"context_lines":[{"line_number":342,"context_line":"  bindep test"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"[testenv:lower-constraints]"},{"line_number":345,"context_line":"basepython \u003d python3.6"},{"line_number":346,"context_line":"usedevelop \u003d False"},{"line_number":347,"context_line":"deps \u003d"},{"line_number":348,"context_line":"  -c{toxinidir}/lower-constraints.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"513f9b3d_2600afd9","side":"PARENT","line":345,"range":{"start_line":345,"start_character":0,"end_line":345,"end_character":22},"updated":"2021-08-20 11:24:06.000000000","message":"we could keep this as the default for lower-constratints if we really needed too by the way.\nit would be odd for this to be differente but if we needed too to have it work by default correctly that would be ok.\n\nwe could also default the others to 3.8 as long as we can override that for all tox envs manually","commit_id":"e0cacaa397f8414871f1e2cd589928f9afc27dc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":37,"context_line":"  stestr slowest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"b26a793f_67a246c5","line":39,"updated":"2021-11-09 15:11:53.000000000","message":"This isn\u0027t necessary. The pyNN targets are good enough for this","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e38738a4423ad4754dd9601d14022268f526a443","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":37,"context_line":"  stestr slowest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3ee0e154_8a1bd83f","line":39,"in_reply_to":"02e5bb66_e7d46cd3","updated":"2021-11-09 17:32:08.000000000","message":"Perhaps, but it\u0027s different to what every other OpenStack project is doing and I\u0027d rather not have a billion \"add \u0027unit\u0027 tox environment\" patches show up 😉","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a67786601c1bc95f660aa2cb02bc2e6de182ba7f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":37,"context_line":"  stestr slowest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"b37b6b72_71c2cb20","line":39,"in_reply_to":"3ee0e154_8a1bd83f","updated":"2021-11-09 18:10:09.000000000","message":"ok ill add it to the list to remove and in the default env list ill jsut add py3 which will work the same as unit above. im working on a spec draft currently so ill try and adress this tommorow","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":37,"context_line":"  stestr slowest"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"02e5bb66_e7d46cd3","line":39,"in_reply_to":"b26a793f_67a246c5","updated":"2021-11-09 16:14:53.000000000","message":"they are but this has been a change i have wanted to make since we first added python 3 support.\n\ni think having the alias is more approachable.","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"},{"line_number":43,"context_line":"  Run type checks."},{"line_number":44,"context_line":"envdir \u003d {toxworkdir}/shared"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5269da5c_d17ae50d","line":41,"updated":"2021-11-09 15:11:53.000000000","message":"This isn\u0027t necessary either. There\u0027s no running code here so as long as mypy supports the given Python version (and it always will), we\u0027re good","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:unit{,-py36,-py37,-py38,-py39}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:mypy{,-py36,-py37,-py38,-py39}]"},{"line_number":42,"context_line":"description \u003d"},{"line_number":43,"context_line":"  Run type checks."},{"line_number":44,"context_line":"envdir \u003d {toxworkdir}/shared"}],"source_content_type":"text/x-properties","patch_set":3,"id":"a7a1bba6_71d1706f","line":41,"in_reply_to":"5269da5c_d17ae50d","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"commands \u003d"},{"line_number":46,"context_line":"  bash tools/mypywrap.sh {posargs}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:pep8{,-py36,-py37,-py38,-py39}]"},{"line_number":49,"context_line":"description \u003d"},{"line_number":50,"context_line":"  Run style checks."},{"line_number":51,"context_line":"envdir \u003d {toxworkdir}/shared"}],"source_content_type":"text/x-properties","patch_set":3,"id":"a96a80aa_333d44cf","line":48,"updated":"2021-11-09 15:11:53.000000000","message":"Ditto","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"commands \u003d"},{"line_number":46,"context_line":"  bash tools/mypywrap.sh {posargs}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:pep8{,-py36,-py37,-py38,-py39}]"},{"line_number":49,"context_line":"description \u003d"},{"line_number":50,"context_line":"  Run style checks."},{"line_number":51,"context_line":"envdir \u003d {toxworkdir}/shared"}],"source_content_type":"text/x-properties","patch_set":3,"id":"6b9ac0b7_796ca53d","line":48,"in_reply_to":"a96a80aa_333d44cf","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":68,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[testenv:autopep8{,-py36,-py37,-py38,-py39}]"},{"line_number":71,"context_line":"deps \u003d autopep8"},{"line_number":72,"context_line":"commands \u003d"},{"line_number":73,"context_line":"  autopep8 --exit-code --max-line-length\u003d79 --in-place -r nova doc setup.py"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1e7ad001_01bca7d0","line":70,"updated":"2021-11-09 15:11:53.000000000","message":"Ditto","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  # Check that all included JSON files are valid JSON"},{"line_number":68,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[testenv:autopep8{,-py36,-py37,-py38,-py39}]"},{"line_number":71,"context_line":"deps \u003d autopep8"},{"line_number":72,"context_line":"commands \u003d"},{"line_number":73,"context_line":"  autopep8 --exit-code --max-line-length\u003d79 --in-place -r nova doc setup.py"}],"source_content_type":"text/x-properties","patch_set":3,"id":"a0cb1814_a8bf40d3","line":70,"in_reply_to":"1e7ad001_01bca7d0","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"commands \u003d"},{"line_number":73,"context_line":"  autopep8 --exit-code --max-line-length\u003d79 --in-place -r nova doc setup.py"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[testenv:fast8{,-py36,-py37,-py38,-py39}]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"description \u003d"},{"line_number":78,"context_line":"  Run style checks on the changes made since HEAD~. For a full run including docs, use \u0027pep8\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"c103cafb_8c4e742f","line":75,"updated":"2021-11-09 15:11:53.000000000","message":"Ditto","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"commands \u003d"},{"line_number":73,"context_line":"  autopep8 --exit-code --max-line-length\u003d79 --in-place -r nova doc setup.py"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[testenv:fast8{,-py36,-py37,-py38,-py39}]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"description \u003d"},{"line_number":78,"context_line":"  Run style checks on the changes made since HEAD~. For a full run including docs, use \u0027pep8\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"4dc7274d_a7bdbc2a","line":75,"in_reply_to":"c103cafb_8c4e742f","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":80,"context_line":"commands \u003d"},{"line_number":81,"context_line":"  bash tools/flake8wrap.sh -HEAD"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[testenv:validate-backport{,-py36,-py37,-py38,-py39}]"},{"line_number":84,"context_line":"description \u003d"},{"line_number":85,"context_line":"  Determine whether a backport is ready to be merged by checking whether it has"},{"line_number":86,"context_line":"  already been merged to master or more recent stable branches."}],"source_content_type":"text/x-properties","patch_set":3,"id":"12a18978_7d26108a","line":83,"updated":"2021-11-09 15:11:53.000000000","message":"This is bash script. Definitely doesn\u0027t need versioning.","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"commands \u003d"},{"line_number":81,"context_line":"  bash tools/flake8wrap.sh -HEAD"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[testenv:validate-backport{,-py36,-py37,-py38,-py39}]"},{"line_number":84,"context_line":"description \u003d"},{"line_number":85,"context_line":"  Determine whether a backport is ready to be merged by checking whether it has"},{"line_number":86,"context_line":"  already been merged to master or more recent stable branches."}],"source_content_type":"text/x-properties","patch_set":3,"id":"2d990fae_05c34b0a","line":83,"in_reply_to":"12a18978_7d26108a","updated":"2021-11-09 16:14:53.000000000","message":"Ack ya i ws bing consitent but i can certenly remove the ones that are not needed","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":134,"context_line":"  stestr --test-path\u003d./nova/tests/functional/api_sample_tests run {posargs}"},{"line_number":135,"context_line":"  stestr slowest"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[testenv:genconfig{,-py36,-py37,-py38,-py39}]"},{"line_number":138,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":139,"context_line":"commands \u003d"},{"line_number":140,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"42b727d6_f1cf0cec","line":137,"updated":"2021-11-09 15:11:53.000000000","message":"This isn\u0027t needed either","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  stestr --test-path\u003d./nova/tests/functional/api_sample_tests run {posargs}"},{"line_number":135,"context_line":"  stestr slowest"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[testenv:genconfig{,-py36,-py37,-py38,-py39}]"},{"line_number":138,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":139,"context_line":"commands \u003d"},{"line_number":140,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"c40d371f_52b026ca","line":137,"in_reply_to":"42b727d6_f1cf0cec","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":139,"context_line":"commands \u003d"},{"line_number":140,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"[testenv:genpolicy{,-py36,-py37,-py38,-py39}]"},{"line_number":143,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":144,"context_line":"commands \u003d"},{"line_number":145,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9ec68541_7343fa7d","line":142,"updated":"2021-11-09 15:11:53.000000000","message":"Nor this.","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"commands \u003d"},{"line_number":140,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"[testenv:genpolicy{,-py36,-py37,-py38,-py39}]"},{"line_number":143,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":144,"context_line":"commands \u003d"},{"line_number":145,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ed153423_8856eb75","line":142,"in_reply_to":"9ec68541_7343fa7d","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":149,"context_line":"# section once we rely on coverage 4.3+"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"# https://bitbucket.org/ned/coveragepy/issues/519/"},{"line_number":152,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":153,"context_line":"setenv \u003d"},{"line_number":154,"context_line":"  {[testenv]setenv}"},{"line_number":155,"context_line":"  PYTHON\u003dcoverage run --source nova --parallel-mode"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9f37f3d8_d0cf966b","line":152,"updated":"2021-11-09 15:11:53.000000000","message":"You can\u0027t use the shared directory if this is using something other than the default basepython. This applies to any other targets","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":true,"context_lines":[{"line_number":149,"context_line":"# section once we rely on coverage 4.3+"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"# https://bitbucket.org/ned/coveragepy/issues/519/"},{"line_number":152,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":153,"context_line":"setenv \u003d"},{"line_number":154,"context_line":"  {[testenv]setenv}"},{"line_number":155,"context_line":"  PYTHON\u003dcoverage run --source nova --parallel-mode"}],"source_content_type":"text/x-properties","patch_set":3,"id":"450cc59a_e04bdad7","line":152,"in_reply_to":"9f37f3d8_d0cf966b","updated":"2021-11-09 16:14:53.000000000","message":"ya that is one of the thing i was debating when i did the last repin.\ni was trying to decided if i should remove the shared or add a suffix somehow","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":161,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":162,"context_line":"  coverage report"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[testenv:debug{,-py36,-py37,-py38,-py39}]"},{"line_number":165,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  oslo_debug_helper {posargs}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"25174093_4a4bf905","line":164,"updated":"2021-11-09 15:11:53.000000000","message":"I suspect this needn\u0027t be versioned either. In fact, we could probably just drop this environment since I don\u0027t think anyone uses it (I don\u0027t even know *how* to use it). That\u0027s another change though","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":162,"context_line":"  coverage report"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[testenv:debug{,-py36,-py37,-py38,-py39}]"},{"line_number":165,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  oslo_debug_helper {posargs}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5fa19ee9_984e403e","line":164,"in_reply_to":"25174093_4a4bf905","updated":"2021-11-09 16:14:53.000000000","message":"ack, i can push a followup to dorp it\ni agree on the lack of use for now ill drop the extra envs.","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  oslo_debug_helper {posargs}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"[testenv:venv{,-py36,-py37,-py38,-py39}]"},{"line_number":170,"context_line":"deps \u003d"},{"line_number":171,"context_line":"  {[testenv]deps}"},{"line_number":172,"context_line":"  -r{toxinidir}/doc/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"694ea6f8_a00727d6","line":169,"updated":"2021-11-09 15:11:53.000000000","message":"I\u0027d drop this also. It seems impractical. Just create a venv manually if you need to do weird things like this","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":true,"context_lines":[{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  oslo_debug_helper {posargs}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"[testenv:venv{,-py36,-py37,-py38,-py39}]"},{"line_number":170,"context_line":"deps \u003d"},{"line_number":171,"context_line":"  {[testenv]deps}"},{"line_number":172,"context_line":"  -r{toxinidir}/doc/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"dd961f57_23dd4164","line":169,"in_reply_to":"694ea6f8_a00727d6","updated":"2021-11-09 16:14:53.000000000","message":"i actully use this somewhat often and we use it for adding new release nodes\n\ne.g. tox -e venv reno new ...","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":240,"context_line":"# NOTE(browne): This is required for the integration test job of the bandit"},{"line_number":241,"context_line":"# project. Please do not remove."},{"line_number":242,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":243,"context_line":"commands \u003d bandit -r nova -x tests -n 5 -ll"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"[flake8]"},{"line_number":246,"context_line":"# E125 is deliberately excluded. See"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9fb52d60_1190b26d","line":243,"updated":"2021-11-09 15:11:53.000000000","message":"All of the above don\u0027t really need versioning either. Sphinx is pretty good at keeping up to date on newer Python versions and bandit is only run in the gate.","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":true,"context_lines":[{"line_number":240,"context_line":"# NOTE(browne): This is required for the integration test job of the bandit"},{"line_number":241,"context_line":"# project. Please do not remove."},{"line_number":242,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":243,"context_line":"commands \u003d bandit -r nova -x tests -n 5 -ll"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"[flake8]"},{"line_number":246,"context_line":"# E125 is deliberately excluded. See"}],"source_content_type":"text/x-properties","patch_set":3,"id":"95e75abc_ae925880","line":243,"in_reply_to":"9fb52d60_1190b26d","updated":"2021-11-09 16:14:53.000000000","message":"ok ill remove the docs envs \nwe can always re-add them if we need too in the future","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9d351cda6ce2f8af24f445a99b3036278cc98d","unresolved":true,"context_lines":[{"line_number":335,"context_line":"  bindep test"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"[testenv:lower-constraints{,-py36,-py37,-py38,-py39}]"},{"line_number":338,"context_line":"usedevelop \u003d False"},{"line_number":339,"context_line":"deps \u003d"},{"line_number":340,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":341,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ad0515f2_07cad421","line":338,"updated":"2021-11-09 15:11:53.000000000","message":"This is the only one I actually think we need :-D That and the cleanup of the functional tests, I guess","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"658bb481e4e9b508558ca96c4f07dd55a829bb2a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"  bindep test"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"[testenv:lower-constraints{,-py36,-py37,-py38,-py39}]"},{"line_number":338,"context_line":"usedevelop \u003d False"},{"line_number":339,"context_line":"deps \u003d"},{"line_number":340,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":341,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"067a5964_d269085e","line":338,"in_reply_to":"ad0515f2_07cad421","updated":"2021-11-09 16:14:53.000000000","message":"Ack","commit_id":"1a6987717f58e41720048efc1619508c8478bcd3"}]}