)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7d3a8aa2e2d527a798b1f2f122a45ca01d78b1df","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Well, sort of. We enable them but immediately filter out the ones we\u0027re"},{"line_number":10,"context_line":"actually seeing, the rationale being that we can address these in a"},{"line_number":11,"context_line":"piecemeal fashion without the risk of introducing new issues."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There\u0027s a lot more to be done here. However, the work done in oslo.db"},{"line_number":14,"context_line":"[1] should provide a guide for how to resolve the outstanding issues."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ce03636d_3472d535","line":12,"updated":"2021-08-17 14:28:09.000000000","message":"ok that slightly odd but i get what your trying to do.\nignore the ones we already know about but allow any new ones to surface.\n\nthen we can triage them as the start to appear.\nand hopfully also fix them at some point.","commit_id":"e6bb535b902d93231c6d9caf9f84a208bbb022b6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f73a950339f81d3f3422eb541c70f452b0c1ecd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Well, sort of. We enable them but immediately filter out the ones we\u0027re"},{"line_number":10,"context_line":"actually seeing, the rationale being that we can address these in a"},{"line_number":11,"context_line":"piecemeal fashion without the risk of introducing new issues."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There\u0027s a lot more to be done here. However, the work done in oslo.db"},{"line_number":14,"context_line":"[1] should provide a guide for how to resolve the outstanding issues."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f083a72_81fae7c8","line":12,"in_reply_to":"ce03636d_3472d535","updated":"2021-08-18 15:14:11.000000000","message":"Yes, I think this is easier than trying to attack them test by test. We\u0027ll fix some as we fix others, but this will prevent us adding more classes of exceptions or reintroducing things once resolved","commit_id":"e6bb535b902d93231c6d9caf9f84a208bbb022b6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49befafaed8833aa6aa41c923aa8c94e1716ca93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d52596ce_2416347d","updated":"2021-11-12 07:19:49.000000000","message":"Thanks for the warning filter fix. Now the unit test fails due to \n\nsqlalchemy.exc.RemovedIn20Warning: The Engine.execute() method is considered legacy as of the 1.x series of SQLAlchemy and will be removed in 2.0. All statement execution in SQLAlchemy 2.0 is performed by the Connection.execute() method of Connection, or in the ORM by the Session.execute() method of Session. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)\n\nthreatened as error\n\nhttps://zuul.opendev.org/t/openstack/build/ad0128a2275049779a2dc3928c9509d4/log/job-output.txt#18295","commit_id":"5aa899eb70c8f3a5d9fbd7b592d7ded969ac0fbc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dbb2ddc77ef2d8a8185b6b13c70f0d769a2314d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00bb41c8_5c91aba8","updated":"2021-11-15 12:25:57.000000000","message":"cool, now we have very little warning in the outpu","commit_id":"52bd1e51d675a1eb1226a45e3e952b17bda712a2"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"914d40d6d2e5c0743bd9e70686a6291e06f12f5e","unresolved":true,"context_lines":[{"line_number":793,"context_line":"            module\u003d\u0027nova\u0027,"},{"line_number":794,"context_line":"            category\u003dsqla_exc.SADeprecationWarning)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        # ...but filter everything out until we get around to fixing them"},{"line_number":797,"context_line":"        # TODO(stephenfin): Fix all of these"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        warnings.filterwarnings("}],"source_content_type":"text/x-python","patch_set":4,"id":"6863c2f5_c30c2e0d","line":796,"updated":"2021-08-30 14:35:17.000000000","message":"Hm this patch is actually doubles the test output of the unit test job for me compared to master. So I guess we are leaking some things like:\n\n.tox/py38/lib/python3.8/site-packages/oslo_db/sqlalchemy/engines.py:73: RemovedIn20Warning: The legacy calling style of select() is deprecated and will be removed in SQLAlchemy 2.0.  Please use the new calling style described at select(). (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)\n  connection.scalar(select([1]))","commit_id":"f7edb3d6d876e296d8e7b24b145da7ece5379f41"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"78a8e61a871f809630e2be571c0c940f71b31bdf","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            module\u003d\u0027nova\u0027,"},{"line_number":794,"context_line":"            category\u003dsqla_exc.SADeprecationWarning)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        # ...but filter everything out until we get around to fixing them"},{"line_number":797,"context_line":"        # TODO(stephenfin): Fix all of these"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        warnings.filterwarnings("}],"source_content_type":"text/x-python","patch_set":4,"id":"e673052a_829325b5","line":796,"in_reply_to":"6863c2f5_c30c2e0d","updated":"2021-11-11 19:20:04.000000000","message":"This took me _forever_ to figure out. Finally stumbled upon the solution. See [1]\n\n[1] https://review.opendev.org/c/openstack/nova/+/817641","commit_id":"f7edb3d6d876e296d8e7b24b145da7ece5379f41"}]}
