)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea35f1b97fc2748439d7ac26ec7e335bcf1e6eb8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMWare: Use WithRetrieval to get all results"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In various places, own version of iterating over the results are implemented,"},{"line_number":10,"context_line":"sometimes even faulty."},{"line_number":11,"context_line":"The following functions where only getting up to vmware.maximum_objects objects (100 by default)"},{"line_number":12,"context_line":"vm_util.get_all_cluster_mors, vm_util.get_stats_from_cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe635b77_0d815be0","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":30},"updated":"2021-08-20 09:52:29.000000000","message":"nit: we had implemented our own version...","commit_id":"d31b26e09d469748f2ae2cc1e5f6f57401834adc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea35f1b97fc2748439d7ac26ec7e335bcf1e6eb8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In various places, own version of iterating over the results are implemented,"},{"line_number":10,"context_line":"sometimes even faulty."},{"line_number":11,"context_line":"The following functions where only getting up to vmware.maximum_objects objects (100 by default)"},{"line_number":12,"context_line":"vm_util.get_all_cluster_mors, vm_util.get_stats_from_cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Previously, the results were fetched in batches of up to vmware.maximum_objects items."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0ba5bc33_b6ace2f0","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":29},"updated":"2021-08-20 09:52:29.000000000","message":"nit: were","commit_id":"d31b26e09d469748f2ae2cc1e5f6f57401834adc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea35f1b97fc2748439d7ac26ec7e335bcf1e6eb8","unresolved":true,"context_lines":[{"line_number":18,"context_line":"possible."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Replaced the quadratic algorithm in `ds_util._filter_datastores_matching_storage_policy`"},{"line_number":21,"context_line":"with one of O(n log(n)) runtime"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1940399"},{"line_number":24,"context_line":"Change-Id: I8283c3e76c595cb32527d1b8745933d044e22734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6ea07b1a_fdc2512f","line":21,"updated":"2021-08-20 09:52:29.000000000","message":"If you need to respin, can you rewrap this at \u003c\u003d 72 characters, please?","commit_id":"d31b26e09d469748f2ae2cc1e5f6f57401834adc"}],"nova/virt/vmwareapi/ds_util.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"215be8e6211054181f93b43c679b560105617b82","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        raise exception.DatastoreNotFound()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    datastore_mors \u003d datastore_ret.ManagedObjectReference"},{"line_number":127,"context_line":"    result \u003d session._call_method(vim_util,"},{"line_number":128,"context_line":"                            \"get_properties_for_a_collection_of_objects\","},{"line_number":129,"context_line":"                            \"Datastore\", datastore_mors,"},{"line_number":130,"context_line":"                            [\"summary.type\", \"summary.name\","},{"line_number":131,"context_line":"                             \"summary.capacity\", \"summary.freeSpace\","},{"line_number":132,"context_line":"                             \"summary.accessible\","},{"line_number":133,"context_line":"                             \"summary.maintenanceMode\"])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    best_match \u003d None"},{"line_number":136,"context_line":"    with vutil.WithRetrieval(session.vim, result) as datastores:"}],"source_content_type":"text/x-python","patch_set":1,"id":"56db596a_d5a650bb","line":133,"range":{"start_line":127,"start_character":34,"end_line":133,"end_character":56},"updated":"2021-08-20 16:56:46.000000000","message":"nit - the indentation is weird here given vim_util on the line above.","commit_id":"d31b26e09d469748f2ae2cc1e5f6f57401834adc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"215be8e6211054181f93b43c679b560105617b82","unresolved":true,"context_lines":[{"line_number":448,"context_line":"        ref_to_oc[vim_util.get_moref_value(oc.obj)] \u003d oc"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    hubs \u003d pbm.convert_datastores_to_hubs(factory, ds_mors)"},{"line_number":451,"context_line":"    matching_hubs \u003d pbm.filter_hubs_by_profile(session, hubs,"},{"line_number":452,"context_line":"                                                profile_id)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    # Now we have to map back all the matching ones"},{"line_number":455,"context_line":"    for hub in matching_hubs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff114e87_75045a00","line":452,"range":{"start_line":451,"start_character":0,"end_line":452,"end_character":59},"updated":"2021-08-20 16:56:46.000000000","message":"nit - indentation","commit_id":"d31b26e09d469748f2ae2cc1e5f6f57401834adc"}]}