)]}'
{"HACKING.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"862914bb1a1a9ecfa531a9ac49d60e969230d6bc","unresolved":true,"context_lines":[{"line_number":69,"context_line":"- [N365] Check misuse of assertTrue/assertIsNone."},{"line_number":70,"context_line":"- [N366] The assert_has_calls is a method rather than a variable."},{"line_number":71,"context_line":"- [N367] Disallow aliasing the mock.Mock and similar classes in tests."},{"line_number":72,"context_line":"- [N368] Reject if the mock.Mock class is used as a replacement value instead of and "},{"line_number":73,"context_line":"  instance of a mock.Mock during patching in tests."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Creating Unit Tests"}],"source_content_type":"text/x-rst","patch_set":3,"id":"52be0871_9ff87e19","line":72,"range":{"start_line":72,"start_character":84,"end_line":72,"end_character":85},"updated":"2021-09-01 11:26:08.000000000","message":"nit - whitespace, I\u0027ll respin for you now and +2.","commit_id":"467111b614d03beb6ffb77e79c5e5e5553305329"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c84304c1157b24dcd76cf1771518e9025db60025","unresolved":true,"context_lines":[{"line_number":69,"context_line":"- [N365] Check misuse of assertTrue/assertIsNone."},{"line_number":70,"context_line":"- [N366] The assert_has_calls is a method rather than a variable."},{"line_number":71,"context_line":"- [N367] Disallow aliasing the mock.Mock and similar classes in tests."},{"line_number":72,"context_line":"- [N368] Reject if the mock.Mock class is used as a replacement value instead of and "},{"line_number":73,"context_line":"  instance of a mock.Mock during patching in tests."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Creating Unit Tests"}],"source_content_type":"text/x-rst","patch_set":3,"id":"be6ea0f4_4fb1340d","line":72,"range":{"start_line":72,"start_character":84,"end_line":72,"end_character":85},"in_reply_to":"52be0871_9ff87e19","updated":"2021-09-01 11:30:40.000000000","message":"thanks!","commit_id":"467111b614d03beb6ffb77e79c5e5e5553305329"}],"nova/hacking/checks.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8245f499a1c7bf28ef9cc3362e8c2401ce868335","unresolved":true,"context_lines":[{"line_number":958,"context_line":"    https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/storage/test_rbd.py#L122-L125"},{"line_number":959,"context_line":"    After this code every test that assumes that mock.Mock().shutdown is a new"},{"line_number":960,"context_line":"    auto-generated mock.Mock() object will fail a shutdown is now defined in"},{"line_number":961,"context_line":"    the Mock class level an therefore surviving between test cases."},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"    N367"},{"line_number":964,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"f426eb57_e48986db","line":961,"range":{"start_line":961,"start_character":25,"end_line":961,"end_character":27},"updated":"2021-08-24 20:19:49.000000000","message":"nit - and","commit_id":"d02468ed8024cd7e564039d30e86ba21ab79f0bb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38839601bc981b8be51272f090c957c4d0d41af9","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    https://github.com/openstack/nova/blob/10b1dc84f47a71061340f8e0ae0fe32dca44061a/nova/tests/unit/storage/test_rbd.py#L122-L125"},{"line_number":959,"context_line":"    After this code every test that assumes that mock.Mock().shutdown is a new"},{"line_number":960,"context_line":"    auto-generated mock.Mock() object will fail a shutdown is now defined in"},{"line_number":961,"context_line":"    the Mock class level an therefore surviving between test cases."},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"    N367"},{"line_number":964,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"eed69f4e_74df839d","line":961,"range":{"start_line":961,"start_character":25,"end_line":961,"end_character":27},"in_reply_to":"f426eb57_e48986db","updated":"2021-08-30 13:28:37.000000000","message":"Done","commit_id":"d02468ed8024cd7e564039d30e86ba21ab79f0bb"}]}