)]}'
{"id":"openstack%2Fnova~805668","triplet_id":"openstack%2Fnova~master~Id42ca571b1569886ef47aa350369e9d2068e77bc","project":"openstack/nova","branch":"master","topic":"bug/1936849","hashtags":[],"change_id":"Id42ca571b1569886ef47aa350369e9d2068e77bc","subject":"Add two new hacking rules","status":"MERGED","created":"2021-08-23 17:32:39.000000000","updated":"2021-09-03 05:39:23.000000000","submitted":"2021-09-02 19:03:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"805668-bug/1936849","meta_rev_id":"e45f0bd7a42ad103a4debec4a6bf9bacb0fe8ebe","_number":805668,"virtual_id_number":805668,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-02 19:03:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2021-09-01 15:38:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":2,"date":"2021-09-02 16:51:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2021-09-01 11:27:40.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":1,"date":"2021-09-02 16:51:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-23 17:55:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-23 17:56:27.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-23 22:26:49.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-08-24 01:02:40.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-24 20:19:49.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-08-26 02:54:54.000000000","updated_by":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"reviewer":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"state":"REVIEWER"},{"updated":"2021-08-27 12:01:59.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2021-09-02 16:51:32.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"84fdceff0ce08c034eb86f984b3a0a81038d9498","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-23 17:32:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08fe60b6e7dedaf6a089d12740876015df4fb63e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-23 17:35:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1d51bc61d03ab3bc34a703a14ec8f7d6557f6c9e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-23 17:55:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/87363cdb00bd436fa2fb16e0c088b393 : SUCCESS in 7m 44s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/b04ffdbd065148f19313348b775365f0 : SUCCESS in 7m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4c14f168e3ff424cbddf1b6271cd7e49 : SUCCESS in 15m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ebebc91666544e4cab33bd9de0134cf8 : SUCCESS in 14m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/540cf6aee0dc4097b35d5096e35ceaf7 : SUCCESS in 9m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dac4247f276d462394df1cb84a25933a : SUCCESS in 12m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9a413bc68ea94e0dbf52fba89af68358 : SUCCESS in 13m 17s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/702788da0580486791515f0c2a99c5a0 : SUCCESS in 12m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c92b702494e14e0e9bed8d7ea1a8d6cb : SUCCESS in 10m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b7125352237641228f1094d4dfe3b874 : SUCCESS in 18m 38s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/658263c3b2754533925ab218c11fcf63 : SUCCESS in 6m 43s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/eacde1719a034f6693efa32065bd9e83 : SUCCESS in 18m 36s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ca7ed501fb4a4c199e2c5cb0a86d9a3a : SUCCESS in 17m 08s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/122f7d662ddb4dd6ba0f1650ecdd5c4b : SUCCESS in 17m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"17aeb84b8811976c2836f2cd0f386ef183b2a125","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-08-23 17:56:27.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/68/805668/2/check/EMC_PowerFlex_NOVA/2038334/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"c1625e4b6ae8c7a8768e69ab0a35b575fc537003","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-23 18:07:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7f26258dd09a4054b931b279514b04d1 : SUCCESS in 17m 02s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2448d4e7878346268f5b9864a0dedc86 : SUCCESS in 26m 42s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d8f0d4f8bf8a5d54eb57df89da2e1cd1b72c64c7","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-08-23 18:07:28.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/68/805668/2/check/EMC_PowerFlex_NOVA/87a001d/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":2},{"id":"5d669f3b6bcad896fa1d61ce2e8f219a7a8d0a0b","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-23 22:26:49.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805668/2/iscsi : FAILURE in 4h 25m 00s","accounts_in_message":[],"_revision_number":2},{"id":"06a466c6540276d6cdf73abca37b57bc5b196006","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-08-24 01:02:40.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/805668/805668/2/check-not-vote/ext-nova-zuul/7b553f2 : SUCCESS in 1h 02m 57s","accounts_in_message":[],"_revision_number":2},{"id":"8245f499a1c7bf28ef9cc3362e8c2401ce868335","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-08-24 20:19:49.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nExcellent, thanks for following up with this and catching additional examples in the codebase!","accounts_in_message":[],"_revision_number":2},{"id":"5f9b74ce0ee85eedf6add4ac3f18f6b8905e4379","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-25 15:27:25.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review+2\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Excellent, thanks for following up with this and catching additional examples in the codebase!\n\nboth of the two fixed mistake was originally introduce by me so adding a hacking rule was to restore my karma points :D","accounts_in_message":[],"_revision_number":2},{"id":"69a224a3c05c715e856f42bf908361c02fad58be","author":{"_account_id":32291,"name":"wushiming","email":"wushiming@yovole.com","username":"wushiming"},"date":"2021-08-26 02:54:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"065fb96f297f3e832049974e0799c0e7bfcc65b2","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-08-27 12:01:59.000000000","message":"Patch Set 2: Code-Review-1\n\nHACKING.rst should be updated.\n\nhttps://opendev.org/openstack/nova/src/commit/2a78626a85954997d35f5fe62c50de297e2ca92d/HACKING.rst","accounts_in_message":[],"_revision_number":2},{"id":"90ee3a38f8a4be0cbff4c974154727fb02ddc7ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-30 13:27:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"38839601bc981b8be51272f090c957c4d0d41af9","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-30 13:28:37.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e HACKING.rst should be updated.\n\u003e \n\u003e https://opendev.org/openstack/nova/src/commit/2a78626a85954997d35f5fe62c50de297e2ca92d/HACKING.rst\n\nDone.","accounts_in_message":[],"_revision_number":2},{"id":"f7ddd4f224166458367480ca5306940be5c938dd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 13:58:26.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/e3022222d60f4eafa07e0c85bc2845b3 : SUCCESS in 7m 10s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/79a65cbea5f841448210030688a0590b : SUCCESS in 7m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a67f51d115184032b038c6cfbe1ebb7c : SUCCESS in 19m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ead9bd06b725426e998a57534ab3cf9b : SUCCESS in 17m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/214e8da14d8a473ea5b6c8a564d0b827 : SUCCESS in 9m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/398b87331c2c47fd9711130bc923b126 : SUCCESS in 15m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cded1112b18142c9b945d30f7fdfdc80 : SUCCESS in 14m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8a9d1a139cdb4b4b823221b029df308d : SUCCESS in 21m 46s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/410f91726bf64451855317ef5c7bfc54 : SUCCESS in 9m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2672c9c9b2b84d1d9247c54648ad3529 : SUCCESS in 18m 35s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/6e1cd5fc14f34ab3948db5f0606e6835 : SUCCESS in 5m 51s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/d17f531455c84176ad8dac2bd9a0b46e : SUCCESS in 25m 33s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d71e897f28204f29b57de130f6a939d9 : SUCCESS in 17m 54s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/afb3d9d6ff904fb6a7f5240de814795a : SUCCESS in 19m 43s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5b44a12bdf957f47d2311f6be7ac9eeda96e231b","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-08-30 13:59:04.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/68/805668/3/check/EMC_PowerFlex_NOVA/b8c3722/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":3},{"id":"37a2df3a58e942c98f4d1589ef0f68f3a401c028","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 14:15:52.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/9b4988781ec14c978bf84e8608ccf77b : SUCCESS in 20m 24s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ef659d0cd22341bf84cebbbaa20e53a8 : SUCCESS in 45m 31s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f947f0ab6cddd9f245b8a6c0f69a53f3c6bc0198","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-08-30 14:16:52.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/68/805668/3/check/EMC_PowerFlex_NOVA/afbb029/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":3},{"id":"0e992fb9fb7077684a3f619278dd9b425f6c5129","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-30 15:53:34.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805668/3/iscsi : FAILURE in 2h 19m 02s","accounts_in_message":[],"_revision_number":3},{"id":"008cf64e92f9fb4743d5983ce6b8cd8311649cdb","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-08-31 18:56:12.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/805668/805668/3/check-not-vote/ext-nova-zuul/b1425e5 : SUCCESS in 56m 20s","accounts_in_message":[],"_revision_number":3},{"id":"862914bb1a1a9ecfa531a9ac49d60e969230d6bc","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-09-01 11:26:08.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e7337e21cc7c662288c778fc2469b109c18c9845","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-09-01 11:27:13.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1ee212a5d90b69425f04ceb9ba8d0f6f1ff392c3","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-09-01 11:27:40.000000000","message":"Patch Set 4: Code-Review+2\n\nLGTM now thanks, apologies for missing HACKING.rst before!","accounts_in_message":[],"_revision_number":4},{"id":"c84304c1157b24dcd76cf1771518e9025db60025","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-09-01 11:30:40.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"66e39fa1ba0a9273298b4372301a5cbc7887f83a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-01 11:57:57.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/a28d026ddd1f4669a75d46de079b3f58 : SUCCESS in 6m 57s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/d7de08af75ba47aca943eb892db9262b : SUCCESS in 7m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/71000e10b14449d79cad168af610be3e : SUCCESS in 21m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e95c1539ee4f4c9b805f697340cabc06 : SUCCESS in 18m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0cb67aa271b34cc7b5ac17cd276c8b3d : SUCCESS in 11m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/84f46c5044964b27a5d99ad3f4ff9ee6 : SUCCESS in 16m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e5bfae195f90467d9010b37288ecd3ef : SUCCESS in 17m 42s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/92eef597962945838b8b3ef5b004652f : SUCCESS in 19m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e0620200a6304cd99e09e9eea61dfe7d : SUCCESS in 12m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/05ef7387a3c54736948739893980d2dd : SUCCESS in 19m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/46596540854643c68810afda3d4eac92 : SUCCESS in 8m 57s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/5d960a25249a4c8f94b453ea0515be9b : SUCCESS in 19m 17s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/4e8c52604e2447beb217573fba149109 : SUCCESS in 22m 09s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/af2d136805e5489c91b31f41bea12848 : SUCCESS in 20m 45s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"47e771c509a03d9568cd55fbe847f6e24511fa7e","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-09-01 11:58:50.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/68/805668/4/check/EMC_PowerFlex_NOVA/ae19b33/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":4},{"id":"6ec7a37116fdae78b8bc6f62e478918a4ea7ba04","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-01 12:02:01.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ed4db554c43d4a2ca6e3bd06886b238d : SUCCESS in 25m 56s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/cd3ebab8436a48bba2cad9f55fdd066f : SUCCESS in 28m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"43bb9c7da20fad0c35e00ea38f42df602aea144e","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2021-09-01 12:02:21.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/68/805668/4/check/EMC_PowerFlex_NOVA/3bcb193/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":4},{"id":"0d8dd2fc1697c2856dee9c0362353db5c395fa73","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-09-01 13:48:04.000000000","message":"Patch Set 4:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805668/4/iscsi : SUCCESS in 2h 19m 26s","accounts_in_message":[],"_revision_number":4},{"id":"f287ebca8b3a2dd797f281ab1c447b10cd9f1b3f","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-09-01 15:38:33.000000000","message":"Patch Set 4: Code-Review+1\n\nLGTM. Thanks.","accounts_in_message":[],"_revision_number":4},{"id":"e7e36f05a73a56f8475a013fd3619068eef758a9","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-09-02 16:51:32.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"d7e5227d36ecde895d8eff8b2ff23820feb8a99f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 16:52:11.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"d513f81b3b0c18ee7286c456d9d3a6a296589ff5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:03:22.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-guide https://zuul.opendev.org/t/openstack/build/93c5ef64a93c4e98b1cd9e02f5c45f5b : SUCCESS in 7m 43s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/ec5be932a25f415aa0396d9895779416 : SUCCESS in 9m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/050de2dd189f41258a399c1c644d7cc7 : SUCCESS in 20m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8886002476d44dc2b12403913e15605b : SUCCESS in 10m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/296853a30b304158ba67fcaa072e9701 : SUCCESS in 20m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b4b1740926cc43d3ae76c1da07cfaaf2 : SUCCESS in 16m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8650cb7f0509496b9153cc6ee24ec8ed : SUCCESS in 10m 45s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/837217d99c8f4d8ca9bcd01d6497bcd5 : SUCCESS in 18m 32s\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/4a5baecc845e4f0f9dff5113a6b54b8a : SUCCESS in 23m 54s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7d79f01b09ad4cd98c5b65b8ac9fd183 : SUCCESS in 19m 27s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/9562723c12e143fba3c5312deefebc1d : SUCCESS in 7m 27s","accounts_in_message":[],"_revision_number":4},{"id":"20fbe419fd56d4cfc9f828bb24500504d13b8f30","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:03:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"4c38444ddc937e4065bc0776dd5713dbe67f5aaf","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:06:21.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-guide https://zuul.opendev.org/t/openstack/build/cdcfd25676184acf91071e61c3ad076b : SUCCESS in 1m 20s\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/7a5d4590428e4b8f834058cb309bf72b : SUCCESS in 1m 02s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c419285636f74b5cb90658ec902fa261 : SUCCESS in 1m 09s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/71fdbe7e0afe485c8c2d82f2976c123c : SUCCESS in 1m 25s","accounts_in_message":[],"_revision_number":4},{"id":"e45f0bd7a42ad103a4debec4a6bf9bacb0fe8ebe","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-09-03 05:39:23.000000000","message":"Patch Set 4:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/805668/805668/4/check-not-vote/ext-nova-zuul/0b06061 : SUCCESS in 52m 35s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9f8cc2f03827c10f89ee652bc73790b3c58111d3","revisions":{"501e96896f365764f3bbd21dcb7b56bf5690355a":{"kind":"REWORK","_number":1,"created":"2021-08-23 17:32:39.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/68/805668/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/805668/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/805668/1"}}},"commit":{"parents":[{"commit":"930b7c992156733fbb4f598488605825d62ebc0c","subject":"Avoid modifying the Mock class in test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/930b7c992156733fbb4f598488605825d62ebc0c"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:23:31.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:23:31.000000000","tz":120},"subject":"Add two new hacking rules","message":"Add two new hacking rules\n\nAs the bug and fix If71620e808744736cb4fe3abda76d81a6335311b showed\nit is dangerous to forget instantiating the Mock class before it is\nused in the test as changes on the class directly leaks out from the\ntest. In almost all the cases using Mock class directly is a bug and the\nauthor original intention is to use an instance instead, just forgot\nabout the parents. So this patch adds two new hacking rules:\n\nN367: catches the case when Mock class is aliased in the test:\n    self.mock_mystuff \u003d mock.Mock\n\nN368: catches when mock.patch instructed to use the Mock class as\nreplacement value during patching:\n    mock.patch(\u0027Bar.foo\u0027, new\u003dmock.Mock)\n\nFor N367 the previous patch removed the last hit. For N368 this patch\nremoves the two hits exists.\n\nChange-Id: Id42ca571b1569886ef47aa350369e9d2068e77bc\nRelated-Bug: #1936849\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/501e96896f365764f3bbd21dcb7b56bf5690355a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/501e96896f365764f3bbd21dcb7b56bf5690355a"}]},"branch":"refs/heads/master"},"d02468ed8024cd7e564039d30e86ba21ab79f0bb":{"kind":"REWORK","_number":2,"created":"2021-08-23 17:35:29.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/68/805668/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/805668/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/805668/2"}}},"commit":{"parents":[{"commit":"930b7c992156733fbb4f598488605825d62ebc0c","subject":"Avoid modifying the Mock class in test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/930b7c992156733fbb4f598488605825d62ebc0c"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:23:31.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:34:03.000000000","tz":120},"subject":"Add two new hacking rules","message":"Add two new hacking rules\n\nAs the bug and fix If71620e808744736cb4fe3abda76d81a6335311b showed\nit is dangerous to forget instantiating the Mock class before it is\nused in the test as changes on the class directly leaks out from the\ntest. In almost all the cases using Mock class directly is a bug and the\nauthor original intention is to use an instance instead, just forgot\nabout the parents. So this patch adds two new hacking rules:\n\nN367: catches the case when Mock class is aliased in the test:\n    self.mock_mystuff \u003d mock.Mock\n\nN368: catches when mock.patch instructed to use the Mock class as\nreplacement value during patching:\n    mock.patch(\u0027Bar.foo\u0027, new\u003dmock.Mock)\n\nFor N367 the previous patch removed the last hit. For N368 this patch\nremoves the two hits exists.\n\nChange-Id: Id42ca571b1569886ef47aa350369e9d2068e77bc\nRelated-Bug: #1936849\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d02468ed8024cd7e564039d30e86ba21ab79f0bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d02468ed8024cd7e564039d30e86ba21ab79f0bb"}]},"branch":"refs/heads/master"},"467111b614d03beb6ffb77e79c5e5e5553305329":{"kind":"REWORK","_number":3,"created":"2021-08-30 13:27:45.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/68/805668/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/805668/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/805668/3"}}},"commit":{"parents":[{"commit":"930b7c992156733fbb4f598488605825d62ebc0c","subject":"Avoid modifying the Mock class in test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/930b7c992156733fbb4f598488605825d62ebc0c"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:23:31.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-30 13:26:05.000000000","tz":120},"subject":"Add two new hacking rules","message":"Add two new hacking rules\n\nAs the bug and fix If71620e808744736cb4fe3abda76d81a6335311b showed\nit is dangerous to forget instantiating the Mock class before it is\nused in the test as changes on the class directly leaks out from the\ntest. In almost all the cases using Mock class directly is a bug and the\nauthor original intention is to use an instance instead, just forgot\nabout the parents. So this patch adds two new hacking rules:\n\nN367: catches the case when Mock class is aliased in the test:\n    self.mock_mystuff \u003d mock.Mock\n\nN368: catches when mock.patch instructed to use the Mock class as\nreplacement value during patching:\n    mock.patch(\u0027Bar.foo\u0027, new\u003dmock.Mock)\n\nFor N367 the previous patch removed the last hit. For N368 this patch\nremoves the two hits exists.\n\nChange-Id: Id42ca571b1569886ef47aa350369e9d2068e77bc\nRelated-Bug: #1936849\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/467111b614d03beb6ffb77e79c5e5e5553305329"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/467111b614d03beb6ffb77e79c5e5e5553305329"}]},"branch":"refs/heads/master"},"9f8cc2f03827c10f89ee652bc73790b3c58111d3":{"kind":"REWORK","_number":4,"created":"2021-09-01 11:27:13.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/68/805668/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/805668/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/805668/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/805668/4"}}},"commit":{"parents":[{"commit":"7c1ca501eeeb6aa0067327b4f37d06244987e953","subject":"Merge \"Expose the mdev class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c1ca501eeeb6aa0067327b4f37d06244987e953"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 17:23:31.000000000","tz":120},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-09-01 11:26:52.000000000","tz":60},"subject":"Add two new hacking rules","message":"Add two new hacking rules\n\nAs the bug and fix If71620e808744736cb4fe3abda76d81a6335311b showed\nit is dangerous to forget instantiating the Mock class before it is\nused in the test as changes on the class directly leaks out from the\ntest. In almost all the cases using Mock class directly is a bug and the\nauthor original intention is to use an instance instead, just forgot\nabout the parents. So this patch adds two new hacking rules:\n\nN367: catches the case when Mock class is aliased in the test:\n    self.mock_mystuff \u003d mock.Mock\n\nN368: catches when mock.patch instructed to use the Mock class as\nreplacement value during patching:\n    mock.patch(\u0027Bar.foo\u0027, new\u003dmock.Mock)\n\nFor N367 the previous patch removed the last hit. For N368 this patch\nremoves the two hits exists.\n\nChange-Id: Id42ca571b1569886ef47aa350369e9d2068e77bc\nRelated-Bug: #1936849\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f8cc2f03827c10f89ee652bc73790b3c58111d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f8cc2f03827c10f89ee652bc73790b3c58111d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}