)]}'
{"id":"openstack%2Fnova~805759","triplet_id":"openstack%2Fnova~stable%2Fwallaby~If71620e808744736cb4fe3abda76d81a6335311b","project":"openstack/nova","branch":"stable/wallaby","topic":"bug/1936849","hashtags":[],"change_id":"If71620e808744736cb4fe3abda76d81a6335311b","subject":"Avoid modifying the Mock class in test","status":"MERGED","created":"2021-08-24 06:46:58.000000000","updated":"2021-08-27 21:22:33.000000000","submitted":"2021-08-27 21:20:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"805759-bug/1936849","cherry_pick_of_change":805657,"cherry_pick_of_patch_set":1,"meta_rev_id":"7ee807fdf0e237fcd5f0171ba406c73593a43447","_number":805759,"virtual_id_number":805759,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-27 21:20:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-08-27 15:57:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2021-08-24 20:12:22.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2021-08-27 15:57:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-24 07:19:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-24 07:36:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-24 09:38:37.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-08-24 20:12:22.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-08-27 15:57:45.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"1a863bf8a3ebc5e5cfbcd816dd102b38f09e94dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-24 06:46:58.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"6a8f6e27e4793d9ace48d65afb54cfb38e39545b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-24 06:47:13.000000000","message":"Topic bug/1936849-stable/wallaby removed","accounts_in_message":[],"_revision_number":1},{"id":"4eea433a41dbfe20f96508dadc807ecdfbe5bb54","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-24 06:47:16.000000000","message":"Topic set to bug/1936849","accounts_in_message":[],"_revision_number":1},{"id":"c8dfb7e56fabbdd615400d2541388ade835ecb49","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-24 07:19:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5abd48db29184e3aab5e97eb10426d4e : SUCCESS in 25m 30s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/35221dc047f24bb4a3328946d93bc674 : SUCCESS in 27m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f7b12f9189acf620f2fcdf28612f444d8b41d68a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-24 07:36:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f4a81a68c22b4714a825de1faa34b0a5 : SUCCESS in 17m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d56f8c448b324d598cc5d008f40b85f2 : SUCCESS in 15m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60d5dd25d8fd420482348c30b1d26eb4 : SUCCESS in 10m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d8c708d353c442f3b361105c329b851e : SUCCESS in 14m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4dc085d1b5d041b580451a5cfa587e5f : SUCCESS in 15m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/589f1ca3f4ca4fb1b0121164cc621422 : SUCCESS in 15m 37s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13da57d8f1884d8eb4a054769a69af1f : SUCCESS in 14m 02s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bcfa6c2740f0406a9236a8e9bb759e8a : SUCCESS in 8m 26s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/79189bee687448edb386b91fc0d70dcd : SUCCESS in 19m 31s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/16e81c43152e42fda4061edf70658f1a : SUCCESS in 19m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5d096ba4a508d4681584efa94e7ba17110396e82","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-24 09:38:37.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805759/1/iscsi : SUCCESS in 2h 50m 29s","accounts_in_message":[],"_revision_number":1},{"id":"9cac80097fc414c52eb8474158ab6aa2ed48e424","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-08-24 15:25:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ade1eec362f3282cc5dc44aaf7e616ca2eeaff76","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-24 15:51:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/366cf13c50194a1e9a1e97d22db63b82 : SUCCESS in 18m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3adbdf322641489d8928e86f40b8140e : SUCCESS in 15m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e8a04f28d87a4bdcbdf60d6563aadc53 : SUCCESS in 8m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/796fe542c6b54c9a9e30622a48078333 : SUCCESS in 14m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dff77decb93d4555a2bcdb5c53bc00b6 : SUCCESS in 12m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c0cd69e491a64a10ad06f065c4b60486 : SUCCESS in 13m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/54015cfad1434de898ec84209a7a5252 : SUCCESS in 10m 23s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/7ae4fa32a48143399a53ba926ec0435f : SUCCESS in 7m 06s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3666267aeaeb47488a6b421e2c9fc5ac : SUCCESS in 18m 36s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/39a7fdc0b8224cf9ad895ef507acd778 : SUCCESS in 18m 48s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d352477d0a599010ae744cf5dbdd1222c168ce53","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-24 16:06:49.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ff3fa0b9c22740b2b5bcf6a575715224 : SUCCESS in 25m 10s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/90a17b525b54486988d5d088f4ff5e39 : SUCCESS in 36m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"20e44f797756441be9b9ad0bcf94d93945fd2583","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-24 18:22:24.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805759/2/iscsi : FAILURE in 2h 51m 42s","accounts_in_message":[],"_revision_number":2},{"id":"f1cf5d3e26fe270daef4937ad0ccce5e8af7f17a","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-08-24 20:12:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3b99ed97656be1ba68fd849c603b32889610a53c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-27 15:57:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean cherry pick of a test-only bug fix from master. Also, it is merged on master \u0026 valid for backporting. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"9472623cdb36afe998b32c7c29d83dbb21e86219","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-27 15:58:09.000000000","message":"Topic bug/1936849-stable/wallaby removed","accounts_in_message":[],"_revision_number":2},{"id":"ad71ac0cab116e1888f3111acf72ff93cd6dc082","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-27 15:58:14.000000000","message":"Topic set to bug/1936849","accounts_in_message":[],"_revision_number":2},{"id":"023ac43e9fcd544f1ffca767674d89139fa0f0f2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 15:58:27.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"dfc43e2260c48f15b16ea69846e4e08e0a3b26c1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 21:20:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a44cca74d02b4daa98a8eed5316d4cb9 : SUCCESS in 14m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e9da9f7778bb481395c593b12acaa1df : SUCCESS in 8m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1e3e11b3eea542bf94cd16e649f0b0cc : SUCCESS in 13m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1706a7e6662249ce8bb0e99eab7b9883 : SUCCESS in 13m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/392f6165ba454fdb9f7177c8c6d5d783 : SUCCESS in 11m 52s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/77b6c5b71a604f67b0a9d30d0fae72e8 : SUCCESS in 22m 27s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/ac4dabb46be94e2db735d1a4a86daf38 : SUCCESS in 6m 26s","accounts_in_message":[],"_revision_number":2},{"id":"6774c0e342e6462e5699b52d085e7d9ea0805240","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 21:20:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"7ee807fdf0e237fcd5f0171ba406c73593a43447","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 21:22:33.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ab6359acb214ff6a71606b0f7865f90 : SUCCESS in 1m 03s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c958fab901be97999c0d117faa31ab53e52a3371","revisions":{"58d87ddf67640a3cecbfccbe24011e7f30821ba0":{"kind":"REWORK","_number":1,"created":"2021-08-24 06:46:58.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/59/805759/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/805759/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/805759/1"}}},"commit":{"parents":[{"commit":"088addf2b6f243af98802b09cb769e5dcde67f3b","subject":"Merge \"Fix max cpu topologies with numa affinity\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/088addf2b6f243af98802b09cb769e5dcde67f3b"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 15:13:14.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-24 06:46:58.000000000","tz":0},"subject":"Avoid modifying the Mock class in test","message":"Avoid modifying the Mock class in test\n\nThe rdb unit test defines a shutdown field on the Mock class\nunintentionally. This causes that a later test in the same\nexecutor expecting that mock.Mock().shutdown is a newly auto\ngenerated mock.Mock() but it founds that is an already used\n(called) object. This causes that the later test fails when\nasserting the number of calls on that mock.\n\nThe original intention of the rbd unit test was to catch the\ninstantiation of the Rados object in test so it set Rados \u003d mock.Mock()\nso when the code under test called Rados() it actually called Mock().\nIt worked but it has that huge side effect. Instead of this a proper\nmocking of the constructor can be done in two steps:\n\nrados_inst \u003d mock.Mock()\nRados \u003d mock.Mock(return_value\u003drados_inst)\n\nThis makes sure that every Rados() call will return rados_inst that is a\nmock without causing Mock class level side effect.\n\nChange-Id: If71620e808744736cb4fe3abda76d81a6335311b\nCloses-Bug: #1936849\n(cherry picked from commit 930b7c992156733fbb4f598488605825d62ebc0c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58d87ddf67640a3cecbfccbe24011e7f30821ba0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58d87ddf67640a3cecbfccbe24011e7f30821ba0"}]},"branch":"refs/heads/stable/wallaby"},"c958fab901be97999c0d117faa31ab53e52a3371":{"kind":"NO_CHANGE","_number":2,"created":"2021-08-24 15:25:15.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/59/805759/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/805759/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/805759/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/805759/2"}}},"commit":{"parents":[{"commit":"088addf2b6f243af98802b09cb769e5dcde67f3b","subject":"Merge \"Fix max cpu topologies with numa affinity\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/088addf2b6f243af98802b09cb769e5dcde67f3b"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-08-23 15:13:14.000000000","tz":120},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-08-24 15:25:15.000000000","tz":0},"subject":"Avoid modifying the Mock class in test","message":"Avoid modifying the Mock class in test\n\nThe rdb unit test defines a shutdown field on the Mock class\nunintentionally. This causes that a later test in the same\nexecutor expecting that mock.Mock().shutdown is a newly auto\ngenerated mock.Mock() but it founds that is an already used\n(called) object. This causes that the later test fails when\nasserting the number of calls on that mock.\n\nThe original intention of the rbd unit test was to catch the\ninstantiation of the Rados object in test so it set Rados \u003d mock.Mock()\nso when the code under test called Rados() it actually called Mock().\nIt worked but it has that huge side effect. Instead of this a proper\nmocking of the constructor can be done in two steps:\n\nrados_inst \u003d mock.Mock()\nRados \u003d mock.Mock(return_value\u003drados_inst)\n\nThis makes sure that every Rados() call will return rados_inst that is a\nmock without causing Mock class level side effect.\n\nChange-Id: If71620e808744736cb4fe3abda76d81a6335311b\nCloses-Bug: #1936849\n(cherry picked from commit 930b7c992156733fbb4f598488605825d62ebc0c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c958fab901be97999c0d117faa31ab53e52a3371"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c958fab901be97999c0d117faa31ab53e52a3371"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}