)]}'
{"id":"openstack%2Fnova~805995","triplet_id":"openstack%2Fnova~master~I7e120aeb2c41f36f8e0c1ca6be9f05b2f34429bb","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I7e120aeb2c41f36f8e0c1ca6be9f05b2f34429bb","subject":"nova-api add flavorid value to server\u0027s flavor part","status":"NEW","created":"2021-08-25 13:25:16.000000000","updated":"2021-08-26 11:26:07.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a093654b526b6ef3d221b7e5870df37e251929fe","_number":805995,"virtual_id_number":805995,"owner":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-08-25 15:10:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"recommended":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"all":[{"value":1,"date":"2021-08-25 13:42:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},{"value":-2,"date":"2021-08-25 14:35:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-25 13:54:09.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-25 14:11:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-25 14:35:07.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-08-25 15:10:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-25 16:17:04.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-08-25 21:19:07.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-08-26 00:57:40.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"544e2d50eed48c6ab1d4b8ecc272cb5208ba8486","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"date":"2021-08-25 13:25:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6311ba0bcf54740f44f2857cee4c836db49c7865","author":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"date":"2021-08-25 13:36:52.000000000","message":"Patch Set 1: Code-Review+1\n\nThis request it for fix this issue in Horizon and only expose flavorid via nova-api on server layers https://bugs.launchpad.net/horizon/+bug/1940834","accounts_in_message":[],"_revision_number":1},{"id":"cb99f48dcec0927e6398817769758589ecf541d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"date":"2021-08-25 13:40:48.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"6eb40998319f5991d76703be930fe0b2541d5a15","author":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"date":"2021-08-25 13:42:08.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d86c60a45438a18797d50f4f4e3fe7937a105bc9","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-25 13:54:09.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/b38065da25e748eb9206dcb2f45b89ac : RETRY_LIMIT in 1m 00s","accounts_in_message":[],"_revision_number":2},{"id":"aef40ec5ede1837cf9a2fbaa5af3ac5b86d42027","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-25 14:11:57.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8331df3c6dca445a9a69b320ee6b4079 : FAILURE in 22m 26s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/250109ed7ac24b31880eb9a3a726e0b4 : FAILURE in 25m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8cb14b440d07730f33e49b552c3e898a76d20fa1","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-25 14:35:07.000000000","message":"Patch Set 2: Code-Review-2\n\nHi!\n\nTechnically the flavor blob stored in the instance metadata is a copy of the original flavor that the point of instance creation. This means that the flavor.id might point to a flavor that is already deleted. See the original spec [1] for details and reasoning. I\u0027m not 100% sure what Horizon does with this data but if Horizon just uses it to look up the details of the flavor via that flavor.id then Horizons should stop doing that lookup as that might lead to deleted flavors. Instead Horizon should display the flavor details from the instance.flavor dictionary directly.\n\nI\u0027m -2 on this patch for two reasons:\n1) I don\u0027t think nova needs to be changed to solve this issue\n2) The proposed change is an API change that requires a new API microversion and therefore a nova specification  [2][3]\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html\n[2] https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion\n[3] https://docs.openstack.org/nova/latest/contributor/process.html#how-do-i-get-my-code-merged","accounts_in_message":[],"_revision_number":2},{"id":"c2bde0c9de2211285f8298f9c662c603a022e2ca","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-25 15:10:13.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/da49b42caa8a4f78869cde35585fc8d0 : FAILURE in 1h 02m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a7867e86079947e8bd1f0183a293366d : FAILURE in 16m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2e047e395aee4077a4f748a22983af2f : FAILURE in 16m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/025aa518f7e14ad792d6ed69b799b8d5 : SUCCESS in 14m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f0fac97364e84ea1ae5c034d4ba9fc16 : FAILURE in 23m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4d7531e21c064a8a9e1c756b5d74a91b : FAILURE in 15m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fcf7c872f5c54ff0a069364f11189db6 : FAILURE in 15m 34s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a02a95e52448402a8e070091cdb6094a : SUCCESS in 11m 39s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/a4ef6d2e061d4a938c41afb327af94c1 : SUCCESS in 1h 18m 10s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8194be2fabe54e12b215e41e39a87ba8 : FAILURE in 1h 12m 11s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f0109975d716489999edd5d19f412050 : SUCCESS in 48m 37s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/02e2ea52f310465c84591109c3018595 : SUCCESS in 56m 06s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/931a0360c2e24f2f94792ff71aa27bc0 : FAILURE in 1h 23m 26s\n- nova-next https://zuul.opendev.org/t/openstack/build/8db4491a74bb456297cb35de34bf2bb1 : FAILURE in 1h 26m 27s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/be9d28ef02ee40be97a1856f8f17598b : SUCCESS in 5m 55s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/7eb808b8a155422a94dba65076ab0801 : FAILURE in 21m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d429eb7c096f4f72a4690aa1aa8e6f86 : FAILURE in 17m 45s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/821255faa7114b4f9af06e496d1805fe : FAILURE in 21m 08s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/cf83e3414aa84820b9fb77962f77b3ba : SUCCESS in 1h 21m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9de6b316bf124506af438e8ff2d5f860 : SUCCESS in 50m 22s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3dc1ce9d2ea2474ea52b3bb0b3eee8c7 : FAILURE in 47m 57s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/38dd60b1b1234bf4b44342293ffbb518 : SUCCESS in 31m 17s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/04cd05cc04694379aaf09a7b3702d945 : FAILURE in 38m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"dc0e64743db658251db3a1ab5da707ade163f106","author":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"date":"2021-08-25 15:23:48.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-2\n\u003e \n\u003e Hi!\n\u003e \n\u003e Technically the flavor blob stored in the instance metadata is a copy of the original flavor that the point of instance creation. This means that the flavor.id might point to a flavor that is already deleted. See the original spec [1] for details and reasoning. I\u0027m not 100% sure what Horizon does with this data but if Horizon just uses it to look up the details of the flavor via that flavor.id then Horizons should stop doing that lookup as that might lead to deleted flavors. Instead Horizon should display the flavor details from the instance.flavor dictionary directly.\n\u003e \n\u003e I\u0027m -2 on this patch for two reasons:\n\u003e 1) I don\u0027t think nova needs to be changed to solve this issue\n\u003e 2) The proposed change is an API change that requires a new API microversion and therefore a nova specification  [2][3]\n\u003e \n\u003e [1] https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html\n\u003e [2] https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion\n\u003e [3] https://docs.openstack.org/nova/latest/contributor/process.html#how-do-i-get-my-code-merged\n\nHello Balazs,\ncan you check the description of behaviour in bug https://bugs.launchpad.net/horizon/+bug/1940834? Originally there were flavor.id but now, there are flavor\u0027s details without id and flavor.id is used by horizon. I don\u0027t think so it\u0027s possible to change it on horizon, because nova-api lost unique identifier for flavor. This issue is coming because nova-api has been changed so it brakes it. I\u0027m 100% sure it\u0027s not related to deleted flavor. Horizon needs unique identifier of flavor for resizing at least.","accounts_in_message":[],"_revision_number":2},{"id":"2d00766693e5d0b493b5980df473a396bc2d9081","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-08-25 16:17:04.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/805995/2/iscsi : FAILURE in 2h 30m 05s","accounts_in_message":[],"_revision_number":2},{"id":"cef66fc4231337b4f91bae4ccaa53e1f8953a709","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2021-08-25 21:19:07.000000000","message":"Patch Set 2:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/95/805995/2/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/95/805995/2/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8871d934593ece737bbb83d55f8f5b5a74b85fe6","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-08-26 00:57:40.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/805995/805995/2/check-not-vote/ext-nova-zuul/954bc86 : FAILURE in 55m 48s","accounts_in_message":[],"_revision_number":2},{"id":"a093654b526b6ef3d221b7e5870df37e251929fe","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-08-26 11:26:07.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2: Code-Review-2\n\u003e \u003e \n\u003e \u003e Hi!\n\u003e \u003e \n\u003e \u003e Technically the flavor blob stored in the instance metadata is a copy of the original flavor that the point of instance creation. This means that the flavor.id might point to a flavor that is already deleted. See the original spec [1] for details and reasoning. I\u0027m not 100% sure what Horizon does with this data but if Horizon just uses it to look up the details of the flavor via that flavor.id then Horizons should stop doing that lookup as that might lead to deleted flavors. Instead Horizon should display the flavor details from the instance.flavor dictionary directly.\n\u003e \u003e \n\u003e \u003e I\u0027m -2 on this patch for two reasons:\n\u003e \u003e 1) I don\u0027t think nova needs to be changed to solve this issue\n\u003e \u003e 2) The proposed change is an API change that requires a new API microversion and therefore a nova specification  [2][3]\n\u003e \u003e \n\u003e \u003e [1] https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html\n\u003e \u003e [2] https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion\n\u003e \u003e [3] https://docs.openstack.org/nova/latest/contributor/process.html#how-do-i-get-my-code-merged\n\u003e \n\u003e Hello Balazs,\n\u003e can you check the description of behaviour in bug https://bugs.launchpad.net/horizon/+bug/1940834? Originally there were flavor.id but now, there are flavor\u0027s details without id and flavor.id is used by horizon. I don\u0027t think so it\u0027s possible to change it on horizon, because nova-api lost unique identifier for flavor. This issue is coming because nova-api has been changed so it brakes it. I\u0027m 100% sure it\u0027s not related to deleted flavor. Horizon needs unique identifier of flavor for resizing at least.\n\nHello, \n\nFor resize you need the id of the flavor you are resizing to, not the id of the flavor the instance is currently using. So that flavor id for the resize does not come from the instance.flavor.id. It should come from the list of flavors queried from GET /flavors.\n\nThe stack trace in the bug you are referring to shows that horizon fails in openstack_dashboard/dashboards/project/instances/views.py . This is why I assume that horizon only uses the instance.flavor.id to show the flavor information the instance is currently using. For that reason I still suggest not to use the instance.flavor.id to query the flavor data via GET /flavors/{flavor_id} but instead directly use the fields of the embedded flavor e.g. instance.flavor.ram.\n\nThe flavor.id was never a unique identifier of a flavor. Nova only enforces that at the same time there cannot be two flavors with the same id. But if you delete a flavor using like id 111 then after that you can create a new flavor with totally different values but still with the same id 111. See [1]. So an instance that was booted with the first flavor has the embedded flavor id 111 but that now points to a totally different flavor via GET /flavors/{flavor_id}.\n\nNova allows deleting a flavor any time even if there are instances booted from it. This is why nova embeds a copy of the flavor into the instance data during boot (so the original flavor information is not lost). Due to the above id non-uniqueness reason using the embedded instance.flavor.id is wrong. The original flavor might be deleted an a new one with the same id is created. This is why nova removed the instance.flavor.id from the responses of GET /server/details and GET/servers/{uuid} APIs in microversion 2.47. \n\nNova never removed the support for old API microversions. For some reason, I\u0027m not aware of, Horizon opting in to use the latest nova microversion and therefore horizon sees the removal of the instance.flavor.id. As nova still supports microversions \u003c 2.47 horizon can simply use those older microversion if horizon don\u0027t want to adapt to the changed API. However for the above id non-uniqueness reason I highly suggest to adapt Horizon instead of using the instance.falvor.id via an old microversions.\n\n\n\n[1] https://paste.opendev.org/show/808340/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"46bc1b494a618f4504cc3c3a8c4e5ae28954c764","revisions":{"3649a1c956842f0def2fd634d7f357fa8867e209":{"kind":"REWORK","_number":1,"created":"2021-08-25 13:25:16.000000000","uploader":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"ref":"refs/changes/95/805995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/95/805995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/95/805995/1"}}},"commit":{"parents":[{"commit":"8832db17442557911f7b01e48dc5a2fc26a08c54","subject":"Merge \"Reproduce bug 1941005\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8832db17442557911f7b01e48dc5a2fc26a08c54"}]}],"author":{"name":"lmercl","email":"lubos.mercl@gmail.com","date":"2021-08-25 13:24:01.000000000","tz":120},"committer":{"name":"lmercl","email":"lubos.mercl@gmail.com","date":"2021-08-25 13:24:01.000000000","tz":120},"subject":"nova-api add flavorid value to server\u0027s flavor part","message":"nova-api add flavorid value to server\u0027s flavor part\n\nChange-Id: I7e120aeb2c41f36f8e0c1ca6be9f05b2f34429bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3649a1c956842f0def2fd634d7f357fa8867e209"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3649a1c956842f0def2fd634d7f357fa8867e209"}]},"branch":"refs/heads/master"},"46bc1b494a618f4504cc3c3a8c4e5ae28954c764":{"kind":"REWORK","_number":2,"created":"2021-08-25 13:40:48.000000000","uploader":{"_account_id":33154,"name":"Lubos Mercl","display_name":"Lubos Mercl","email":"lubos.mercl@gmail.com","username":"lmercl"},"ref":"refs/changes/95/805995/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/95/805995/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/805995/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/95/805995/2"}}},"commit":{"parents":[{"commit":"8832db17442557911f7b01e48dc5a2fc26a08c54","subject":"Merge \"Reproduce bug 1941005\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8832db17442557911f7b01e48dc5a2fc26a08c54"}]}],"author":{"name":"lmercl","email":"lubos.mercl@gmail.com","date":"2021-08-25 13:24:01.000000000","tz":120},"committer":{"name":"lmercl","email":"lubos.mercl@gmail.com","date":"2021-08-25 13:28:09.000000000","tz":0},"subject":"nova-api add flavorid value to server\u0027s flavor part","message":"nova-api add flavorid value to server\u0027s flavor part\n\nChange-Id: I7e120aeb2c41f36f8e0c1ca6be9f05b2f34429bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/46bc1b494a618f4504cc3c3a8c4e5ae28954c764"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/46bc1b494a618f4504cc3c3a8c4e5ae28954c764"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
