)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c354a8c0c024c30ddf86f764f438a04ade7583d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35d22046_7fc40ee1","updated":"2021-11-08 13:22:27.000000000","message":"Okay LGTM, I worry about stable conflicts but as this is mostly just additional whitespace git should be able to auto resolve things.","commit_id":"f3d48000b139ec38d92da276a43a8387f76cbc89"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f94c7a1cafdcd6870eec8699a4de2be43d24e4a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce6deda3_e6647818","updated":"2021-11-08 13:19:02.000000000","message":"We agreed on the PTG that this is what we want. (I still like black more but that would kill our git history/blame)","commit_id":"f3d48000b139ec38d92da276a43a8387f76cbc89"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f37506ed0411c71d9ce66de251196048da171b34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c13d8445_9937b6cf","updated":"2021-11-08 13:12:53.000000000","message":"note for reviewers\n\nthe newline after a doc string which is the majority fo this diff is recomeneded by pep257\nhttps://www.python.org/dev/peps/pep-0257/#multi-line-docstrings\n\n\n\"\"\"Insert a blank line after all docstrings (one-line or multi-line) that document a class -- generally speaking, the class\u0027s methods are separated from each other by a single blank line, and the docstring needs to be offset from the first method by a blank line.\"\"\"\n\nautopep8 enforces this when https://www.flake8rules.com/rules/E101.html (Indentation contains mixed spaces and tabs) is enabled \n\nhttps://github.com/hhatto/autopep8/blob/master/README.rst#features\n\"\"\"\nautopep8 also fixes some issues not found by pycodestyle.\n\n    Correct deprecated or non-idiomatic Python code (via lib2to3). Use this for making Python 2.7 code more compatible with Python 3. (This is triggered if W690 is enabled.)\n    Normalize files with mixed line endings.\n    Put a blank line between a class docstring and its first method declaration. (Enabled with E301.)\n    Remove blank lines between a function declaration and its docstring. (Enabled with E303.)\n\"\"\"\n\nwe coudl disabel E301 and possible E303 if we wanted to avoid that but i think we ant to keep E101 on.","commit_id":"f3d48000b139ec38d92da276a43a8387f76cbc89"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c354a8c0c024c30ddf86f764f438a04ade7583d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"916bc26e_ee973597","in_reply_to":"c13d8445_9937b6cf","updated":"2021-11-08 13:22:27.000000000","message":"ACK thanks for detailing this.","commit_id":"f3d48000b139ec38d92da276a43a8387f76cbc89"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"92013c30acc3b88ac9a097e07687d3d8c6ef93de","unresolved":true,"context_lines":[{"line_number":49,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":50,"context_line":"deps \u003d"},{"line_number":51,"context_line":"  {[testenv]deps}"},{"line_number":52,"context_line":"  autopep8"},{"line_number":53,"context_line":"commands \u003d"},{"line_number":54,"context_line":"  {[testenv:mypy]commands}"},{"line_number":55,"context_line":"  # check if autopep8 would alter the formatting but don\u0027t actually change it"}],"source_content_type":"text/x-properties","patch_set":3,"id":"e15200f9_a50f0219","line":52,"updated":"2021-11-08 13:15:14.000000000","message":"Can we add autopep8 to test-requirements.txt instead?","commit_id":"f3d48000b139ec38d92da276a43a8387f76cbc89"}]}