)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9cee596ae1c7a6a13fff279dd34d2d436a5bc970","unresolved":true,"context_lines":[{"line_number":26,"context_line":"to be configurable for console proxies) is not in Train. The difference"},{"line_number":27,"context_line":"in test_websocketproxy.py from the cherry picked change is due to a"},{"line_number":28,"context_line":"difference in internal implementation [1] in Python \u003c 3.6. See change"},{"line_number":29,"context_line":"I546d376869a992601b443fb95acf1034da2a8f36 for reference."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1] https://github.com/python/cpython/commit/34eeed42901666fce099947f93dfdfc05411f286"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"de8deb2f_924ffff7","line":29,"updated":"2021-10-27 15:51:40.000000000","message":"thanks for explaining the conflicts.","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27340,"name":"Jared Miller","email":"jmiller@mirantis.com","username":"grawk"},"change_message_id":"97a8d455e5bca181623788dbbe91857c32e3bfe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d4555c1_453d8ede","updated":"2021-10-26 15:03:59.000000000","message":"Is there anything preventing this from being merged atm?","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"c018a673d38a083554b31f958ed8d4d6c1717139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0399dc6_745a1f08","updated":"2021-10-11 15:04:37.000000000","message":"The backport looks OK to me: merged in ussuri, conflicts noted, the necessary change (due to train has still python 2 support) looks OK + zuul is also happy. LGTM.","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4566826c28dfc5ec07a28b2a7d271e84d98c3509","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11e012c9_4b142d9f","updated":"2021-10-29 01:00:13.000000000","message":"recheck","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"91c8b585c2fcd07be85c870c5d28ae9f3acd12b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bf849e8f_82d0f08e","updated":"2021-10-27 18:34:49.000000000","message":"recheck","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bb468d42da54eb671c993d58d573335bf7797eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"18991edc_8a8503c7","updated":"2021-10-30 17:24:05.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"91d74c8211c9c5359526f4a7bfb52ba8a921644c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4309ea30_25de8cdc","updated":"2021-11-01 05:54:50.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cad3dd7aaa10ddec81f591b37a3a56a55ebe5e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4ba24b2a_13754dc6","updated":"2021-10-30 07:16:37.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b4db41edd8d4d15256c90dacce077136aa4447ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4c638120_84d6c28c","updated":"2021-10-31 02:38:13.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6d1cdb7d2678576a6b1ddb451d24b1e8dfc7c39b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7712a7bc_130af7b1","updated":"2021-10-30 02:52:06.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d3b5b02c92364304450f6da1d0fd87f19c6921ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c8305dd_eafa895a","updated":"2021-11-01 02:15:16.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ce9bd7d38dc8291c4127074113bf98c7d3fa729a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d39c5518_5d268410","updated":"2021-10-31 23:55:53.000000000","message":"recheck ","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a2c17f0ee8b8755a95a02596ff6c3a73c7543d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87fcc90f_dccaa081","updated":"2021-10-29 16:33:34.000000000","message":"recheck - \"Timed out waiting for server evacuate-test to go to ACTIVE status\"","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e089bba25b7a0b0d3ceb08fe18094fd5d6646044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7184e0af_03ace2d8","updated":"2021-10-30 12:03:11.000000000","message":"recheck - test_volume_swap - \n\"Details: volume aecbe85f-2fa1-4ac6-88b0-3f76be470598 failed to reach available status (current in-use) within the required time (196 s).\"","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"77e0d5bb6b00f9e2f35845e53a1e20b7d1581b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97af3b85_8f2414ee","updated":"2021-10-29 05:45:00.000000000","message":"recheck - test_volume_swap - Details: volume 1c1800ec-5b56-49ee-b05b-fb18487b6016 failed to reach available status (current in-use) within the required time (196 s).","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ca94bcb83a0a639a0e7d77eaa3fa23a331b062cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75f5d6b2_7810a30c","updated":"2021-10-29 03:05:54.000000000","message":"recheck bug 1737039","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"871fc97e3d1e868a277e275a796a6ae201a591b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e3e191e8_919afb30","updated":"2021-10-29 20:57:04.000000000","message":"recheck nova.exception.VolumeRebaseFailed: Volume rebase failed: internal error: unable to execute QEMU command \u0027drive-mirror\u0027: Could not open \u0027/dev/sdb\u0027: Permission denied","commit_id":"8906552cfc2525a44251d4cf313ece61e57251eb"}],"nova/tests/unit/console/test_websocketproxy.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b915a4660267c202664f3b1df41a17d01c6dcd13","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            b\u0027\u0027"},{"line_number":669,"context_line":"        ]"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Collect the response data to verify at the end. The"},{"line_number":672,"context_line":"        # SimpleHTTPRequestHandler writes the response data by calling the"},{"line_number":673,"context_line":"        # request socket sendall() method."},{"line_number":674,"context_line":"        self.data \u003d b\u0027\u0027"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        def fake_sendall(data):"},{"line_number":677,"context_line":"            self.data +\u003d data"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        mock_req.sendall.side_effect \u003d fake_sendall"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        client_addr \u003d (\u00278.8.8.8\u0027, 54321)"},{"line_number":682,"context_line":"        mock_server \u003d mock.MagicMock()"},{"line_number":683,"context_line":"        # This specifies that the server will be able to handle requests other"}],"source_content_type":"text/x-python","patch_set":2,"id":"59495dc2_84a3bad0","line":680,"range":{"start_line":671,"start_character":8,"end_line":680,"end_character":0},"updated":"2021-09-27 18:57:30.000000000","message":"Ah right, this has to be removed like in the followup change I546d376869a992601b443fb95acf1034da2a8f36 in order for this to work on python 2.7. It\u0027s anyway better to avoid this mocking of http lib internals but I guess we could only change it here on stable/train and then propose a similar change to only master? :/\n\nOtherwise we have to adjust the test on master and then backport that through xena, wallaby, victoria, ussuri, and then squash it into this patch.","commit_id":"ef4d92fa598ef49f41133d8e0229c85c097d8095"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7c691ad3dd717ea7bf0859db699b92c43ee831e5","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            b\u0027\u0027"},{"line_number":669,"context_line":"        ]"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Collect the response data to verify at the end. The"},{"line_number":672,"context_line":"        # SimpleHTTPRequestHandler writes the response data by calling the"},{"line_number":673,"context_line":"        # request socket sendall() method."},{"line_number":674,"context_line":"        self.data \u003d b\u0027\u0027"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        def fake_sendall(data):"},{"line_number":677,"context_line":"            self.data +\u003d data"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        mock_req.sendall.side_effect \u003d fake_sendall"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        client_addr \u003d (\u00278.8.8.8\u0027, 54321)"},{"line_number":682,"context_line":"        mock_server \u003d mock.MagicMock()"},{"line_number":683,"context_line":"        # This specifies that the server will be able to handle requests other"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4469dee_9f98dae7","line":680,"range":{"start_line":671,"start_character":8,"end_line":680,"end_character":0},"in_reply_to":"31a5e9a3_900a8d43","updated":"2021-09-29 01:57:44.000000000","message":"s/Yoga/Xena/","commit_id":"ef4d92fa598ef49f41133d8e0229c85c097d8095"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"88236d4a9ea7f2bbcd3fa404dcd8fd35ff744b3a","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            b\u0027\u0027"},{"line_number":669,"context_line":"        ]"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Collect the response data to verify at the end. The"},{"line_number":672,"context_line":"        # SimpleHTTPRequestHandler writes the response data by calling the"},{"line_number":673,"context_line":"        # request socket sendall() method."},{"line_number":674,"context_line":"        self.data \u003d b\u0027\u0027"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        def fake_sendall(data):"},{"line_number":677,"context_line":"            self.data +\u003d data"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        mock_req.sendall.side_effect \u003d fake_sendall"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        client_addr \u003d (\u00278.8.8.8\u0027, 54321)"},{"line_number":682,"context_line":"        mock_server \u003d mock.MagicMock()"},{"line_number":683,"context_line":"        # This specifies that the server will be able to handle requests other"}],"source_content_type":"text/x-python","patch_set":2,"id":"95916118_ca7acc46","line":680,"range":{"start_line":671,"start_character":8,"end_line":680,"end_character":0},"in_reply_to":"59495dc2_84a3bad0","updated":"2021-09-27 19:41:00.000000000","message":"yes, I agree. Since this is a test only part \u0026 seems trivial \u0026 fungi is waiting for this patch to be merged: maybe we can make some exception here and directly add the same fix as in I546d376869a992601b443fb95acf1034da2a8f36 here.","commit_id":"ef4d92fa598ef49f41133d8e0229c85c097d8095"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"db9ac1639a3c86a9c48953ccf52ab61786b8dde8","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            b\u0027\u0027"},{"line_number":669,"context_line":"        ]"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Collect the response data to verify at the end. The"},{"line_number":672,"context_line":"        # SimpleHTTPRequestHandler writes the response data by calling the"},{"line_number":673,"context_line":"        # request socket sendall() method."},{"line_number":674,"context_line":"        self.data \u003d b\u0027\u0027"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        def fake_sendall(data):"},{"line_number":677,"context_line":"            self.data +\u003d data"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        mock_req.sendall.side_effect \u003d fake_sendall"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        client_addr \u003d (\u00278.8.8.8\u0027, 54321)"},{"line_number":682,"context_line":"        mock_server \u003d mock.MagicMock()"},{"line_number":683,"context_line":"        # This specifies that the server will be able to handle requests other"}],"source_content_type":"text/x-python","patch_set":2,"id":"31a5e9a3_900a8d43","line":680,"range":{"start_line":671,"start_character":8,"end_line":680,"end_character":0},"in_reply_to":"95916118_ca7acc46","updated":"2021-09-29 01:55:33.000000000","message":"Done, I have done that and added a note in the commit message explaining it. I\u0027ll likely adjust the unit test similarly on the master branch to prevent potential propagation of the mocking internals approach. That will leave a gap of difference between Train \u003d\u003e Yoga but it\u0027s a unit test so maybe we are OK with it ¯\\_(ツ)_/¯","commit_id":"ef4d92fa598ef49f41133d8e0229c85c097d8095"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6d0fd2fa5113a82195f5235f71eecc5af544f695","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            b\u0027\u0027"},{"line_number":669,"context_line":"        ]"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        # Collect the response data to verify at the end. The"},{"line_number":672,"context_line":"        # SimpleHTTPRequestHandler writes the response data by calling the"},{"line_number":673,"context_line":"        # request socket sendall() method."},{"line_number":674,"context_line":"        self.data \u003d b\u0027\u0027"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        def fake_sendall(data):"},{"line_number":677,"context_line":"            self.data +\u003d data"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        mock_req.sendall.side_effect \u003d fake_sendall"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        client_addr \u003d (\u00278.8.8.8\u0027, 54321)"},{"line_number":682,"context_line":"        mock_server \u003d mock.MagicMock()"},{"line_number":683,"context_line":"        # This specifies that the server will be able to handle requests other"}],"source_content_type":"text/x-python","patch_set":2,"id":"8676e5d3_c7e6e25b","line":680,"range":{"start_line":671,"start_character":8,"end_line":680,"end_character":0},"in_reply_to":"e4469dee_9f98dae7","updated":"2021-09-29 01:59:06.000000000","message":"\u003e s/Yoga/Xena/\n\nGah no I was right the first time. I need to log off 😑","commit_id":"ef4d92fa598ef49f41133d8e0229c85c097d8095"}]}