)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9383aa45d97db308fff418d7c117e515e6c14640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"202050c9_a047ae05","updated":"2022-03-10 01:23:49.000000000","message":"https://blueprints.launchpad.net/nova/+spec/remove-migrate-server-redundant-parameter\n\nWe can add a spec in zed release.","commit_id":"e96c518a8e5eb84f5c3ab421c7fad8c194bf374b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bd3a6049d2f656dce32134c00ee1f07cb9c6c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0eef872_ddb830de","updated":"2022-04-05 11:12:59.000000000","message":"Unfortunately you can\u0027t do this without adding a new major version of that RPC API. That\u0027s been done and can be done again, but it\u0027s more involved than this","commit_id":"149c75b35d19a0de3f5984c7870200f9e92004cd"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"24a38f9539e00c5df31ff3d0e65f92c547e0e76d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ed243dd_f1296b79","updated":"2022-03-11 02:24:04.000000000","message":"recheck","commit_id":"149c75b35d19a0de3f5984c7870200f9e92004cd"}],"nova/conductor/manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"339823b96681f5a5b4b71188a1931c8d25da488c","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    @wrap_instance_event(prefix\u003d\u0027conductor\u0027)"},{"line_number":274,"context_line":"    def migrate_server(self, context, instance, scheduler_hint, live, flavor,"},{"line_number":275,"context_line":"                       block_migration, disk_over_commit, clean_shutdown\u003dTrue,"},{"line_number":276,"context_line":"                       request_spec\u003dNone, host_list\u003dNone):"},{"line_number":277,"context_line":"        if instance and not isinstance(instance, nova_object.NovaObject):"},{"line_number":278,"context_line":"            # NOTE(danms): Until v2 of the RPC API, we need to tolerate"},{"line_number":279,"context_line":"            # old-world instance objects here"}],"source_content_type":"text/x-python","patch_set":2,"id":"f853c108_b78a5829","line":276,"updated":"2021-12-20 09:05:43.000000000","message":"unfortunately, you can\u0027t remove some arguments in some RPC API version unless you\u0027re providing a new RPC major version. Here, some old clients could continue to provide a reservations argument so they would have issues.","commit_id":"e96c518a8e5eb84f5c3ab421c7fad8c194bf374b"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"58e51e1dee0920d2ea3344e88c1afc20672a6cf4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    @wrap_instance_event(prefix\u003d\u0027conductor\u0027)"},{"line_number":274,"context_line":"    def migrate_server(self, context, instance, scheduler_hint, live, flavor,"},{"line_number":275,"context_line":"                       block_migration, disk_over_commit, clean_shutdown\u003dTrue,"},{"line_number":276,"context_line":"                       request_spec\u003dNone, host_list\u003dNone):"},{"line_number":277,"context_line":"        if instance and not isinstance(instance, nova_object.NovaObject):"},{"line_number":278,"context_line":"            # NOTE(danms): Until v2 of the RPC API, we need to tolerate"},{"line_number":279,"context_line":"            # old-world instance objects here"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a618d89_50c7999a","line":276,"in_reply_to":"f853c108_b78a5829","updated":"2022-03-10 07:14:41.000000000","message":"Done","commit_id":"e96c518a8e5eb84f5c3ab421c7fad8c194bf374b"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"339823b96681f5a5b4b71188a1931c8d25da488c","unresolved":true,"context_lines":[{"line_number":308,"context_line":"        cctxt.cast(context, \u0027live_migrate_instance\u0027, **kw)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # TODO(melwitt): Remove the reservations parameter in version 2.0 of the"},{"line_number":311,"context_line":"    # RPC API."},{"line_number":312,"context_line":"    # TODO(mriedem): Make request_spec required *and* a RequestSpec object"},{"line_number":313,"context_line":"    # rather than a legacy dict in version 2.0 of the RPC API."},{"line_number":314,"context_line":"    def migrate_server(self, context, instance, scheduler_hint, live, flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d764eb3a_6a7fadfb","line":311,"updated":"2021-12-20 09:05:43.000000000","message":"see, you need a new major version for this RPC API in order to be able to remove the reservations parameter.","commit_id":"e96c518a8e5eb84f5c3ab421c7fad8c194bf374b"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"58e51e1dee0920d2ea3344e88c1afc20672a6cf4","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        cctxt.cast(context, \u0027live_migrate_instance\u0027, **kw)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # TODO(melwitt): Remove the reservations parameter in version 2.0 of the"},{"line_number":311,"context_line":"    # RPC API."},{"line_number":312,"context_line":"    # TODO(mriedem): Make request_spec required *and* a RequestSpec object"},{"line_number":313,"context_line":"    # rather than a legacy dict in version 2.0 of the RPC API."},{"line_number":314,"context_line":"    def migrate_server(self, context, instance, scheduler_hint, live, flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"51ef3b7d_5e58b570","line":311,"in_reply_to":"d764eb3a_6a7fadfb","updated":"2022-03-10 07:14:41.000000000","message":"Done","commit_id":"e96c518a8e5eb84f5c3ab421c7fad8c194bf374b"}]}
