)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"adba9c25030733bfdbbfae22c636974f1a33dcce","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple mistake was made."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The code called alembic_api.current[1] with an Engine object while that"},{"line_number":14,"context_line":"call expects a Config object instead. This leads to but/1943436."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also the same code expected that this call returns the revision. But"},{"line_number":17,"context_line":"that call just prints the revision to the standard output instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"05136bd9_09d4ad8e","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":55},"updated":"2021-09-13 13:05:04.000000000","message":"nit - bug","commit_id":"a3597530069aa7b55b1d3a033f50e0deebcb9786"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"466999d0f6133ccee540424999465981965353ae","unresolved":true,"context_lines":[{"line_number":20,"context_line":"API which is mostly created for CLI consumption to"},{"line_number":21,"context_line":"MigrationContext.get_current_revision() call that is intended to be used"},{"line_number":22,"context_line":"as a python API instead."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.current"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Sean Mooney \u003csmooney@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f8e6d339_f58a8c0d","line":23,"updated":"2021-09-13 12:28:44.000000000","message":"the change looks good to me the only way i see to test this differently\nwoudl be to hard code the db version as a constant and treat it like the constants we\nhave for the object version but i think the test you have now is better.","commit_id":"a3597530069aa7b55b1d3a033f50e0deebcb9786"}],"nova/tests/unit/db/api/test_migrations.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"466999d0f6133ccee540424999465981965353ae","unresolved":true,"context_lines":[{"line_number":244,"context_line":"    def test_db_version_alembic(self):"},{"line_number":245,"context_line":"        migration.db_sync(database\u003d\u0027api\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        head \u003d alembic_script.ScriptDirectory.from_config("},{"line_number":248,"context_line":"            self.config).get_current_head()"},{"line_number":249,"context_line":"        self.assertEqual(head, migration.db_version(database\u003d\u0027api\u0027))"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3646db63_f0c99d9d","line":248,"range":{"start_line":247,"start_character":8,"end_line":248,"end_character":43},"updated":"2021-09-13 12:28:44.000000000","message":"ack that basically the implementation of migration.db_version\n\ni don\u0027t really see a better way to do this other then calling it sice we cant really know the version ahead of time without making it so we need to update a constant here every time we add a db migration so i think this is fine.","commit_id":"a3597530069aa7b55b1d3a033f50e0deebcb9786"}]}