)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84a457e70bc5cd6ceb6a9ab7141dea99da9342c7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"as first class objects. The new managed disk entity is called"},{"line_number":11,"context_line":"VStorageObject aka First Class Disk (FCD). Adding support for"},{"line_number":12,"context_line":"volumes backed by VStorageObject."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4a5a9d3537dc175508f0a0fd82507c498737d1a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9264ceb5_07602d20","line":13,"updated":"2021-10-13 15:00:48.000000000","message":"you should add\n\nImplements: blueprint vmware-fcd\n\nalso this need to be approved and targetd to yoga.","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"293d3bcf5d9a1073aa3e6627a1e9663b7b4ce9e7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"as first class objects. The new managed disk entity is called"},{"line_number":11,"context_line":"VStorageObject aka First Class Disk (FCD). Adding support for"},{"line_number":12,"context_line":"volumes backed by VStorageObject."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4a5a9d3537dc175508f0a0fd82507c498737d1a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"53873835_33d350f8","line":13,"in_reply_to":"9264ceb5_07602d20","updated":"2021-12-10 09:40:47.000000000","message":"Ack","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84a457e70bc5cd6ceb6a9ab7141dea99da9342c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2e06f6ad_d1e2e8d3","updated":"2021-10-13 15:00:48.000000000","message":"im not a fan of how we pass aound the clinet factory as parmaters to utility free functions.\n\nthe api of these fucntion is very non pythonic and looks like C code to me.\n\nthat said this seams to be consistent with the pattern used in the vmware api modules that you are extending so you are not introducing this pattern just following it.\n\n-1 is basically for paper work over all this looks good but we need to appove the specless blueprint first. the code looks oke but im not that familar with this part of nova and i have only done a quick inital review.\n\ni like the use of ddt to compact the test cases \nthe release note is nice and short but if you can include the version requriement to use this that woudl be nice.\n\nthe only other thing that comes to mind is, are there any docs that cover the different storage backend that can be used with vmware that should be updated.","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cf902a09310e1f88091313577f2bb491fa1c9d7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"98c2634c_70c56d46","updated":"2022-02-03 17:13:52.000000000","message":"Does the current VMWare 3 party CI cover this new code path?\n","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"293d3bcf5d9a1073aa3e6627a1e9663b7b4ce9e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"337ce3c0_d738cb79","updated":"2021-12-10 09:40:47.000000000","message":"Hello Sean, \n\nthe blueprint has been validated.\n\nRegards\n\nAlban","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"0864719bae745915d7a73ca0fa0d2ad71604ff19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eb955224_1f9b5a0b","updated":"2021-11-30 16:32:44.000000000","message":"recheck","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c01bacef819080d07947e54625c9724284c8f241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5fd57eb5_4f6f9048","updated":"2022-02-21 17:00:00.000000000","message":"I\u0027m torn between -1 and +1 but I prefer not holding for something I could be wrong.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"fb6f8e53849b9d2af7561a3ee33c88dcf8f91d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8f39689b_8aedb1b5","updated":"2022-02-16 12:06:34.000000000","message":"recheck","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"781f633e3e7a8cb38a340882aae3d36a2cd8a3b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"94bbfb0d_fdcb95e1","updated":"2022-02-15 10:09:45.000000000","message":"recheck","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5fabc3c564270075bc01e74864ba788be3d6cf68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2dfc10be_3ac570a1","updated":"2022-02-17 06:18:12.000000000","message":"recheck  Kernel panic - not syncing: IO-APIC + timer doesn\u0027t work! ","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"ecd46f47bb4dea5a73625303fcbb27295dfc559b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dd854b43_9cbc3807","updated":"2022-02-17 09:55:54.000000000","message":"run-Cloudbase Nova Hyper-V CI","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"}],"nova/tests/unit/virt/vmwareapi/test_volumeops.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84a457e70bc5cd6ceb6a9ab7141dea99da9342c7","unresolved":true,"context_lines":[{"line_number":439,"context_line":"            detach_fcd.assert_called_once_with("},{"line_number":440,"context_line":"                self._volumeops._session, vm_ref, fcd_id)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @ddt.data("},{"line_number":443,"context_line":"        constants.ADAPTER_TYPE_BUSLOGIC, constants.ADAPTER_TYPE_IDE,"},{"line_number":444,"context_line":"        constants.ADAPTER_TYPE_LSILOGICSAS, constants.ADAPTER_TYPE_PARAVIRTUAL)"},{"line_number":445,"context_line":"    def test_detach_volume_fcd_powered_off_instance(self, adapter_type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b66315b3_a2c34214","line":442,"range":{"start_line":442,"start_character":2,"end_line":442,"end_character":13},"updated":"2021-10-13 15:00:48.000000000","message":"this is a nice use of ddt :)","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"293d3bcf5d9a1073aa3e6627a1e9663b7b4ce9e7","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            detach_fcd.assert_called_once_with("},{"line_number":440,"context_line":"                self._volumeops._session, vm_ref, fcd_id)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @ddt.data("},{"line_number":443,"context_line":"        constants.ADAPTER_TYPE_BUSLOGIC, constants.ADAPTER_TYPE_IDE,"},{"line_number":444,"context_line":"        constants.ADAPTER_TYPE_LSILOGICSAS, constants.ADAPTER_TYPE_PARAVIRTUAL)"},{"line_number":445,"context_line":"    def test_detach_volume_fcd_powered_off_instance(self, adapter_type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f75a19cb_5aa886a4","line":442,"range":{"start_line":442,"start_character":2,"end_line":442,"end_character":13},"in_reply_to":"b66315b3_a2c34214","updated":"2021-12-10 09:40:47.000000000","message":"Ack","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"}],"nova/virt/vmwareapi/constants.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"317c5c26ca47153d3e360eed0c4b699dbc6c2953","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from nova.compute import power_state"},{"line_number":20,"context_line":"from nova.network import model as network_model"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"MIN_VC_VERSION \u003d \u00275.1.0\u0027"},{"line_number":23,"context_line":"NEXT_MIN_VC_VERSION \u003d \u00275.5.0\u0027"},{"line_number":24,"context_line":"# The minimum VC version for Neutron \u0027ovs\u0027 port type support"},{"line_number":25,"context_line":"MIN_VC_OVS_VERSION \u003d \u00275.5.0\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DISK_FORMAT_ISO \u003d \u0027iso\u0027"},{"line_number":28,"context_line":"DISK_FORMAT_VMDK \u003d \u0027vmdk\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"885f7a29_429ee500","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":28},"updated":"2022-02-23 10:36:10.000000000","message":"I\u0027m a bit concerned by those versions here, but I don\u0027t want to hold and we can have a follow-up patch if really needed.\n\nThat said, you already document this, so I\u0027m OK with this change.\n\nCould you please provide a new change for upgrading the versions above if you want to only support 6.5 by next month ? (the Yoga release will only be by March 30th https://releases.openstack.org/yoga/schedule.html#y-final )","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"af98d53f1af5d08564c77b5cd97d371de5079671","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from nova.compute import power_state"},{"line_number":20,"context_line":"from nova.network import model as network_model"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"MIN_VC_VERSION \u003d \u00275.1.0\u0027"},{"line_number":23,"context_line":"NEXT_MIN_VC_VERSION \u003d \u00275.5.0\u0027"},{"line_number":24,"context_line":"# The minimum VC version for Neutron \u0027ovs\u0027 port type support"},{"line_number":25,"context_line":"MIN_VC_OVS_VERSION \u003d \u00275.5.0\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DISK_FORMAT_ISO \u003d \u0027iso\u0027"},{"line_number":28,"context_line":"DISK_FORMAT_VMDK \u003d \u0027vmdk\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"e5489ac5_74b2e5b4","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":28},"in_reply_to":"42f3ea85_97f664e2","updated":"2022-02-23 11:02:24.000000000","message":"Thanks, I trust you then.\n\n+W.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"11a7380088cb96bedf926426c11f17a8c243ed67","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from nova.compute import power_state"},{"line_number":20,"context_line":"from nova.network import model as network_model"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"MIN_VC_VERSION \u003d \u00275.1.0\u0027"},{"line_number":23,"context_line":"NEXT_MIN_VC_VERSION \u003d \u00275.5.0\u0027"},{"line_number":24,"context_line":"# The minimum VC version for Neutron \u0027ovs\u0027 port type support"},{"line_number":25,"context_line":"MIN_VC_OVS_VERSION \u003d \u00275.5.0\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DISK_FORMAT_ISO \u003d \u0027iso\u0027"},{"line_number":28,"context_line":"DISK_FORMAT_VMDK \u003d \u0027vmdk\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"42f3ea85_97f664e2","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":28},"in_reply_to":"885f7a29_429ee500","updated":"2022-02-23 10:43:27.000000000","message":"Thanks. Yes I will update it in a new change once the EOL will come in March.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84a457e70bc5cd6ceb6a9ab7141dea99da9342c7","unresolved":true,"context_lines":[{"line_number":1633,"context_line":"    session._wait_for_task(rename_task)"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"def _create_fcd_id_obj(client_factory, fcd_id):"},{"line_number":1637,"context_line":"    id_obj \u003d client_factory.create(\u0027ns0:ID\u0027)"},{"line_number":1638,"context_line":"    id_obj.id \u003d fcd_id"},{"line_number":1639,"context_line":"    return id_obj"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"def attach_fcd("}],"source_content_type":"text/x-python","patch_set":5,"id":"3aee621c_15126fa5","line":1639,"range":{"start_line":1636,"start_character":0,"end_line":1639,"end_character":17},"updated":"2021-10-13 15:00:48.000000000","message":"nit: this feels like it could be in-lined our you could delegate teh client factory create to this also by passing in the session object but i guess this is ok\n\nit does not really save much code but it looks like it slightly decrease the complexity of the fuc tests as you can mock this funciton here https://review.opendev.org/c/openstack/nova/+/808791/5/nova/tests/unit/virt/vmwareapi/test_vm_util.py#2002","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"293d3bcf5d9a1073aa3e6627a1e9663b7b4ce9e7","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"    session._wait_for_task(rename_task)"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"def _create_fcd_id_obj(client_factory, fcd_id):"},{"line_number":1637,"context_line":"    id_obj \u003d client_factory.create(\u0027ns0:ID\u0027)"},{"line_number":1638,"context_line":"    id_obj.id \u003d fcd_id"},{"line_number":1639,"context_line":"    return id_obj"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"def attach_fcd("}],"source_content_type":"text/x-python","patch_set":5,"id":"08a3169f_0be0db42","line":1639,"range":{"start_line":1636,"start_character":0,"end_line":1639,"end_character":17},"in_reply_to":"3aee621c_15126fa5","updated":"2021-12-10 09:40:47.000000000","message":"Ack","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cf902a09310e1f88091313577f2bb491fa1c9d7a","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"    return id_obj"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"def attach_fcd("},{"line_number":1643,"context_line":"        session, vm_ref, fcd_id, ds_ref_val, controller_key, unit_number):"},{"line_number":1644,"context_line":"    client_factory \u003d session.vim.client.factory"},{"line_number":1645,"context_line":"    disk_id \u003d _create_fcd_id_obj(client_factory, fcd_id)"},{"line_number":1646,"context_line":"    ds_ref \u003d vutil.get_moref(ds_ref_val, \u0027Datastore\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"88cc7c54_13aee070","line":1643,"range":{"start_line":1642,"start_character":0,"end_line":1643,"end_character":74},"updated":"2022-02-03 17:13:52.000000000","message":"nit: I would format this:\n\n    def attach_fcd(\n        session, vm_ref, fcd_id, ds_ref_val, controller_key, unit_number\n    ):","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"0d5bcb3c9476d95e8dbe147c65b9f62e31c0147f","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"    return id_obj"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"def attach_fcd("},{"line_number":1643,"context_line":"        session, vm_ref, fcd_id, ds_ref_val, controller_key, unit_number):"},{"line_number":1644,"context_line":"    client_factory \u003d session.vim.client.factory"},{"line_number":1645,"context_line":"    disk_id \u003d _create_fcd_id_obj(client_factory, fcd_id)"},{"line_number":1646,"context_line":"    ds_ref \u003d vutil.get_moref(ds_ref_val, \u0027Datastore\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"757e9da1_451f58ee","line":1643,"range":{"start_line":1642,"start_character":0,"end_line":1643,"end_character":74},"in_reply_to":"88cc7c54_13aee070","updated":"2022-02-15 09:43:44.000000000","message":"thanks, Will change that","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"}],"releasenotes/notes/add-vmware-fcd-support-822edccb0e38bc37.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84a457e70bc5cd6ceb6a9ab7141dea99da9342c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"969c08af_58983861","line":6,"updated":"2021-10-13 15:00:48.000000000","message":"it would be nice to mention which version of vcenter this is supported for as you do in the commit message","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"0864719bae745915d7a73ca0fa0d2ad71604ff19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c89e62c0_5560d955","line":6,"in_reply_to":"969c08af_58983861","updated":"2021-11-30 16:32:44.000000000","message":"Done","commit_id":"43df47b9cacb620d806f6fa40ab3edc1a7b31e62"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cf902a09310e1f88091313577f2bb491fa1c9d7a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cc39f566_d5213ed9","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"updated":"2022-02-03 17:13:52.000000000","message":"do we need to check for that in the virt driver?","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"781f633e3e7a8cb38a340882aae3d36a2cd8a3b5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a92cf83_e14a573a","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"bdc07fd6_b1aa25d8","updated":"2022-02-15 10:09:45.000000000","message":"Ack","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"0d5bcb3c9476d95e8dbe147c65b9f62e31c0147f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bdc07fd6_b1aa25d8","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"cc39f566_d5213ed9","updated":"2022-02-15 09:43:44.000000000","message":"Not sure if needed as vSphere 6 will be unsupported in less than one month and consumer should not want to use FCD if old versions","commit_id":"cac85252c6d8190dfac3b37491ea164463121d91"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c01bacef819080d07947e54625c9724284c8f241","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f75c8452_42d95c3f","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"updated":"2022-02-21 17:00:00.000000000","message":"I\u0027m maybe wrong but how do you enforce this in the code ? AFAICS, you don\u0027t verify the version and given the minimum VC version is 5.1, I\u0027m wondering if it would be better to provide some exception instead of just saying it loud in the release note.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"358878b8dce3bc21aadc36b9b82b336d9774b01f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9bfcc97e_b67b2a92","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"4fca0457_57aa0921","updated":"2022-02-23 10:02:50.000000000","message":"Mmm, OK, so you enforce it by documentation 😄\n\nThis is one way of doing it 😋","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"b2e62b24a185941c0cd288e5e6923e988a79180c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e71e721b_80ea186d","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"9bfcc97e_b67b2a92","updated":"2022-02-23 10:44:13.000000000","message":"Ack","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"a9fabbd89ddf54cd7c3f317f80e270e31e565b72","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4fca0457_57aa0921","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"ef9c4008_2ff9d405","updated":"2022-02-22 10:59:37.000000000","message":"Yes, the 6.5 and higher versions will be the only maintened and supported version starting next month.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"20ce42fdb2a97a1fc2da0294dc0d9444522419ca","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for VMware VStorageObject based volumes in"},{"line_number":5,"context_line":"    VMware vCenter driver. vSphere version 6.5 is required."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ef9c4008_2ff9d405","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":59},"in_reply_to":"f75c8452_42d95c3f","updated":"2022-02-22 09:23:52.000000000","message":"I had the same question :) https://review.opendev.org/c/openstack/nova/+/808791/6/releasenotes/notes/add-vmware-fcd-support-822edccb0e38bc37.yaml#5 It seems from the answer that it is almost like no older vSphere can exist out there.","commit_id":"d5faf45e9df00528e6e3aa55cd2edd184181a249"}]}