)]}'
{"id":"openstack%2Fnova~809","triplet_id":"openstack%2Fnova~master~Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2","project":"openstack/nova","branch":"master","topic":"bug/851159","hashtags":[],"change_id":"Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2","subject":"Build metadata as needed through callbacks.","status":"ABANDONED","created":"2011-10-07 00:04:11.000000000","updated":"2012-01-24 06:03:59.000000000","total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"19591684c7b3ac3d489006708876b90716c2157a","_number":809,"virtual_id_number":809,"owner":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"date":"2011-10-15 03:47:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"date":"2011-12-12 21:19:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":-1,"date":"2011-10-18 23:54:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":-1,"date":"2011-10-17 15:00:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-10-07 16:01:35.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2011-10-17 15:00:15.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2011-10-18 23:54:31.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-12-12 21:19:43.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"84dc831581793fa36d171bd8a114825524de14db","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2011-10-07 00:19:37.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(3 inline comments)\n\nCheck my inline comments for a couple of small issues.","accounts_in_message":[],"_revision_number":1},{"id":"760a52e326bb1c4f51c201b2fdd021f4eaaa5224","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-07 06:20:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5d177907339a5ebe4baf87fa538bdecc9b09d87b","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-07 06:22:13.000000000","message":"Patch Set 2:\n\nNew patch set fixes issues raised in Johannes Erdfelt\u0027s review, no functional changes.","accounts_in_message":[],"_revision_number":2},{"id":"5d48a7d1a0f37be7e5740b4183b971a8a5a037c6","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2011-10-07 16:01:35.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n(10 inline comments)\n\nI spent a little more time looking at the code. There are some cases where checking if an object is a function, it\u0027s probably better to use callable() instead.\n\nThere are some TODO lines in your patch that are attributed to people who don\u0027t appear to be involved in your branch and I don\u0027t see one of them elsewhere in the code (it\u0027s not a cut and paste it seems). Am I missing something?\n\nIt looks like some code is copied from other parts of nova, but introduce bugs. Can we just use one copy? It has the added benefit of not being buggy.\n\nI\u0027ve added some comments to the code as well.","accounts_in_message":[],"_revision_number":2},{"id":"75413705d53e05798b875331c88d9c4ac48b929e","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-12 05:52:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7fab293ce79baf36d7febba9e50f664c2afe8672","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-12 05:55:54.000000000","message":"Patch Set 3:\n\nI\u0027ve starting using callable(), I didn\u0027t know about that before.\n\nThe TODOs came from cloud controller.  The calls to build image/instance/kernel ids have been fixed to use the right prefix.  We\u0027re severing the dependence on self.cc, so we build in metadata now instead of calling into the cloud controller.","accounts_in_message":[],"_revision_number":3},{"id":"0df42099633a43dad5664c00a0bc2be0f34e91a4","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-12 16:46:26.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5ca90b9f0cf777e2e027a247243fdcbf2cec54e4","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-12 16:52:10.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nlgtm.  I also have some fixes coming because of those fixed_ip/floating_ip calls via network manager are way too slow.  Affects OS API and EC2 API.","accounts_in_message":[],"_revision_number":4},{"id":"30607bb0453ea172526882834561e22b382c7385","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-12 19:17:25.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c10f2f824e9b39cea48e11a7a87bca3f102063d9","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-13 04:29:43.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nMinor thing.  HACKING violation.  Comment inline.  Hate being strict on it, but I want to get to some better consistency in the code.","accounts_in_message":[],"_revision_number":5},{"id":"30bf7f0bbce2c1317cee6564789f8a51a80f1a6c","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2011-10-13 13:53:27.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t submit this\n\nHi Todd. I\u0027m getting failure when running the nova smoke tests w/ this branch:\n\n\u003d\u003d\u003e /var/log/nova/nova-api.log \u003c\u003d\u003d\n(nova.api.ec2.metadata): TRACE:     return self.build_metadata(remote_address, req.path_info)\n(nova.api.ec2.metadata): TRACE:   File \"/usr/lib/python2.6/dist-packages/nova/api/ec2/metadatarequesthandler.py\", line 98, in build_metadata\n(nova.api.ec2.metadata): TRACE:     instance \u003d self.instance_from_remote_address(remote_address)\n(nova.api.ec2.metadata): TRACE: TypeError: instance_from_remote_address() takes exactly 1 argument (2 given)\n(nova.api.ec2.metadata): TRACE: \n2011-10-13 13:03:06,064 INFO nova.api [-] 0.1114s 192.168.0.2 GET /2009-04-04/meta-data/instance-id None:None 500 [Wget] text/plain text/plain\n2011-10-13 13:03:07,244 ERROR nova.api.ec2.metadata [-] Failed to get metadata for ip: 192.168.0.2\n(nova.api.ec2.metadata): TRACE: Traceback (most recent call last):\n(nova.api.ec2.metadata): TRACE:   File \"/usr/lib/python2.6/dist-packages/nova/api/ec2/metadatarequesthandler.py\", line 85, in __call__\n(nova.api.ec2.metadata): TRACE:     return self.build_metadata(remote_address, req.path_info)\n(nova.api.ec2.metadata): TRACE:   File \"/usr/lib/python2.6/dist-packages/nova/api/ec2/metadatarequesthandler.py\", line 98, in build_metadata\n(nova.api.ec2.metadata): TRACE:     instance \u003d self.instance_from_remote_address(remote_address)\n(nova.api.ec2.metadata): TRACE: TypeError: instance_from_remote_address() takes exactly 1 argument (2 given)\n(nova.api.ec2.metadata): TRACE: \n2011-10-13 13:03:07,245 INFO nova.api [-] 0.1097s 192.168.0.2 GET /2009-04-04/meta-data/instance-id None:None 500 [Wget] text/plain text/plain\n2011-10-13 13:03:08,441 ERROR nova.api.ec2.metadata [-] Failed to get metadata for ip: 192.168.0.2\n(nova.api.ec2.metadata): TRACE: Traceback (most recent call last):\n(nova.api.ec2.metadata): TRACE:   File \"/usr/lib/python2.6/dist-packages/nova/api/ec2/metadatarequesthandler.py\", line 85, in __call__\n(nova.api.ec2.metadata): TRACE:     return self.build_metadata(remote_address, req.path_info)\n(nova.api.ec2.metadata): TRACE:   File \"/usr/lib/python2.6/dist-packages/nova/api/ec2/metadatarequesthandler.py\", line 98, in build_metadata\n(nova.api.ec2.metadata): TRACE:     instance \u003d self.instance_from_remote_address(remote_address)\n(nova.api.ec2.metadata): TRACE: TypeError: instance_from_remote_address() takes exactly 1 argument (2 given)\n(nova.api.ec2.metadata): TRACE:","accounts_in_message":[],"_revision_number":5},{"id":"5098e357537665ac1be6a249d67ec695a279be6e","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-15 03:40:44.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"fc1aa80608fe7c9fef9b59a25c5811d841775fcd","author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"date":"2011-10-15 03:47:00.000000000","message":"Patch Set 6:\n\nFixed the stub to keep from hiding the issue smokestack saw.  \n\nDe-duplicated the code where appropriate.\n\nFixed some slashing to keep clients happy.\n\nMore testing, more goodness.","accounts_in_message":[],"_revision_number":6},{"id":"671f1066d958822157f286e3285786962066160f","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2011-10-17 15:00:15.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t submit this\n\nHi Todd,\n\nI\u0027m still seeing an \u0027IndexError: list index out of range\u0027 with the latest patchset revision 11f5872.\n\nhttp://paste.openstack.org/show/2736/","accounts_in_message":[],"_revision_number":6},{"id":"e7c53c8c5bf147a692b8fda670e161ffbbeb8990","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-18 23:54:31.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nMore infos inline.","accounts_in_message":[],"_revision_number":6},{"id":"082f8c38a82704f743ca046d9992e6890494e6c7","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2011-12-12 21:19:43.000000000","message":"Patch Set 6:\n\nSmokeStack Results (patch set 6):\n\tUnit Failed:Failed to rebase master. http://smokestack.openstack.org/?go\u003d/jobs/3788\n\tLibvirt Failed:Failed to rebase master. http://smokestack.openstack.org/?go\u003d/jobs/3786\n\tXenServer Failed:Failed to rebase master. http://smokestack.openstack.org/?go\u003d/jobs/3787","accounts_in_message":[],"_revision_number":6},{"id":"bb644052ad0827550ab5a51abdb4609ac0bfdae1","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:58.000000000","message":"Patch Set 6:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":6},{"id":"742b16b55c5f578f2c60ca9e4f5cb9ef685af686","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:59.000000000","message":"Patch Set 6: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"11f5872f3f9744442a263a18fae425fe715e0cb9","revisions":{"ffb1b404ebc9a0ea64aaa9f602f374d8075a25ca":{"kind":"REWORK","_number":1,"created":"2011-10-07 00:04:11.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/1"}}},"commit":{"parents":[{"commit":"22859fccb95502efcb73ecf2bd827c45c0886bd3","subject":"Merge \"Stop returning correct password on api calls\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/22859fccb95502efcb73ecf2bd827c45c0886bd3"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:02:49.000000000","tz":-240},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:03:57.000000000","tz":-240},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nConflicts:\n\n\tnova/api/ec2/cloud.py\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ffb1b404ebc9a0ea64aaa9f602f374d8075a25ca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ffb1b404ebc9a0ea64aaa9f602f374d8075a25ca"}]},"branch":"refs/heads/master"},"47ea97b7eb69973119b4f35863e5953d33d77db6":{"kind":"REWORK","_number":2,"created":"2011-10-07 06:20:43.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/2"}}},"commit":{"parents":[{"commit":"22859fccb95502efcb73ecf2bd827c45c0886bd3","subject":"Merge \"Stop returning correct password on api calls\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/22859fccb95502efcb73ecf2bd827c45c0886bd3"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:02:49.000000000","tz":-240},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 06:19:14.000000000","tz":-240},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/47ea97b7eb69973119b4f35863e5953d33d77db6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/47ea97b7eb69973119b4f35863e5953d33d77db6"}]},"branch":"refs/heads/master"},"c29b25c749c948a0ea099f25e51049c5ca344f71":{"kind":"REWORK","_number":3,"created":"2011-10-12 05:52:09.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/3"}}},"commit":{"parents":[{"commit":"f5f429bac6446db084ca3f5d86c64127a1e539f2","subject":"Merge \"Adds the tenant id to the create images response Location header Fixes bug 862672\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f5f429bac6446db084ca3f5d86c64127a1e539f2"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:02:49.000000000","tz":-240},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-12 05:51:56.000000000","tz":-240},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c29b25c749c948a0ea099f25e51049c5ca344f71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c29b25c749c948a0ea099f25e51049c5ca344f71"}]},"branch":"refs/heads/master"},"d8a2e0d2d33fad0585b65d1a6c51c433fe7775a5":{"kind":"REWORK","_number":4,"created":"2011-10-12 16:46:26.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/4"}}},"commit":{"parents":[{"commit":"c12d610878cf9dd974d5811af20ff76635f60063","subject":"Merge \"Allow tenant networks to be shared with domain 0.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c12d610878cf9dd974d5811af20ff76635f60063"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:02:49.000000000","tz":-240},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-12 16:46:05.000000000","tz":-240},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d8a2e0d2d33fad0585b65d1a6c51c433fe7775a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d8a2e0d2d33fad0585b65d1a6c51c433fe7775a5"}]},"branch":"refs/heads/master"},"112d9a88fb54429620b4af6887bc8cc933264168":{"kind":"REWORK","_number":5,"created":"2011-10-12 19:17:25.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/5"}}},"commit":{"parents":[{"commit":"c0cf874acb3a67371ebbd5abbd274f61ffa09396","subject":"Merge \"Update EC2 get_metadata calls to search \u0027deleted\u0027: False. Fixes nova smoke_tests!!!\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c0cf874acb3a67371ebbd5abbd274f61ffa09396"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-07 00:02:49.000000000","tz":-240},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-12 19:17:11.000000000","tz":-240},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/112d9a88fb54429620b4af6887bc8cc933264168"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/112d9a88fb54429620b4af6887bc8cc933264168"}]},"branch":"refs/heads/master"},"11f5872f3f9744442a263a18fae425fe715e0cb9":{"kind":"REWORK","_number":6,"created":"2011-10-15 03:40:44.000000000","uploader":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"ref":"refs/changes/09/809/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/809/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/809/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/809/6"}}},"commit":{"parents":[{"commit":"1ebd98e3d20a35fc543800677cfe5e006a2f8cab","subject":"Cancel any clean_reboot tasks before issuing the hard_reboot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1ebd98e3d20a35fc543800677cfe5e006a2f8cab"}]}],"author":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-15 02:37:18.000000000","tz":-420},"committer":{"name":"Todd Willey","email":"xtoddx@gmail.com","date":"2011-10-15 03:40:27.000000000","tz":-420},"subject":"Build metadata as needed through callbacks.","message":"Build metadata as needed through callbacks.\n\nFixes bug 851159.\n\nMoves all metadata requests out of the cloud controller into the\nMetadataRequestHandler class.\n\nUses callbacks to generate data as needed.  Requests just for structural\nelements do not generate any database requests.  Requests for specific data\nitems to be loaded only load what is required, not the entire tree.\n\nThere is still room for improvement with caching, or having all of this data\npre-generated.\n\nChange-Id: Icaa647705d6d4cbc3b784ac719c35eb54ebae9d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11f5872f3f9744442a263a18fae425fe715e0cb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11f5872f3f9744442a263a18fae425fe715e0cb9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}