)]}'
{"id":"openstack%2Fnova~809282","triplet_id":"openstack%2Fnova~stable%2Fvictoria~Ia222e0f64b932e6aefe779b168d0aa4e9ff48075","project":"openstack/nova","branch":"stable/victoria","hashtags":[],"change_id":"Ia222e0f64b932e6aefe779b168d0aa4e9ff48075","subject":"Fix ImageBackendFixture not to support direct_snapshot","status":"ABANDONED","created":"2021-09-15 19:54:09.000000000","updated":"2023-02-02 20:43:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b1c65986170b2785c40851cea8464ca6f73c62b6","_number":809282,"virtual_id_number":809282,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-09-15 20:39:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-15 19:54:09.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-09-15 20:39:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-15 22:59:15.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"920474ec40666889b37625c681828cc9aa1ffa14","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-09-15 19:54:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a99f4a161d197352c5e1711849c5a09f28aa57db","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-15 20:39:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/be64a1bccfe54ac7bfa8987ac8264c3a : SUCCESS in 16m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b80b8c36663547008db9a571c61fee87 : SUCCESS in 15m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d0b1965c694440638f2c7b01f25d7537 : SUCCESS in 9m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aaceeb503fe94204b438e2d56984f5b3 : SUCCESS in 12m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/52954a5b090e4bdf808d29c721ab5240 : SUCCESS in 13m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/28bc3fb3968a43788b718bad5961aea9 : SUCCESS in 12m 07s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/3fe4d9cc0972476ea1c86a54a6db05d5 : SUCCESS in 8m 40s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/916fe0e1fd8f435eb9d4605ffd31d3d9 : SUCCESS in 26m 38s","accounts_in_message":[],"_revision_number":1},{"id":"6ded5534845680d85b41252b51ec1a0551796fe4","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-09-15 22:59:15.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/809282/1/iscsi : SUCCESS in 2h 30m 37s","accounts_in_message":[],"_revision_number":1},{"id":"b1c65986170b2785c40851cea8464ca6f73c62b6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2023-02-02 20:43:23.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bc254b94a524373deecbaef7d8cdcb279c75666f","revisions":{"bc254b94a524373deecbaef7d8cdcb279c75666f":{"kind":"REWORK","_number":1,"created":"2021-09-15 19:54:09.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/82/809282/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/809282/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/809282/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/809282/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/809282/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/809282/1"}}},"commit":{"parents":[{"commit":"648c677dfa733e20837da717d76c933bd9a5e595","subject":"functional: Add live migration tests for PCI, SR-IOV servers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/648c677dfa733e20837da717d76c933bd9a5e595"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-03-03 13:36:06.000000000","tz":60},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2021-09-15 19:52:39.000000000","tz":-240},"subject":"Fix ImageBackendFixture not to support direct_snapshot","message":"Fix ImageBackendFixture not to support direct_snapshot\n\nThe ImageBackendFixture mocks returns a mocked disk and that disk\nblindly supports the direct_snapshot call by returning a MagicMock as a\nresult. A real imagebacked returns the location of the snapshot instead.\nWhen the result of the snapshot is uploaded to the GlanceFixture the\nfixtures stores the metadata including the MagicMock. Later when such\nsnapshot is downloaded from the fixture (e.g. during unshelve) the\nGlance fixture tries to deepcopy the metadata to avoid clients modifying\nthe returned data to affect the internal state of the fixture. But\nMagicMock cannot be deep copied.\n\nAn easy fix is to declare direct_snapshot not supported for\nImageBackendFixture by raising NotImplementedError. This is already\nhandled by the virt driver as we have real backends that are not\nsupporting the direct snapshot call. This way the whole issue in the\nGlanceFixture can be avoided.\n\nNOTE(artom) The backport on top of this one triggers the exact error\ndescribed in the first paragraph. Pull this in to fix that.\n\nChange-Id: Ia222e0f64b932e6aefe779b168d0aa4e9ff48075\n(cherry picked from commit 947f813e562101d6c05ae47940f36de7c33604e5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bc254b94a524373deecbaef7d8cdcb279c75666f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bc254b94a524373deecbaef7d8cdcb279c75666f"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}