)]}'
{"contrib/boto_v6/ec2/connection.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"346a87b285a83c38d1322312aee08bcfe86467e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"import boto"},{"line_number":7,"context_line":"import base64"},{"line_number":8,"context_line":"import boto.ec2"},{"line_number":9,"context_line":"from boto_v6.ec2.instance import ReservationV6"},{"line_number":10,"context_line":"from boto.ec2.securitygroup import SecurityGroup"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Fp8%3D","line":9,"updated":"2012-06-06 21:31:11.000000000","message":"Sorry to be that guy, but can you revert this change?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"005eaab0c8ba4226e98f6d8240ce41ef77c4c540","unresolved":false,"context_lines":[{"line_number":6,"context_line":"import boto"},{"line_number":7,"context_line":"import base64"},{"line_number":8,"context_line":"import boto.ec2"},{"line_number":9,"context_line":"from boto_v6.ec2.instance import ReservationV6"},{"line_number":10,"context_line":"from boto.ec2.securitygroup import SecurityGroup"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Fl0%3D","line":9,"in_reply_to":"AAAAIH%2F%2F%2Fp8%3D","updated":"2012-06-06 22:14:48.000000000","message":"Well, removing that extra space is going to fix a pep8 error, which is probably why he did it in the first place…and I don\u0027t like the idea of excepting all of contrib from pep8…","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"}],"nova/network/linux_net.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"346a87b285a83c38d1322312aee08bcfe86467e6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#             add up to 12 characters to binary_name which is used as a prefix,"},{"line_number":91,"context_line":"#             so we limit it to 16 characters."},{"line_number":92,"context_line":"#             (max_chain_name_length - len(\u0027-POSTROUTING\u0027) \u003d\u003d 16)"},{"line_number":93,"context_line":"def get_binary_name():"},{"line_number":94,"context_line":"    \"\"\"Grab the name of the binary we\u0027re running in.\"\"\""},{"line_number":95,"context_line":"    return os.path.basename(inspect.stack()[-1][1])[:16]"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2FqA%3D","line":93,"updated":"2012-06-06 21:31:11.000000000","message":"Why was this change made?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2950de6b8c92f192878de67c569dffde30ab408f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#             add up to 12 characters to binary_name which is used as a prefix,"},{"line_number":91,"context_line":"#             so we limit it to 16 characters."},{"line_number":92,"context_line":"#             (max_chain_name_length - len(\u0027-POSTROUTING\u0027) \u003d\u003d 16)"},{"line_number":93,"context_line":"def get_binary_name():"},{"line_number":94,"context_line":"    \"\"\"Grab the name of the binary we\u0027re running in.\"\"\""},{"line_number":95,"context_line":"    return os.path.basename(inspect.stack()[-1][1])[:16]"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2FmI%3D","line":93,"in_reply_to":"AAAAIH%2F%2F%2FqA%3D","updated":"2012-06-06 22:09:48.000000000","message":"Oh. Carry on.","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"}],"nova/tests/__init__.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"346a87b285a83c38d1322312aee08bcfe86467e6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova import flags"},{"line_number":42,"context_line":"from nova import log as logging"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"import eventlet"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"eventlet.monkey_patch()"},{"line_number":47,"context_line":"logging.setup()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Fp4%3D","line":44,"updated":"2012-06-06 21:31:11.000000000","message":"Why did you make this change?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"39792978f0fb84ee0569dd74c5fe1d2ea3f89815","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova import flags"},{"line_number":42,"context_line":"from nova import log as logging"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"import eventlet"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"eventlet.monkey_patch()"},{"line_number":47,"context_line":"logging.setup()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2FeQ%3D","line":44,"in_reply_to":"AAAAIH%2F%2F%2Flw%3D","updated":"2012-06-07 04:00:18.000000000","message":"That is correct.","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3a084dc225387a0f38e8a8d5ed63cfe1e230c213","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova import flags"},{"line_number":42,"context_line":"from nova import log as logging"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"import eventlet"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"eventlet.monkey_patch()"},{"line_number":47,"context_line":"logging.setup()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Flw%3D","line":44,"in_reply_to":"AAAAIH%2F%2F%2Fp4%3D","updated":"2012-06-06 22:19:54.000000000","message":"Assuming it\u0027s because we don\u0027t have runner.py to set this up anymore?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"}],"nova/tests/test_iptables_network.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"346a87b285a83c38d1322312aee08bcfe86467e6","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IptablesManagerTestCase(test.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    binary_name \u003d linux_net.get_binary_name()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sample_filter \u003d [\u0027#Generated by iptables-save on Fri Feb 18 15:17:05 2011\u0027,"},{"line_number":29,"context_line":"                     \u0027*filter\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Fp0%3D","line":26,"updated":"2012-06-06 21:31:11.000000000","message":"WHY!?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3a084dc225387a0f38e8a8d5ed63cfe1e230c213","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class IptablesManagerTestCase(test.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    binary_name \u003d linux_net.get_binary_name()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sample_filter \u003d [\u0027#Generated by iptables-save on Fri Feb 18 15:17:05 2011\u0027,"},{"line_number":29,"context_line":"                     \u0027*filter\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Fl4%3D","line":26,"in_reply_to":"AAAAIH%2F%2F%2Fp0%3D","updated":"2012-06-06 22:19:54.000000000","message":"nvm","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"005eaab0c8ba4226e98f6d8240ce41ef77c4c540","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        table.remove_rule(\u0027FORWARD\u0027, \u0027-s 1.2.3.4/5 -j DROP\u0027)"},{"line_number":92,"context_line":"        new_lines \u003d self.manager._modify_rules(current_lines, table)"},{"line_number":93,"context_line":"        self.assertTrue(\u0027-A %s-FORWARD \u0027"},{"line_number":94,"context_line":"                        \u0027-s 1.2.3.4/5 -j DROP\u0027 % self.binary_name \\"},{"line_number":95,"context_line":"                        not in new_lines)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_nat_rules(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAIH%2F%2F%2Flo%3D","line":94,"updated":"2012-06-06 22:14:48.000000000","message":"This backslash is not necessary, since this entire expression is already wrapped in parentheses.","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"}],"tox.ini":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"005eaab0c8ba4226e98f6d8240ce41ef77c4c540","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"deps \u003d pep8\u003d\u003d1.1"},{"line_number":22,"context_line":"commands \u003d pep8 --repeat --show-source --exclude\u003d.venv,.tox,dist,doc ."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d NOSE_WITH_COVERAGE\u003d1"}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAIH%2F%2F%2Flg%3D","line":22,"updated":"2012-06-06 22:14:48.000000000","message":"Any way we can use hacking.py instead of raw pep8?","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"39792978f0fb84ee0569dd74c5fe1d2ea3f89815","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"deps \u003d pep8\u003d\u003d1.1"},{"line_number":22,"context_line":"commands \u003d pep8 --repeat --show-source --exclude\u003d.venv,.tox,dist,doc ."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d NOSE_WITH_COVERAGE\u003d1"}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAIH%2F%2F%2FeM%3D","line":22,"in_reply_to":"AAAAIH%2F%2F%2Flg%3D","updated":"2012-06-07 04:00:18.000000000","message":"WELL... One of the things I\u0027m trying to get here is the start of a tox.ini that has no project-specific differences in it.\n\nSO - if we want to use hacking.py, we should make it a real pypi project that depends on pep8 and we should apply it to all of the projects in OpenStack.\n\nI\u0027m not opposed to doing that, of course - but for _now_ I\u0027d really like to get the projects consistent if we can.","commit_id":"1eab064c1516784b9efed059a1f4bf3e33c83942"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"4f3dfeb11e2a72e97ee49c8e72dc364acbe94dc7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[testenv:pep8]"},{"line_number":21,"context_line":"deps \u003d pep8\u003d\u003d1.1"},{"line_number":22,"context_line":"commands \u003d pep8 --repeat --show-source --exclude\u003d.venv,.tox,dist,doc ."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d NOSE_WITH_COVERAGE\u003d1"}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAAIH%2F%2F%2FN0%3D","line":22,"updated":"2012-06-07 16:08:03.000000000","message":"Bringing up Kevin\u0027s comment again: a lot of work was done on hacking.py and I really don\u0027t want to drop it... Can we think of a way to keep running hacking.py for now?","commit_id":"4886fc43924fc5ea6f15488e400540ff9b80aa2c"}]}