)]}'
{"nova/tests/fixtures/cinder.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8957ca6235e525b568c68ad9343a3f3b2b87d1b3","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    def setUp(self):"},{"line_number":100,"context_line":"        super().setUp()"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        def _is_multiattach(volume_id):"},{"line_number":103,"context_line":"            return volume_id in ["},{"line_number":104,"context_line":"                self.MULTIATTACH_VOL,"},{"line_number":105,"context_line":"                self.MULTIATTACH_RO_SWAP_OLD_VOL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae499d6f_255900e3","line":102,"updated":"2021-09-27 13:56:06.000000000","message":"nit: you could have reused this private helper at L286 but OK.","commit_id":"bea2cf743af22a8e3553018717a7a0ce54fe06de"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8957ca6235e525b568c68ad9343a3f3b2b87d1b3","unresolved":true,"context_lines":[{"line_number":283,"context_line":"                \u0027connector\u0027: connector,"},{"line_number":284,"context_line":"            }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            if volume_id in [self.MULTIATTACH_RO_SWAP_OLD_VOL,"},{"line_number":287,"context_line":"                             self.MULTIATTACH_RO_SWAP_NEW_VOL,"},{"line_number":288,"context_line":"                             self.MULTIATTACH_RO_MIGRATE_OLD_VOL,"},{"line_number":289,"context_line":"                             self.MULTIATTACH_RO_MIGRATE_NEW_VOL]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"325b55cb_6238e3ff","line":286,"updated":"2021-09-27 13:56:06.000000000","message":"see, you could have said (if this helper was a class method):\n\n  if self._is_multiattach(volume_id):\n\nbut meh, OK.","commit_id":"bea2cf743af22a8e3553018717a7a0ce54fe06de"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"b1db15d5d8a7924df41e5f70b4397173a175523e","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                \u0027connector\u0027: connector,"},{"line_number":284,"context_line":"            }"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            if volume_id in [self.MULTIATTACH_RO_SWAP_OLD_VOL,"},{"line_number":287,"context_line":"                             self.MULTIATTACH_RO_SWAP_NEW_VOL,"},{"line_number":288,"context_line":"                             self.MULTIATTACH_RO_MIGRATE_OLD_VOL,"},{"line_number":289,"context_line":"                             self.MULTIATTACH_RO_MIGRATE_NEW_VOL]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"11dbb7c5_8f2cf9c8","line":286,"in_reply_to":"325b55cb_6238e3ff","updated":"2021-09-27 14:00:35.000000000","message":"This is a different check for read only volumes, as it\u0027s only used once I just left it inline.","commit_id":"bea2cf743af22a8e3553018717a7a0ce54fe06de"}],"nova/tests/functional/regressions/test_bug_1943431.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8957ca6235e525b568c68ad9343a3f3b2b87d1b3","unresolved":true,"context_lines":[{"line_number":158,"context_line":"            self.api.delete_server_volume,"},{"line_number":159,"context_line":"            server_id,"},{"line_number":160,"context_line":"            self.cinder.MULTIATTACH_RO_MIGRATE_OLD_VOL)"},{"line_number":161,"context_line":"        self.assertEqual(500, ex.response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5b8433f_d1d22e2a","line":161,"updated":"2021-09-27 13:56:06.000000000","message":"ack.","commit_id":"bea2cf743af22a8e3553018717a7a0ce54fe06de"}]}
