)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2311b63ade32ab904b5eb3e80842b71ff97994f0","unresolved":true,"context_lines":[{"line_number":5748,"context_line":"        # to ACTIVE for backwards compatibility"},{"line_number":5749,"context_line":"        old_vm_state \u003d instance.system_metadata.get(\u0027old_vm_state\u0027,"},{"line_number":5750,"context_line":"                                                    vm_states.ACTIVE)"},{"line_number":5751,"context_line":"        instance.old_flavor \u003d old_flavor"},{"line_number":5752,"context_line":""},{"line_number":5753,"context_line":"        if old_instance_type_id !\u003d new_instance_type_id:"},{"line_number":5754,"context_line":"            new_flavor \u003d instance.new_flavor  # this is set in _prep_resize"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc6c2ec_fa75b20f","side":"PARENT","line":5751,"updated":"2021-09-27 09:49:25.000000000","message":"Grenade showed that we cannot drop this because during upgrade when the source compute is unfixed then resize_instance does  not set the old_flavor, but if the dest compute is already fixed then we are not setting the old_flavor there either.","commit_id":"3e4e4489b7a6e9cdefcc6ff02ed99a0a70420fca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b0fb846927cfa7d28fdf4d4090cc3dc2357e2aff","unresolved":false,"context_lines":[{"line_number":5748,"context_line":"        # to ACTIVE for backwards compatibility"},{"line_number":5749,"context_line":"        old_vm_state \u003d instance.system_metadata.get(\u0027old_vm_state\u0027,"},{"line_number":5750,"context_line":"                                                    vm_states.ACTIVE)"},{"line_number":5751,"context_line":"        instance.old_flavor \u003d old_flavor"},{"line_number":5752,"context_line":""},{"line_number":5753,"context_line":"        if old_instance_type_id !\u003d new_instance_type_id:"},{"line_number":5754,"context_line":"            new_flavor \u003d instance.new_flavor  # this is set in _prep_resize"}],"source_content_type":"text/x-python","patch_set":1,"id":"30a97adb_3d41e782","side":"PARENT","line":5751,"in_reply_to":"0bc6c2ec_fa75b20f","updated":"2021-09-27 10:39:12.000000000","message":"Done","commit_id":"3e4e4489b7a6e9cdefcc6ff02ed99a0a70420fca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0f07d8ca1b32f7bdafcb16593b6ba15f456c5d58","unresolved":false,"context_lines":[{"line_number":5748,"context_line":"        # to ACTIVE for backwards compatibility"},{"line_number":5749,"context_line":"        old_vm_state \u003d instance.system_metadata.get(\u0027old_vm_state\u0027,"},{"line_number":5750,"context_line":"                                                    vm_states.ACTIVE)"},{"line_number":5751,"context_line":"        instance.old_flavor \u003d old_flavor"},{"line_number":5752,"context_line":""},{"line_number":5753,"context_line":"        if old_instance_type_id !\u003d new_instance_type_id:"},{"line_number":5754,"context_line":"            new_flavor \u003d instance.new_flavor  # this is set in _prep_resize"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ece0964_0c6eba24","side":"PARENT","line":5751,"in_reply_to":"30a97adb_3d41e782","updated":"2021-09-27 12:34:57.000000000","message":"OK PS2 fixed this. The remaining grenade failure are unrelated to this patch and being discussed separately.","commit_id":"3e4e4489b7a6e9cdefcc6ff02ed99a0a70420fca"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"aa61bf0a312ad47d6d38305e50016fa0a4feb1f9","unresolved":false,"context_lines":[{"line_number":5756,"context_line":"        # to ACTIVE for backwards compatibility"},{"line_number":5757,"context_line":"        old_vm_state \u003d instance.system_metadata.get(\u0027old_vm_state\u0027,"},{"line_number":5758,"context_line":"                                                    vm_states.ACTIVE)"},{"line_number":5759,"context_line":"        # NOTE(gibi): this is already set by the resize_instance on the source"},{"line_number":5760,"context_line":"        # node before calling finish_resize on destination but during upgrade"},{"line_number":5761,"context_line":"        # it can be that the source node is not having the fix for bug 1944759"},{"line_number":5762,"context_line":"        # yet. This assignment can be removed in Z release."}],"source_content_type":"text/x-python","patch_set":2,"id":"a4a7f40b_43761e59","line":5759,"range":{"start_line":5759,"start_character":10,"end_line":5759,"end_character":14},"updated":"2021-09-30 13:29:07.000000000","message":"supernit - TODO?","commit_id":"b841e553214be9a732703e2dfed6c97698ef9b71"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c213e2673feef329e54e062c1ca94b64742d9a0","unresolved":false,"context_lines":[{"line_number":5756,"context_line":"        # to ACTIVE for backwards compatibility"},{"line_number":5757,"context_line":"        old_vm_state \u003d instance.system_metadata.get(\u0027old_vm_state\u0027,"},{"line_number":5758,"context_line":"                                                    vm_states.ACTIVE)"},{"line_number":5759,"context_line":"        # NOTE(gibi): this is already set by the resize_instance on the source"},{"line_number":5760,"context_line":"        # node before calling finish_resize on destination but during upgrade"},{"line_number":5761,"context_line":"        # it can be that the source node is not having the fix for bug 1944759"},{"line_number":5762,"context_line":"        # yet. This assignment can be removed in Z release."}],"source_content_type":"text/x-python","patch_set":2,"id":"8fe7a026_15f3ed0d","line":5759,"range":{"start_line":5759,"start_character":10,"end_line":5759,"end_character":14},"in_reply_to":"a4a7f40b_43761e59","updated":"2021-09-30 13:52:35.000000000","message":"Agreed, this should be a TODO but meh.","commit_id":"b841e553214be9a732703e2dfed6c97698ef9b71"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c213e2673feef329e54e062c1ca94b64742d9a0","unresolved":true,"context_lines":[{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        self._assert_pinned_cpus(src_host, 2)"},{"line_number":930,"context_line":"        self._assert_pinned_cpus(dst_host, 0)"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"class NUMAServerTestWithCountingQuotaFromPlacement(NUMAServersTest):"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9c2cf282_18d350a5","line":931,"updated":"2021-09-30 13:52:35.000000000","message":"I\u0027d be more than happy if you could have written some upgrade test that would verify that it works between an old and a new compute but meh, we already have grenade.","commit_id":"b841e553214be9a732703e2dfed6c97698ef9b71"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26566784a31a98d15812272bb8add0ac6d75abaf","unresolved":true,"context_lines":[{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        self._assert_pinned_cpus(src_host, 2)"},{"line_number":930,"context_line":"        self._assert_pinned_cpus(dst_host, 0)"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"class NUMAServerTestWithCountingQuotaFromPlacement(NUMAServersTest):"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"872a582e_5af54f53","line":931,"in_reply_to":"9c2cf282_18d350a5","updated":"2021-09-30 15:02:53.000000000","message":"Yepp grenade caught my issue with the upgrade fortunately. Do we have examples of such functional tests with different code versions? I think the problem with such test is that in func env we have a single version of nova code, so I can only simulate the unpatched behavior on the source node with heavy and ugly mocking.","commit_id":"b841e553214be9a732703e2dfed6c97698ef9b71"}]}