)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0509a6317fb27581ee2cc7d0e1bb70f3e4b162bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a176a64d_da10fad3","updated":"2021-11-03 15:18:42.000000000","message":"LGTM","commit_id":"46401ef6665d473b51a781a566a29b7b24eb711f"}],"nova/api/openstack/wsgi_app.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0a1f828d80fc9d16b2de9d8615352ec1b64fcc9","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    logging.setup(CONF, \"nova\")"},{"line_number":95,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":96,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version, conf\u003dCONF, service_name\u003dname)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # dump conf at debug (log_options option comes from oslo.service)"},{"line_number":99,"context_line":"    # FIXME(mriedem): This is gross but we don\u0027t have a public hook into"}],"source_content_type":"text/x-python","patch_set":3,"id":"5e52d396_d8e07b01","line":96,"range":{"start_line":96,"start_character":60,"end_line":96,"end_character":78},"updated":"2021-09-24 15:54:12.000000000","message":"name is not defined in this scope","commit_id":"e79c21777b639fe7b984cf881faddbab6f2fd5e4"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1e447835eb8e3ac7e4d24facf2fb3366319a6c83","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    logging.setup(CONF, \"nova\")"},{"line_number":95,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":96,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version, conf\u003dCONF, service_name\u003dname)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # dump conf at debug (log_options option comes from oslo.service)"},{"line_number":99,"context_line":"    # FIXME(mriedem): This is gross but we don\u0027t have a public hook into"}],"source_content_type":"text/x-python","patch_set":3,"id":"2bb62372_dced2d8d","line":96,"range":{"start_line":96,"start_character":60,"end_line":96,"end_character":78},"in_reply_to":"5e52d396_d8e07b01","updated":"2021-09-25 05:35:44.000000000","message":"Whops, my bad. I\u0027ve cherry picked this from an older branch, which didn\u0027t have https://github.com/openstack/nova/commit/7c9edc02eda45aafbbb539b759e6b92f7aeb5ea8. Fixing it right away, thanks!","commit_id":"e79c21777b639fe7b984cf881faddbab6f2fd5e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2918f84b5db3a2d6243e84c6518a4d685c75d89","unresolved":true,"context_lines":[{"line_number":49,"context_line":"def _setup_service(host, name):"},{"line_number":50,"context_line":"    utils.raise_if_old_compute()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":55,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":4,"id":"9efeed31_ab4860a1","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":67},"updated":"2021-10-13 10:31:49.000000000","message":"im not sure if we shoudl pull this out to line 112","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"08c47edeac904b1a950f865b90460e5e3995b3bd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def _setup_service(host, name):"},{"line_number":50,"context_line":"    utils.raise_if_old_compute()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":55,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":4,"id":"ad768495_060aa345","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":67},"in_reply_to":"33de334f_c4130ac6","updated":"2021-10-13 12:20:15.000000000","message":"hmm, I think we should keep this prefix isolated. calling deploy.loadapp will fail otherwise:\n\nLookupError: No section \u0027nova-osapi_compute\u0027 (prefixed by \u0027app\u0027 or \u0027application\u0027 or \u0027composite\u0027 or \u0027composit\u0027 or \u0027pipeline\u0027 or \u0027filter-app\u0027) found in config /etc/nova/api-paste","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"28238ce6bece5b591c3f6133dfa6755a8161b63a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def _setup_service(host, name):"},{"line_number":50,"context_line":"    utils.raise_if_old_compute()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":55,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":4,"id":"2ed94a0b_4da8833c","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":67},"in_reply_to":"747f6a8b_894d8ce1","updated":"2021-10-13 11:27:15.000000000","message":"Done","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"28238ce6bece5b591c3f6133dfa6755a8161b63a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def _setup_service(host, name):"},{"line_number":50,"context_line":"    utils.raise_if_old_compute()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":55,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":4,"id":"33de334f_c4130ac6","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":67},"in_reply_to":"747f6a8b_894d8ce1","updated":"2021-10-13 11:27:15.000000000","message":"Done","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"882dea4ec6cc613995eef06b3f822f0fbd8cb566","unresolved":true,"context_lines":[{"line_number":49,"context_line":"def _setup_service(host, name):"},{"line_number":50,"context_line":"    utils.raise_if_old_compute()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":55,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":4,"id":"747f6a8b_894d8ce1","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":67},"in_reply_to":"9efeed31_ab4860a1","updated":"2021-10-13 10:45:02.000000000","message":"sounds good to me, it may avoid certain inconsistencies","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2918f84b5db3a2d6243e84c6518a4d685c75d89","unresolved":true,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def init_application(name):"},{"line_number":111,"context_line":"    conf_files \u003d _get_config_files()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # NOTE(melwitt): The init_application method can be called multiple times"},{"line_number":114,"context_line":"    # within a single python interpreter instance if any exception is raised"},{"line_number":115,"context_line":"    # during it (example: DBConnectionError while setting up the service) and"}],"source_content_type":"text/x-python","patch_set":4,"id":"7717a76f_b975240d","line":112,"updated":"2021-10-13 10:31:49.000000000","message":"so add \n\nbinary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"28238ce6bece5b591c3f6133dfa6755a8161b63a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def init_application(name):"},{"line_number":111,"context_line":"    conf_files \u003d _get_config_files()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    # NOTE(melwitt): The init_application method can be called multiple times"},{"line_number":114,"context_line":"    # within a single python interpreter instance if any exception is raised"},{"line_number":115,"context_line":"    # during it (example: DBConnectionError while setting up the service) and"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c499680_b960ca37","line":112,"in_reply_to":"7717a76f_b975240d","updated":"2021-10-13 11:27:15.000000000","message":"Done","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2918f84b5db3a2d6243e84c6518a4d685c75d89","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    # apache/mod_wsgi reloads the init_application script. So, we initialize"},{"line_number":117,"context_line":"    # global data separately and decorate the method to run only once in a"},{"line_number":118,"context_line":"    # python interpreter instance."},{"line_number":119,"context_line":"    init_global_data(conf_files, name)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    try:"},{"line_number":122,"context_line":"        _setup_service(CONF.host, name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b057262_c7aebb25","line":119,"range":{"start_line":119,"start_character":33,"end_line":119,"end_character":37},"updated":"2021-10-13 10:31:49.000000000","message":"then pass binary here\n\nbut i think over all this looks good to me as is","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"28238ce6bece5b591c3f6133dfa6755a8161b63a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # apache/mod_wsgi reloads the init_application script. So, we initialize"},{"line_number":117,"context_line":"    # global data separately and decorate the method to run only once in a"},{"line_number":118,"context_line":"    # python interpreter instance."},{"line_number":119,"context_line":"    init_global_data(conf_files, name)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    try:"},{"line_number":122,"context_line":"        _setup_service(CONF.host, name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c240991e_598c64b4","line":119,"range":{"start_line":119,"start_character":33,"end_line":119,"end_character":37},"in_reply_to":"5b057262_c7aebb25","updated":"2021-10-13 11:27:15.000000000","message":"Done","commit_id":"5f575b297f04e9b71c73371a266795d8857acb13"}]}