)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"be1418018a409db01831d61ba096964745dbaad0","unresolved":true,"context_lines":[{"line_number":794,"context_line":"               min\u003d0,"},{"line_number":795,"context_line":"               max\u003d28,"},{"line_number":796,"context_line":"               help\u003d \"\"\""},{"line_number":797,"context_line":"The number of additional PCIe ports an instance will get."},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"By default we attach just 1 free port which limits hotplug."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Libvirt allows a custom number of PCIe ports (pcie-root-port controllers) a"},{"line_number":802,"context_line":"target instance will get. Some will be used by default, rest will be available"}],"source_content_type":"text/x-python","patch_set":2,"id":"d67cd644_8c22fa09","line":799,"range":{"start_line":797,"start_character":0,"end_line":799,"end_character":59},"updated":"2021-09-30 13:36:21.000000000","message":"I think you\u0027re confusing the controller and ports.\n\nLibvirtConfigGuestPCIeRootController !\u003d LibvirtConfigGuestPCIeRootPortController\n\nWe always add the root controller, we don\u0027t always add ports AFAICT.","commit_id":"63863b2cfa76129cdb75e4fa8fc08845324c54b1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"fd0112afa2780bb4efb7c07eec2bdfcf340d525f","unresolved":false,"context_lines":[{"line_number":794,"context_line":"               min\u003d0,"},{"line_number":795,"context_line":"               max\u003d28,"},{"line_number":796,"context_line":"               help\u003d \"\"\""},{"line_number":797,"context_line":"The number of additional PCIe ports an instance will get."},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"By default we attach just 1 free port which limits hotplug."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Libvirt allows a custom number of PCIe ports (pcie-root-port controllers) a"},{"line_number":802,"context_line":"target instance will get. Some will be used by default, rest will be available"}],"source_content_type":"text/x-python","patch_set":2,"id":"f42a10cb_ad82580d","line":799,"range":{"start_line":797,"start_character":0,"end_line":799,"end_character":59},"in_reply_to":"d67cd644_8c22fa09","updated":"2021-09-30 17:31:39.000000000","message":"I indeed confused that! Thanks for clarification!","commit_id":"63863b2cfa76129cdb75e4fa8fc08845324c54b1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2b447cbb84d69bef0488da3713b5a435cb93e9ad","unresolved":false,"context_lines":[{"line_number":794,"context_line":"               min\u003d0,"},{"line_number":795,"context_line":"               max\u003d28,"},{"line_number":796,"context_line":"               help\u003d \"\"\""},{"line_number":797,"context_line":"The number of additional PCIe ports an instance will get."},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"By default we attach just 1 free port which limits hotplug."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Libvirt allows a custom number of PCIe ports (pcie-root-port controllers) a"},{"line_number":802,"context_line":"target instance will get. Some will be used by default, rest will be available"}],"source_content_type":"text/x-python","patch_set":2,"id":"5757a852_6366fbf5","line":799,"range":{"start_line":797,"start_character":0,"end_line":799,"end_character":59},"in_reply_to":"f42a10cb_ad82580d","updated":"2021-09-30 18:23:37.000000000","message":"tbh we should rename LibvirtConfigGuestPCIeRootPortController to LibvirtConfigGuestPCIeRootControllerPort to make that clear.\n\nI7c3d755f6fb9e863746eeb11d1b34ae0939720e7","commit_id":"63863b2cfa76129cdb75e4fa8fc08845324c54b1"}]}