)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e7525ff4eeb3e37680445260aa88fadb0f0b9f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52a30a41_13da5f01","updated":"2021-11-02 10:28:32.000000000","message":"Simple and understandable bugfix. Thanks for working on it.","commit_id":"49b481ec98087351ce1366d3afb9f4a79cd16ae3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fb361b329dd1dd294c4d4b159f5b02f4cc8d7dd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54f4d307_f00622b4","updated":"2021-10-29 21:14:26.000000000","message":"Thanks gibi, LGTM!","commit_id":"49b481ec98087351ce1366d3afb9f4a79cd16ae3"}],"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52d8730d044cc839b043a89899bde3d76b88ffa8","unresolved":false,"context_lines":[{"line_number":5145,"context_line":"            # ensure_compute_version_for_resource_request depends on the"},{"line_number":5146,"context_line":"            # port.resource_request field which only returned for admins"},{"line_number":5147,"context_line":"            port \u003d self.network_api.show_port("},{"line_number":5148,"context_line":"                context.elevated(), port_id)[\u0027port\u0027]"},{"line_number":5149,"context_line":"            if port.get(\u0027binding:vnic_type\u0027, \"normal\") \u003d\u003d \"vdpa\":"},{"line_number":5150,"context_line":"                # FIXME(sean-k-mooney): Attach works but detach results in a"},{"line_number":5151,"context_line":"                # QEMU error; blocked until this is resolved"}],"source_content_type":"text/x-python","patch_set":2,"id":"db5b72a4_908cf7f0","line":5148,"updated":"2021-10-20 09:41:23.000000000","message":"here no changes need as the admin usages is limited to this single neutron call.","commit_id":"9798cfb9a803e97c6af71aeef3d923199437fe21"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fb361b329dd1dd294c4d4b159f5b02f4cc8d7dd2","unresolved":false,"context_lines":[{"line_number":5145,"context_line":"            # ensure_compute_version_for_resource_request depends on the"},{"line_number":5146,"context_line":"            # port.resource_request field which only returned for admins"},{"line_number":5147,"context_line":"            port \u003d self.network_api.show_port("},{"line_number":5148,"context_line":"                context.elevated(), port_id)[\u0027port\u0027]"},{"line_number":5149,"context_line":"            if port.get(\u0027binding:vnic_type\u0027, \"normal\") \u003d\u003d \"vdpa\":"},{"line_number":5150,"context_line":"                # FIXME(sean-k-mooney): Attach works but detach results in a"},{"line_number":5151,"context_line":"                # QEMU error; blocked until this is resolved"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c1d9bae_a6a2df82","line":5148,"in_reply_to":"db5b72a4_908cf7f0","updated":"2021-10-29 21:14:26.000000000","message":"++","commit_id":"9798cfb9a803e97c6af71aeef3d923199437fe21"}],"nova/network/neutron.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0dd8336dc9d49390672f55122e48d152c139f4f3","unresolved":true,"context_lines":[{"line_number":1048,"context_line":"        \"\"\""},{"line_number":1049,"context_line":"        # We need to use an admin client as the port.resource_request is admin"},{"line_number":1050,"context_line":"        # only"},{"line_number":1051,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":1052,"context_line":"        port \u003d self._show_port(context, port_id, neutron_client\u003dneutron)"},{"line_number":1053,"context_line":"        if self._has_resource_request(context, port, neutron):"},{"line_number":1054,"context_line":"            return self._get_binding_profile_allocation("}],"source_content_type":"text/x-python","patch_set":2,"id":"3decd5cc_4926b7f1","line":1051,"updated":"2021-10-08 01:06:25.000000000","message":"This might be pedantic but ... considering there was a concerted effort in the past to not use an admin client unless necessary, should this be scoped down to only the \"show port\" calls? Or is there something that wouldn\u0027t work right if we only used admin client for GET of port?","commit_id":"9798cfb9a803e97c6af71aeef3d923199437fe21"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52d8730d044cc839b043a89899bde3d76b88ffa8","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"        \"\"\""},{"line_number":1049,"context_line":"        # We need to use an admin client as the port.resource_request is admin"},{"line_number":1050,"context_line":"        # only"},{"line_number":1051,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":1052,"context_line":"        port \u003d self._show_port(context, port_id, neutron_client\u003dneutron)"},{"line_number":1053,"context_line":"        if self._has_resource_request(context, port, neutron):"},{"line_number":1054,"context_line":"            return self._get_binding_profile_allocation("}],"source_content_type":"text/x-python","patch_set":2,"id":"b11ac7df_66cdbdcf","line":1051,"in_reply_to":"3decd5cc_4926b7f1","updated":"2021-10-20 09:41:23.000000000","message":"we only use the client to queries the list of neutron extensions (besides reading the port) and that is OK with a non admin client. So I change this to use the admin client selectively.\n\nDone.","commit_id":"9798cfb9a803e97c6af71aeef3d923199437fe21"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52d8730d044cc839b043a89899bde3d76b88ffa8","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        \"\"\""},{"line_number":1729,"context_line":"        # We need to use an admin client as the port.resource_request is admin"},{"line_number":1730,"context_line":"        # only"},{"line_number":1731,"context_line":"        neutron \u003d get_client(context, admin\u003dTrue)"},{"line_number":1732,"context_line":"        port_allocation: ty.Dict \u003d {}"},{"line_number":1733,"context_line":"        try:"},{"line_number":1734,"context_line":"            # NOTE(gibi): we need to read the port resource information from"}],"source_content_type":"text/x-python","patch_set":2,"id":"ad0651bc_88966b21","line":1731,"updated":"2021-10-20 09:41:23.000000000","message":"scoped down this admin client usage too.","commit_id":"9798cfb9a803e97c6af71aeef3d923199437fe21"}]}