)]}'
{"id":"openstack%2Fnova~811814","triplet_id":"openstack%2Fnova~stable%2Fvictoria~Iae119ea8776bc7f2e5dbe2e502a743217beded73","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1853159","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 18:57:19.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iae119ea8776bc7f2e5dbe2e502a743217beded73","subject":"Fix inactive session error in compute node creation","status":"ABANDONED","created":"2021-09-30 00:29:44.000000000","updated":"2024-03-05 18:57:19.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8f1160c77618ec2508cc02d6dbfe4e10d74ff9ac","_number":811814,"virtual_id_number":811814,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-09-30 05:13:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2022-12-20 16:03:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-30 00:29:44.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2021-09-30 03:21:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-30 06:42:28.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-12-20 16:03:19.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2024-03-05 18:57:19.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"9b4a16df684774ea2f27e786df981663f408150e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 00:29:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4223ff1789b3ee43f631ad1a4f246f2687cf836e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 00:30:11.000000000","message":"Topic bug/1853009 removed","accounts_in_message":[],"_revision_number":1},{"id":"9928bc222998dd344cbef811c017dbe4cbdcb660","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 00:30:16.000000000","message":"Topic set to bug/1853159","accounts_in_message":[],"_revision_number":1},{"id":"647fdd2bb1c46fb1d79439dbc3f708fe5a2acc60","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 01:44:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ad67661564e2c7795d07c8c74705409baf8f7795","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 01:45:08.000000000","message":"Topic bug/1853009 removed","accounts_in_message":[],"_revision_number":2},{"id":"3d1f79438a5f991195c15e89265a464996172928","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 01:45:11.000000000","message":"Topic set to bug/1853159","accounts_in_message":[],"_revision_number":2},{"id":"e6fff5ae164fd1615db01addb290c79ba5049f83","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 03:21:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/40ac37b3ef6a4e5bb1ea8ebeeddfd6f2 : SUCCESS in 1h 13m 58s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/91e3450f9f8845f4b12d264e37d7e400 : SUCCESS in 17m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1e36b27a8e6b4ca1937b33529b1c537e : SUCCESS in 14m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b064c39b602432ab1d80c23c21b5ad0 : SUCCESS in 8m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/67cf7a4d7b8443e6b29a65a24b0e89f7 : SUCCESS in 12m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2fdb9cfe19144984aef7d66a1abbf627 : SUCCESS in 14m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3894a00dfb0143b493bea4ba3da3ec08 : SUCCESS in 12m 30s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7d32c238493b4a9381bd7716b26e8a87 : SUCCESS in 1h 12m 26s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/84ded1e787c149e7924ca549769f39f2 : SUCCESS in 1h 17m 07s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4f91cb0347b4443bae84fa570f68d4dd : SUCCESS in 47m 05s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/a65e718ea230499da2b25df418b07296 : SUCCESS in 1h 16m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/830f6cb374ea49a4a4d71b1ed05896e0 : SUCCESS in 1h 33m 41s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/c397f6bbd0294f81be670af189b33c5b : FAILURE in 7m 31s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/76060b2c0c674d379e4e0b6b1a361d80 : SUCCESS in 16m 57s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ed0c38cd71394877acdad90131ba246e : SUCCESS in 1h 08m 13s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1e3e89e2b2bb4b89beb9173c1caf72d4 : SUCCESS in 56m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0e052a9450754920adb84b827466cf54 : SUCCESS in 51m 35s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/9dd7f93bc3984addb55f237e5b99d8da : SUCCESS in 29m 24s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/55be30cf562b4ce0913e832e63a81697 : SUCCESS in 38m 54s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"456a37fd1f437533c7cae50f9cc7793d391aad31","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 03:53:17.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"347784d6ac3604fefe4dfde01306f107596b1949","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 04:04:09.000000000","message":"Topic bug/1853009 removed","accounts_in_message":[],"_revision_number":3},{"id":"d710272a7b577b7d44112530c51429ffba8ac603","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-09-30 04:04:23.000000000","message":"Topic set to bug/1853159","accounts_in_message":[],"_revision_number":3},{"id":"edc97e0a715478935fa0254d983ff9bbd43b9877","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-30 05:13:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/4f6f796b296f4593993ce34cb3c1b3e9 : SUCCESS in 1h 11m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/479ee4bc46f1437ea5d4b1421adc8ad3 : SUCCESS in 17m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f4a1271be8964afb8579d687e73a4f7d : SUCCESS in 14m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee638e65c7794bb492bc09b85af83c92 : SUCCESS in 9m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/354f3c75a77e4270a37041e79fe49628 : SUCCESS in 12m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ed67a5df3e27412486de52eedbd6519d : SUCCESS in 15m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8832c7acae074f7ca1d3f724bb69f445 : SUCCESS in 11m 50s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/0b534bcb478046ad9467beedd3e4d98d : SUCCESS in 1h 12m 46s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f40ddcb0ca7748c1831811a66b15c726 : SUCCESS in 1h 11m 06s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/0285037cd29a4e95aa316ac334fc71ad : SUCCESS in 51m 10s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/74d7712a6d78434c98c5d9c254e59aaf : SUCCESS in 1h 18m 11s\n- nova-next https://zuul.opendev.org/t/openstack/build/913336665f5c4048bf3fcfc04000d559 : SUCCESS in 1h 17m 21s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/a87db74e44f6444d8f82cc5c7efdd702 : FAILURE in 7m 13s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2f21b0efd638478f95a32d4381803eeb : SUCCESS in 16m 46s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/bae0c94d921241218b8252546e6c200c : SUCCESS in 1h 05m 31s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/311bfee0fc0844c0bf2d20fe3b5c2ae9 : SUCCESS in 52m 21s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6d27862c7e7f40bd9099f6e4b19e1b0b : SUCCESS in 49m 55s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a1ead6014f604f7f861ce310ba1ee3ba : SUCCESS in 27m 56s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/dc22d7f9596f4ff78f18895469228db2 : SUCCESS in 36m 59s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4d8308ff25f53daba1600609404f17cff4c9840f","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-09-30 06:42:28.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/811814/3/iscsi : SUCCESS in 2h 43m 30s","accounts_in_message":[],"_revision_number":3},{"id":"5eb8a230da4d6140623263d93f4069e0422329d5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-12-20 16:03:19.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8f1160c77618ec2508cc02d6dbfe4e10d74ff9ac","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:57:19.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b1331d0bed7a414591a389f5eca8700fe2fec136","revisions":{"63b0a629c63c42a0220475a8392c3ede132762c8":{"kind":"REWORK","_number":1,"created":"2021-09-30 00:29:44.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/14/811814/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/811814/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/811814/1"}}},"commit":{"parents":[{"commit":"1e9d2979542165598b61f0d2e16b65b37b9ea074","subject":"Prevent deletion of a compute node belonging to another host","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e9d2979542165598b61f0d2e16b65b37b9ea074"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-11-20 12:01:33.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-09-30 00:28:57.000000000","tz":0},"subject":"Fix inactive session error in compute node creation","message":"Fix inactive session error in compute node creation\n\nIn the fix for bug 1839560 [1][2], soft-deleted compute nodes may be\nrestored, to ensure we can reuse ironic node UUIDs as compute node\nUUIDs. While this seems to largely work, it results in some nasty errors\nbeing generated [3]:\n\n    InvalidRequestError This session is in \u0027inactive\u0027 state, due to the\n    SQL transaction being rolled back; no further SQL can be emitted\n    within this transaction.\n\nThis happens because compute_node_create is decorated with\npick_context_manager_writer, which begins a transaction. While\n_compute_node_get_and_update_deleted claims that calling a second\npick_context_manager_writer decorated function will begin a new\nsubtransaction, this does not appear to be the case.\n\nThis change removes pick_context_manager_writer from the\ncompute_node_create function, and adds a new _compute_node_create\nfunction which ensures the transaction is finished if\n_compute_node_get_and_update_deleted is called.\n\nThe new unit test added here fails without this change.\n\nThis change marks the removal of the final FIXME from the functional\ntest added in [4].\n\n[1] https://bugs.launchpad.net/nova/+bug/1839560\n[2] https://git.openstack.org/cgit/openstack/nova/commit/?id\u003d89dd74ac7f1028daadf86cb18948e27fe9d1d411\n[3] http://paste.openstack.org/show/786350/\n[4] https://review.opendev.org/#/c/695012/\n\nChange-Id: Iae119ea8776bc7f2e5dbe2e502a743217beded73\nCloses-Bug: #1853159\nRelated-Bug: #1853009\n(cherry picked from commit 2383cbb4a518821d245fce316b3778c8ba8e5246)\n(cherry picked from commit 5d2edde796d8639556aafebd6f0198d2bc791bd7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/63b0a629c63c42a0220475a8392c3ede132762c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/63b0a629c63c42a0220475a8392c3ede132762c8"}]},"branch":"refs/heads/stable/victoria"},"ddaa8215d2f2151f5d6d3d2946b87fb93d6f0a98":{"kind":"REWORK","_number":2,"created":"2021-09-30 01:44:37.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/14/811814/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/811814/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/811814/2"}}},"commit":{"parents":[{"commit":"8f825c303355fbd652b87b0720942f57ff1675bb","subject":"Prevent deletion of a compute node belonging to another host","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8f825c303355fbd652b87b0720942f57ff1675bb"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-11-20 12:01:33.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-09-30 01:44:04.000000000","tz":0},"subject":"Fix inactive session error in compute node creation","message":"Fix inactive session error in compute node creation\n\nIn the fix for bug 1839560 [1][2], soft-deleted compute nodes may be\nrestored, to ensure we can reuse ironic node UUIDs as compute node\nUUIDs. While this seems to largely work, it results in some nasty errors\nbeing generated [3]:\n\n    InvalidRequestError This session is in \u0027inactive\u0027 state, due to the\n    SQL transaction being rolled back; no further SQL can be emitted\n    within this transaction.\n\nThis happens because compute_node_create is decorated with\npick_context_manager_writer, which begins a transaction. While\n_compute_node_get_and_update_deleted claims that calling a second\npick_context_manager_writer decorated function will begin a new\nsubtransaction, this does not appear to be the case.\n\nThis change removes pick_context_manager_writer from the\ncompute_node_create function, and adds a new _compute_node_create\nfunction which ensures the transaction is finished if\n_compute_node_get_and_update_deleted is called.\n\nThe new unit test added here fails without this change.\n\nThis change marks the removal of the final FIXME from the functional\ntest added in [4].\n\n[1] https://bugs.launchpad.net/nova/+bug/1839560\n[2] https://git.openstack.org/cgit/openstack/nova/commit/?id\u003d89dd74ac7f1028daadf86cb18948e27fe9d1d411\n[3] http://paste.openstack.org/show/786350/\n[4] https://review.opendev.org/#/c/695012/\n\nChange-Id: Iae119ea8776bc7f2e5dbe2e502a743217beded73\nCloses-Bug: #1853159\nRelated-Bug: #1853009\n(cherry picked from commit 2383cbb4a518821d245fce316b3778c8ba8e5246)\n(cherry picked from commit 665c053315439e1345aa131f4839945d662fb3f3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ddaa8215d2f2151f5d6d3d2946b87fb93d6f0a98"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ddaa8215d2f2151f5d6d3d2946b87fb93d6f0a98"}]},"branch":"refs/heads/stable/victoria"},"b1331d0bed7a414591a389f5eca8700fe2fec136":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-09-30 03:53:17.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/14/811814/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/811814/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/811814/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/811814/3"}}},"commit":{"parents":[{"commit":"737a4ccd1398a5cf28a67547f226b668f246c784","subject":"Prevent deletion of a compute node belonging to another host","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/737a4ccd1398a5cf28a67547f226b668f246c784"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2019-11-20 12:01:33.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-09-30 03:52:24.000000000","tz":0},"subject":"Fix inactive session error in compute node creation","message":"Fix inactive session error in compute node creation\n\nIn the fix for bug 1839560 [1][2], soft-deleted compute nodes may be\nrestored, to ensure we can reuse ironic node UUIDs as compute node\nUUIDs. While this seems to largely work, it results in some nasty errors\nbeing generated [3]:\n\n    InvalidRequestError This session is in \u0027inactive\u0027 state, due to the\n    SQL transaction being rolled back; no further SQL can be emitted\n    within this transaction.\n\nThis happens because compute_node_create is decorated with\npick_context_manager_writer, which begins a transaction. While\n_compute_node_get_and_update_deleted claims that calling a second\npick_context_manager_writer decorated function will begin a new\nsubtransaction, this does not appear to be the case.\n\nThis change removes pick_context_manager_writer from the\ncompute_node_create function, and adds a new _compute_node_create\nfunction which ensures the transaction is finished if\n_compute_node_get_and_update_deleted is called.\n\nThe new unit test added here fails without this change.\n\nThis change marks the removal of the final FIXME from the functional\ntest added in [4].\n\n[1] https://bugs.launchpad.net/nova/+bug/1839560\n[2] https://git.openstack.org/cgit/openstack/nova/commit/?id\u003d89dd74ac7f1028daadf86cb18948e27fe9d1d411\n[3] http://paste.openstack.org/show/786350/\n[4] https://review.opendev.org/#/c/695012/\n\nChange-Id: Iae119ea8776bc7f2e5dbe2e502a743217beded73\nCloses-Bug: #1853159\nRelated-Bug: #1853009\n(cherry picked from commit 2383cbb4a518821d245fce316b3778c8ba8e5246)\n(cherry picked from commit 665c053315439e1345aa131f4839945d662fb3f3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b1331d0bed7a414591a389f5eca8700fe2fec136"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b1331d0bed7a414591a389f5eca8700fe2fec136"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}