)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"288baf2f543e4123a338877f5c9b8c7fa4bddf65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a357e89b_8e4b6384","updated":"2022-01-05 17:41:25.000000000","message":"lgtm, one comment for keystone auth NotFound.","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43cf0375db404299d870171c8694dfb3cacb7567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b68c74ed_325f1645","updated":"2022-01-10 23:37:59.000000000","message":"lgtm.","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"09c2977521f6fd04135eef5657a47b75e599c8ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30956a42_1e3e8757","updated":"2022-01-17 09:55:09.000000000","message":"recheck","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e036259a2b0bbeadc280ffb21e00b7cb98407fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4491f52d_4a0f75c1","updated":"2022-01-21 11:12:39.000000000","message":"recheck","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d3a8bc43e29662f42bf3456590611ebbd97fbb4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c308fee9_ebb6c482","updated":"2022-01-24 16:14:32.000000000","message":"recheck","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"}],"nova/virt/block_device.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"288baf2f543e4123a338877f5c9b8c7fa4bddf65","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        else:"},{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                volume_api.attachment_delete(context, self[\u0027attachment_id\u0027])"},{"line_number":455,"context_line":"            except exception.VolumeAttachmentNotFound:"},{"line_number":456,"context_line":"                LOG.info("},{"line_number":457,"context_line":"                    \"Ignoring a volume attachment deletion failure as the \""},{"line_number":458,"context_line":"                    \"volume %(volume_id)s or the volume attachment \""}],"source_content_type":"text/x-python","patch_set":2,"id":"cb9c0cc1_3d83a72b","line":455,"range":{"start_line":455,"start_character":0,"end_line":455,"end_character":54},"updated":"2022-01-05 17:41:25.000000000","message":"Ignoring the cinder NotFound case lgtm but VolumeAttachmentNotFound can be raised from keystone auth side also which means in keystone auth NotFound case, volume|attachment is not deleted from cinder side so we should raise error instead of ignore it. \n\n- https://github.com/openstack/nova/blob/0e0196d979cf1b8e63b9656358116a36f1f09ede/nova/volume/cinder.py#L450\n\nMay be  need to split both keystone and cinder NotFound from ^^ and ignore cinder one only ?","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43cf0375db404299d870171c8694dfb3cacb7567","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        else:"},{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                volume_api.attachment_delete(context, self[\u0027attachment_id\u0027])"},{"line_number":455,"context_line":"            except exception.VolumeAttachmentNotFound:"},{"line_number":456,"context_line":"                LOG.info("},{"line_number":457,"context_line":"                    \"Ignoring a volume attachment deletion failure as the \""},{"line_number":458,"context_line":"                    \"volume %(volume_id)s or the volume attachment \""}],"source_content_type":"text/x-python","patch_set":2,"id":"d19715a0_7eb17e74","line":455,"range":{"start_line":455,"start_character":0,"end_line":455,"end_character":54},"in_reply_to":"a2f86bac_f94bfe8e","updated":"2022-01-10 23:37:59.000000000","message":"sure. agree on keystone 404 is rare at this point.","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"371626159496f2e6c4ed6be3e7d7df636386b0f2","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        else:"},{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                volume_api.attachment_delete(context, self[\u0027attachment_id\u0027])"},{"line_number":455,"context_line":"            except exception.VolumeAttachmentNotFound:"},{"line_number":456,"context_line":"                LOG.info("},{"line_number":457,"context_line":"                    \"Ignoring a volume attachment deletion failure as the \""},{"line_number":458,"context_line":"                    \"volume %(volume_id)s or the volume attachment \""}],"source_content_type":"text/x-python","patch_set":2,"id":"a2f86bac_f94bfe8e","line":455,"range":{"start_line":455,"start_character":0,"end_line":455,"end_character":54},"in_reply_to":"cb9c0cc1_3d83a72b","updated":"2022-01-06 09:51:21.000000000","message":"Gah that\u0027s horrid, yes that should be broken up in a follow up but I think we can still ignore it in this case for now. We\u0027ve already made several calls to Keystone and Cinder at this point so a NotFound exception from Keystone here is likely to be transient.","commit_id":"067cd93424ea1e62c77744986a5479d1b99b0ffe"}]}