)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"306e5f5269d979379e9d0825201abe221d2d9941","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee27188c_73231a62","updated":"2021-10-22 13:37:47.000000000","message":"recheck","commit_id":"705e3f82a95bdf6c1a3be09fdc45b07ffb38e848"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9932fb157d8e58282a81e245187f099b9af02fdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"792ec8ce_abb54013","updated":"2021-11-04 17:10:00.000000000","message":"thanks for the reno","commit_id":"2b02b66bae7fba5103839e48bc4c48bb30cffead"}],"doc/notification_samples/common_payloads/InstanceExistsPayload.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"243a2f3e58ec4e1b400d04c87024f52ceba4dcc8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    },"},{"line_number":6,"context_line":"    \"nova_object.name\":\"InstanceExistsPayload\","},{"line_number":7,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":8,"context_line":"    \"nova_object.version\":\"2.0\""},{"line_number":9,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"71e25f13_cba820c1","line":8,"updated":"2021-10-25 13:42:55.000000000","message":"We need to signal this to the consumers of the versioned notifications somehow. Did we published a release notes deprecating the bandwidth field in previous releases? If yes then what we need here is a reno that tells the user that the field is now removed. If we forgot to send the deprecation message in a past release then we cannot remove it as it will break the clients and they cannot opt into an older version.","commit_id":"705e3f82a95bdf6c1a3be09fdc45b07ffb38e848"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45fd6adfa2cddd15e7bca7a5cd37300325b70db4","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    },"},{"line_number":6,"context_line":"    \"nova_object.name\":\"InstanceExistsPayload\","},{"line_number":7,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":8,"context_line":"    \"nova_object.version\":\"2.0\""},{"line_number":9,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"9fbd5994_20e6c9e0","line":8,"in_reply_to":"71e25f13_cba820c1","updated":"2021-11-03 17:24:35.000000000","message":"Under normal circumstances, I\u0027d be inclined to agree. However, this is field that has never contained any useful information for users on non-XenAPI-based deployments. Unless there are API consumers that strictly enforce the fields they receive via these events (in which case, bad API consumer [1]), then I think we\u0027ll be okay.\n\nWould it be sufficient for me to add a release note documenting this removal and improve our contributor docs to make sure we don\u0027t miss this again in the future? I\u0027m pretty sure there are other fields that we emit via notifications (particularly where these mirror existing o.vos) which are deprecated and will (hopefully) be eventually removed.\n\nAlso, to be clear, if you\u0027re aware of consumers in Ericsson that would break with this change (I think you consume versioned notifications?) then obviously say so 😄\n\n[1] https://en.wikipedia.org/wiki/Robustness_principle","commit_id":"705e3f82a95bdf6c1a3be09fdc45b07ffb38e848"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9932fb157d8e58282a81e245187f099b9af02fdd","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    },"},{"line_number":6,"context_line":"    \"nova_object.name\":\"InstanceExistsPayload\","},{"line_number":7,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":8,"context_line":"    \"nova_object.version\":\"2.0\""},{"line_number":9,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"57146fc1_d9e7c907","line":8,"in_reply_to":"9fbd5994_20e6c9e0","updated":"2021-11-04 17:10:00.000000000","message":"OK. Lets have a reno (as you provided in ps3). I agree that this is an unusual case where the only source of information for this field was already removed. In general we would need a proper deprecation period for such notification change, but we basically had the deprecation cycle when we deprecated the xenapi driver.","commit_id":"705e3f82a95bdf6c1a3be09fdc45b07ffb38e848"}]}