)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1cc32cff9d2bfaf87e26a232fa5b437ac6240ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99dc2683_f0a98abe","updated":"2021-10-19 13:47:44.000000000","message":"Thanks!\n\n(Hoping CI passes and I don\u0027t look bad +1","commit_id":"2c7871525ab5326842b1de7d539b221998ece90c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"eae46e77b713bc410de029289e2d4d867b60528c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f701455f_71067a9a","in_reply_to":"99dc2683_f0a98abe","updated":"2021-10-19 13:48:42.000000000","message":"Doh, left that in. CI will fail - I ran the new test manually with `tox -e py38 test_unshelve_spawn_fails_cleanup_instance_image_ref`. See inline L#702.","commit_id":"2c7871525ab5326842b1de7d539b221998ece90c"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"02a6948ae1209c7d8c9d202edd88f249b1d6665d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33ee7d69_62a7b367","in_reply_to":"f701455f_71067a9a","updated":"2021-10-20 13:07:14.000000000","message":"Ack","commit_id":"2c7871525ab5326842b1de7d539b221998ece90c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2a859e8c461aaede34b7e7bc7bf29d5e5228cc49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a04c84b8_b362c29b","updated":"2021-10-21 00:01:39.000000000","message":"This might be the first time I have seen a reproducer unit test (vs a reproducer functional test). Test looks good and concisely demonstrates the bug.","commit_id":"78e10f5f14a018fd1d96ea242923631459acb62c"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"a23dad3197b37da2657f36d60b05b5a307267477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b8567ada_3f88d14c","in_reply_to":"a04c84b8_b362c29b","updated":"2021-10-21 07:19:17.000000000","message":"Thanks to Artom who points me in the right direction ;-)","commit_id":"78e10f5f14a018fd1d96ea242923631459acb62c"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7e523e9819b519099ec6045372942159c5c87528","unresolved":true,"context_lines":[{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    @mock.patch.object(neutron_api.API, \u0027setup_instance_network_on_host\u0027,"},{"line_number":681,"context_line":"            side_effect\u003dtest.TestingException(\u0027Network setup fail\u0027))"},{"line_number":682,"context_line":"    def test_unshelve_spawn_fails_cleanup_instance_image_ref("},{"line_number":683,"context_line":"            self, mock_setup_network):"},{"line_number":684,"context_line":"        \"\"\"Tests error handling when a instance fails to unshelve and makes"},{"line_number":685,"context_line":"        sure to revert instance.image_ref to the initial value instead of"}],"source_content_type":"text/x-python","patch_set":3,"id":"080f845a_718a5b32","line":682,"updated":"2021-10-07 13:49:55.000000000","message":"Small nit: you\u0027re naming the test \"spawn_fails\", but the mock exception is in setup_instance_network_on_host(). Ideally these two would be aligned - I know the effect is the same (we end up in the Except block on L6682 in the compute manager), but if we\u0027re naming the test \"spawn_fails\", then mock driver.spawn() to fail :)","commit_id":"0c2af7881b6ef41d9248aab2e7587b35896500be"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1cc32cff9d2bfaf87e26a232fa5b437ac6240ce0","unresolved":true,"context_lines":[{"line_number":691,"context_line":"        image \u003d {\u0027id\u0027: uuids.image_id}"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        with mock.patch.object(self.compute.driver, \u0027spawn\u0027) as mock_spawn:"},{"line_number":694,"context_line":"            mock_spawn.side_effect \u003d test.TestingException(\u0027Spawn failed\u0027)"},{"line_number":695,"context_line":"            self.assertRaises(test.TestingException,"},{"line_number":696,"context_line":"                    self.compute.unshelve_instance, self.context, instance, image\u003dimage,"},{"line_number":697,"context_line":"                    filter_properties\u003d{}, node\u003d\u0027fake-node\u0027, request_spec\u003dfake_spec,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f578ef3_d54c0dc0","line":694,"updated":"2021-10-19 13:47:44.000000000","message":"nit: you can inline the side_effect into the mock.patch.object call","commit_id":"2c7871525ab5326842b1de7d539b221998ece90c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1cc32cff9d2bfaf87e26a232fa5b437ac6240ce0","unresolved":true,"context_lines":[{"line_number":699,"context_line":"        # FIXME(pslestang) Until bug 1934094 is fixed"},{"line_number":700,"context_line":"        # The instance.image_ref is set to shelved_image.id but should be"},{"line_number":701,"context_line":"        # equal to initial_image_ref"},{"line_number":702,"context_line":"        self.assertEqual(instance.image_ref, shelved_image[\u0027id\u0027])"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_filters\u0027)"},{"line_number":705,"context_line":"    def test_shelved_poll_none_offloaded(self, mock_get_by_filters):"}],"source_content_type":"text/x-python","patch_set":4,"id":"81c7af85_d7b116b7","line":702,"range":{"start_line":702,"start_character":45,"end_line":702,"end_character":58},"updated":"2021-10-19 13:47:44.000000000","message":"This variable is not defined.","commit_id":"2c7871525ab5326842b1de7d539b221998ece90c"}]}