)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"2f582dca00abd70b0b27c0bcbf9132d0892acfb3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     pengzhang \u003cpeng.zhang@corigine.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-08 07:43:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"the vif_name error leads virsh domifstat cant work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Netronome SmartNIC Enablement"},{"line_number":10,"context_line":"As far the vif_name is tapxxx, it dont match the target port name. The external ML2 plugin"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e6c765b7_aad92894","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2021-10-08 14:03:35.000000000","message":"Commit message is not very detailed and amount of characters in each line is too big (complicates reading).\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"b034de3884bf607bb4d2e2d98a786cddf48efa83"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"2f582dca00abd70b0b27c0bcbf9132d0892acfb3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"dont send the devname, so i change the vif_name to  the nic vfr_name. It can set the correct"},{"line_number":12,"context_line":"target port name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes BUG1945586"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: peng zhang \u003cpeng.zhang@corigine.com\u003e"},{"line_number":17,"context_line":"Change-Id: I843fe5d8e6ae4d4710a2fb197bd9bafd80dcc5e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fb04bc12_a86031ea","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":16},"updated":"2021-10-08 14:03:35.000000000","message":"Correct syntax is \"Closes-Bug: #1234567\"","commit_id":"b034de3884bf607bb4d2e2d98a786cddf48efa83"},{"author":{"_account_id":34070,"name":"pengzhang","email":"peng.zhang@corigine.com","username":"muzp7"},"change_message_id":"39b3f54eb3eb3a5ee74a442f4f476f0bb6d9eed4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"dont send the devname, so i change the vif_name to  the nic vfr_name. It can set the correct"},{"line_number":12,"context_line":"target port name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes BUG1945586"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: peng zhang \u003cpeng.zhang@corigine.com\u003e"},{"line_number":17,"context_line":"Change-Id: I843fe5d8e6ae4d4710a2fb197bd9bafd80dcc5e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ee49dd09_5f314924","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":16},"in_reply_to":"fb04bc12_a86031ea","updated":"2021-10-09 03:37:54.000000000","message":"ok, thanks , I will read the doc and make a commit as per the specification, I am very sorry for this error . thanks for your help again.","commit_id":"b034de3884bf607bb4d2e2d98a786cddf48efa83"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"2f582dca00abd70b0b27c0bcbf9132d0892acfb3","unresolved":true,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"# VIF_TYPE_AGILIO_OVS \u003d \u0027agilio_ovs\u0027"},{"line_number":364,"context_line":"def _nova_to_osvif_vif_agilio_ovs(vif):"},{"line_number":365,"context_line":"    pci_slot \u003d vif[\"profile\"][\"pci_slot\"]"},{"line_number":366,"context_line":"    vf_num \u003d os_vif_linux_net.get_vf_num_by_pci_address(pci_slot)"},{"line_number":367,"context_line":"    pf_ifname \u003d os_vif_linux_net.get_ifname_by_pci_address("},{"line_number":368,"context_line":"              pci_slot, pf_interface\u003dTrue, switchdev\u003dTrue)"},{"line_number":369,"context_line":"    vif_name \u003d os_vif_linux_net.get_representor_port(pf_ifname, vf_num)"},{"line_number":370,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":371,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT:"},{"line_number":372,"context_line":"        obj \u003d _get_vnic_direct_vif_instance("}],"source_content_type":"text/x-python","patch_set":2,"id":"f46dd3a4_85791b3f","line":369,"range":{"start_line":365,"start_character":0,"end_line":369,"end_character":71},"updated":"2021-10-08 14:03:35.000000000","message":"It is unreasonable to run this operations every time while we need them only if \" vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT\". It could make sense to use separate function which would be called when we need to calculate vif_name.","commit_id":"b034de3884bf607bb4d2e2d98a786cddf48efa83"}]}
