)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30498,"name":"weisongf","email":"songwei-8@163.com","username":"NealSong"},"change_message_id":"b33e12f2a5b3bd1ed6be89d2a8d307f49eeb7081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9a92b65_8f17dea7","updated":"2021-10-12 07:00:47.000000000","message":"Failure to time out causes virtual machines to become unavailable, affecting business","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58741f60_3b0cb766","updated":"2021-11-08 12:34:25.000000000","message":"nits and this needs a releasenote for the newly introduced configurable.\n\nI\u0027d also like to see this passing in CI somewhere to ensure the timeout isn\u0027t too low.","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"}],"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":true,"context_lines":[{"line_number":10693,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":10694,"context_line":"        self.driver.quiesce(context, instance, image_meta)"},{"line_number":10695,"context_line":""},{"line_number":10696,"context_line":"    def _wait_for_snapshots_completion(self, context, mapping):"},{"line_number":10697,"context_line":"        for mapping_dict in mapping:"},{"line_number":10698,"context_line":"            if mapping_dict.get(\u0027source_type\u0027) \u003d\u003d \u0027snapshot\u0027:"},{"line_number":10699,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"97c44133_7270f741","line":10696,"range":{"start_line":10696,"start_character":8,"end_line":10696,"end_character":38},"updated":"2021-11-08 12:34:25.000000000","message":"_wait_for_volume_snapshots_completion","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":true,"context_lines":[{"line_number":10718,"context_line":"    def unquiesce_instance(self, context, instance, mapping\u003dNone):"},{"line_number":10719,"context_line":"        \"\"\"Unquiesce an instance on this host."},{"line_number":10720,"context_line":""},{"line_number":10721,"context_line":"        If snapshots\u0027 image mapping is provided, it waits until snapshots are"},{"line_number":10722,"context_line":"        completed before unqueiscing."},{"line_number":10723,"context_line":"        \"\"\""},{"line_number":10724,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a88ce7b_c4db305d","line":10721,"range":{"start_line":10721,"start_character":64,"end_line":10721,"end_character":73},"updated":"2021-11-08 12:34:25.000000000","message":"volume snapshots","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":true,"context_lines":[{"line_number":10721,"context_line":"        If snapshots\u0027 image mapping is provided, it waits until snapshots are"},{"line_number":10722,"context_line":"        completed before unqueiscing."},{"line_number":10723,"context_line":"        \"\"\""},{"line_number":10724,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":10725,"context_line":"        try:"},{"line_number":10726,"context_line":"            context \u003d context.elevated()"},{"line_number":10727,"context_line":"            if mapping:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8418e57_5cf8fa79","line":10724,"range":{"start_line":10724,"start_character":8,"end_line":10724,"end_character":62},"updated":"2021-11-08 12:34:25.000000000","message":"nit - I\u0027d move this into the finally block as we don\u0027t need it while waiting.","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"}],"nova/conf/compute.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"* A positive integer or 0 (default value is 60)."},{"line_number":1323,"context_line":"\"\"\"),"},{"line_number":1324,"context_line":"    cfg.IntOpt(\u0027timeout_before_unquiesce\u0027,"},{"line_number":1325,"context_line":"               default\u003d60,"},{"line_number":1326,"context_line":"               help\u003d\"Timeout for waiting a snapshot ready to use before \""},{"line_number":1327,"context_line":"                    \"unquiescing an instance\")"},{"line_number":1328,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5438e98_6c4352ec","line":1325,"range":{"start_line":1325,"start_character":23,"end_line":1325,"end_character":25},"updated":"2021-11-08 12:34:25.000000000","message":"I wonder if this is going to be too low for CI but lets see.","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3fa7611b3c57511c095b7db5a03a661ea282fe22","unresolved":true,"context_lines":[{"line_number":1323,"context_line":"\"\"\"),"},{"line_number":1324,"context_line":"    cfg.IntOpt(\u0027timeout_before_unquiesce\u0027,"},{"line_number":1325,"context_line":"               default\u003d60,"},{"line_number":1326,"context_line":"               help\u003d\"Timeout for waiting a snapshot ready to use before \""},{"line_number":1327,"context_line":"                    \"unquiescing an instance\")"},{"line_number":1328,"context_line":"]"},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"running_deleted_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"4a0eed0f_b6784df9","line":1327,"range":{"start_line":1326,"start_character":0,"end_line":1327,"end_character":46},"updated":"2021-11-08 12:34:25.000000000","message":"nit - format this the same as the other options with \"\"\" etc.","commit_id":"2da9a20d09af4812a81f4760bf8366662ec50b82"}]}