)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"cc9f4317fc184cb584716dd18f9c6b6e63653875","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77cc802e_0b776cb5","updated":"2021-10-13 13:18:17.000000000","message":"Please check if my comment makes sense to you.","commit_id":"690891dd60fa1dabdff3f3581ec08390a7b328ab"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"832ae4b17af817db7c82ec4bae185ab59da6388e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea464172_81af05f5","updated":"2021-11-03 13:02:17.000000000","message":"LGTM","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"af04b841b3bf0726c3eb83d4489fa97c35605887","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ac0aacf_7bdebfaa","updated":"2021-10-19 17:48:12.000000000","message":"Thank you!","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"45af38c81f131512f0ff4bbed7ec9f647909960b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ad4474f_f45fc8cb","updated":"2022-01-17 10:39:20.000000000","message":"recheck","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"a9956930de16a85a9d2451ea590bf09fd001fdf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fe26f59_e2615fdd","updated":"2022-01-15 09:51:55.000000000","message":"recheck","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"ec3f5ba8aa9e8b7215b3aa4bd56451eef824e06f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6571d4ed_2ace684c","updated":"2022-01-17 08:46:46.000000000","message":"recheck","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"0fc7331f4032fcece4a131eea402faa4c990dce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c38e73f3_45e0f7a0","in_reply_to":"ea464172_81af05f5","updated":"2021-11-05 09:59:56.000000000","message":"Could we merge this then?","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"}],"doc/source/contributor/microversions.rst":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"cc9f4317fc184cb584716dd18f9c6b6e63653875","unresolved":true,"context_lines":[{"line_number":378,"context_line":"  ``nova/tests/functional/api_sample_tests``. Also, add JSON examples to"},{"line_number":379,"context_line":"  ``doc/api_samples`` directory which can be generated automatically via tox"},{"line_number":380,"context_line":"  env ``api-samples`` or run test with env var ``GENERATE_SAMPLES`` True."},{"line_number":381,"context_line":"  Ensure that the folder for the new microversion (``doc/api_samples/*/vX.Y``)"},{"line_number":382,"context_line":"  is created beforehand."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"* Update the `API Reference`_ documentation as appropriate.  The source is"},{"line_number":385,"context_line":"  located under `api-ref/source/`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"538784a6_67dd0a8f","line":382,"range":{"start_line":381,"start_character":0,"end_line":382,"end_character":24},"updated":"2021-10-13 13:18:17.000000000","message":"IMO we need to either change related statement in [1] and re-direct users to this document because process is not completely automatic (check the second sentence from [1]) OR tune the automation to create appropriate folder if it is not there.\n\n[1]\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/README.rst","commit_id":"690891dd60fa1dabdff3f3581ec08390a7b328ab"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"f9379f94296caf109a0f2c5ac916ff5f08dc32a3","unresolved":true,"context_lines":[{"line_number":378,"context_line":"  ``nova/tests/functional/api_sample_tests``. Also, add JSON examples to"},{"line_number":379,"context_line":"  ``doc/api_samples`` directory which can be generated automatically via tox"},{"line_number":380,"context_line":"  env ``api-samples`` or run test with env var ``GENERATE_SAMPLES`` True."},{"line_number":381,"context_line":"  Ensure that the folder for the new microversion (``doc/api_samples/*/vX.Y``)"},{"line_number":382,"context_line":"  is created beforehand."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"* Update the `API Reference`_ documentation as appropriate.  The source is"},{"line_number":385,"context_line":"  located under `api-ref/source/`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f75c9bff_b075dd00","line":382,"range":{"start_line":381,"start_character":0,"end_line":382,"end_character":24},"in_reply_to":"538784a6_67dd0a8f","updated":"2021-10-19 17:37:49.000000000","message":"That makes sense.\nI think the best solution is to check whether the folder exists.\n\nI\u0027ve updated the patch set accordingly.","commit_id":"690891dd60fa1dabdff3f3581ec08390a7b328ab"}],"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ae57b58a95201f2e567630dffa2e28557e0dd59","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    def _write_sample(self, name, data):"},{"line_number":138,"context_line":"        sample_file \u003d self._get_sample(name, self.microversion)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        os.makedirs(os.path.dirname(sample_file), exist_ok \u003d True)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        with open(sample_file, \u0027w\u0027) as outf:"},{"line_number":143,"context_line":"            outf.write(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"91ab5f06_fc4778ff","line":140,"range":{"start_line":140,"start_character":58,"end_line":140,"end_character":61},"updated":"2022-01-14 18:15:39.000000000","message":"Weird that flake8 didn\u0027t fail on this. If that\u0027s happy though...","commit_id":"6c5636baab934c9c404810a6ba2e7aed35ad2657"}]}
