)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00a0b0daef1813ef6f78f4ca153bc06f6ad84eb3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  \"[\u0027tag1\u0027, \u0027tag2\u0027, \u0027tag3\u0027]\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This results in a failure to match any tags when python-openstackclient"},{"line_number":20,"context_line":"or python-novaclient are used to list servers filtered by tags because"},{"line_number":21,"context_line":"the tags are not parsed out from the query parameter value."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c6c51fbd_22f028da","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":71},"updated":"2021-10-13 09:12:30.000000000","message":"fwiw, this is because this command in OSC is currently using the novaclient library under the hood, so it\u0027s simply novaclient that\u0027s wrong (though perhaps SDK is too - I haven\u0027t checked)","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5b9850baf6637ea6e7f50bfc332acb71117081f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  \"[\u0027tag1\u0027, \u0027tag2\u0027, \u0027tag3\u0027]\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This results in a failure to match any tags when python-openstackclient"},{"line_number":20,"context_line":"or python-novaclient are used to list servers filtered by tags because"},{"line_number":21,"context_line":"the tags are not parsed out from the query parameter value."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d933ea00_405adf9e","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":71},"in_reply_to":"24b79bdc_62969a50","updated":"2021-10-13 16:21:51.000000000","message":"You are right ... I got this all messed up by misreading the api-ref. Thanks for catching it.","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"984e64e024fab2fa80715b8f8e15d3f4a4abd57e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  \"[\u0027tag1\u0027, \u0027tag2\u0027, \u0027tag3\u0027]\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This results in a failure to match any tags when python-openstackclient"},{"line_number":20,"context_line":"or python-novaclient are used to list servers filtered by tags because"},{"line_number":21,"context_line":"the tags are not parsed out from the query parameter value."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"24b79bdc_62969a50","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":71},"in_reply_to":"9fa26e2b_a3002d28","updated":"2021-10-13 09:59:07.000000000","message":"Also, novaclient actually works just fine [*]:\n\n  $ openstack --os-compute-api-version 2.79 server set --tag foo alpine-998-server\n  $ openstack --os-compute-api-version 2.79 server set --tag bar alpine-998-server\n  $ nova list --tags foo\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  | ID                                   | Name              | Status | Task State | Power State | Networks |\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  | ff13259b-ee8e-403f-81d1-0648e4958731 | alpine-998-server | ACTIVE | -          | Running     |          |\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  $ nova list --tags foo,bar\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  | ID                                   | Name              | Status | Task State | Power State | Networks |\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  | ff13259b-ee8e-403f-81d1-0648e4958731 | alpine-998-server | ACTIVE | -          | Running     |          |\n  +--------------------------------------+-------------------+--------+------------+-------------+----------+\n  $ nova list --tags foo,baz\n  +----+------+--------+------------+-------------+----------+\n  | ID | Name | Status | Task State | Power State | Networks |\n  +----+------+--------+------------+-------------+----------+\n  +----+------+--------+------------+-------------+----------+\n  $ nova --version\n  17.6.0\n\n[*] ...if you can excuse the janky option handling. IMO, to specify multiple values for an option, you should be able to use \u0027--option value --option value2 ...\u0027, so \u0027--tag foo --tag bar\u0027. However, all (?) novaclient commands expect a single option with multiple encoded values, so \u0027--tags foo,bar\u0027. Eeew. Thankfully OSC did this the right way (TM) 😄","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b55978fc99bf5a19dfba202f61187a8c49afb690","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  \"[\u0027tag1\u0027, \u0027tag2\u0027, \u0027tag3\u0027]\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This results in a failure to match any tags when python-openstackclient"},{"line_number":20,"context_line":"or python-novaclient are used to list servers filtered by tags because"},{"line_number":21,"context_line":"the tags are not parsed out from the query parameter value."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fa26e2b_a3002d28","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":71},"in_reply_to":"c6c51fbd_22f028da","updated":"2021-10-13 09:31:14.000000000","message":"Wait, no, I stand corrected. OSC is building the search opts dictionary itself. I\u0027ve provided a fix here [1]\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/813789","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ff96c4650c0c629e3355c112eca3b4eecb47701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c41dcd11_baf1bbe6","updated":"2021-10-13 08:41:53.000000000","message":"-1 just to get attention. As noted, I\u0027m not sure either way\n","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff650f41436d020ec66bd499f0cf0529a767ca71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7881414b_95d9a6b1","updated":"2021-10-13 08:41:33.000000000","message":"I\u0027m conflicted on this. Isn\u0027t this really a bug in the client, as opposed to the server? Modifying the server behavior seems like a microversion-worthy change, since this doesn\u0027t fall into the class of things we\u0027re allowed to fix like HTTP 5xx errors or response codes","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5b9850baf6637ea6e7f50bfc332acb71117081f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0267d45_82ed0cd4","updated":"2021-10-13 16:21:51.000000000","message":"You are ","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1f940c0204b46ceb188072a208c958173d881292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e2be0d8_3926a743","in_reply_to":"f0267d45_82ed0cd4","updated":"2021-10-13 16:22:30.000000000","message":"Dangit.","commit_id":"3c5c65730ce5a32b269daa29483e294c9f1b8fd6"}]}