)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82e422c4_717e8e63","updated":"2022-02-02 19:42:13.000000000","message":"-1 for now\nif you want to carry on the discsion on stoage classes in a followup we can\nas the issue i raised is already present in our docs.\n\ni tought we have previously remove the confusing conflation fo volume with persitnece and non volume backed with ephemeral but i guess we have not.\n\n-1 is mainly for the fallback to project id form user id i think that is eiter an api error or hanedl by oslo not nova and vlans are not really a resouce assocaed with a project networks are.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed8e6e1fe777070c34c7f9523255800b614df15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"774da475_9e22cc1b","updated":"2022-02-01 09:54:08.000000000","message":"LGTM","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09414e6870dca7de6d1f447a55a9b511fc0b999d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d031d3f_36a826a0","updated":"2022-02-03 15:43:26.000000000","message":"you have addressed the issue i had in the follow up patch and melanies comment was addressed too so\n+2+w we can continue on the follow up ptach but im more or less happy with that too","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"}],"doc/source/admin/architecture.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed8e6e1fe777070c34c7f9523255800b614df15","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The manager also, optionally, has periodic tasks."},{"line_number":20,"context_line":"For more details on our RPC system, please see: :doc:`/reference/rpc`"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Nova also uses a central database that is (logically) shared between all"},{"line_number":23,"context_line":"components. However, to aid upgrade, the DB is accessed through an object"},{"line_number":24,"context_line":"layer that ensures an upgraded control plane can still communicate with"},{"line_number":25,"context_line":"a ``nova-compute`` running the previous release."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f251032d_38e5446e","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":33},"updated":"2022-02-01 09:54:08.000000000","message":"except in cellv2 where we sharded the DB too","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f981466b4c6ef02aa5f87fb0db9d2453c40c8bc1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The manager also, optionally, has periodic tasks."},{"line_number":20,"context_line":"For more details on our RPC system, please see: :doc:`/reference/rpc`"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Nova also uses a central database that is (logically) shared between all"},{"line_number":23,"context_line":"components. However, to aid upgrade, the DB is accessed through an object"},{"line_number":24,"context_line":"layer that ensures an upgraded control plane can still communicate with"},{"line_number":25,"context_line":"a ``nova-compute`` running the previous release."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b3300cb_0b3a3a89","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":33},"in_reply_to":"f251032d_38e5446e","updated":"2022-02-02 12:18:30.000000000","message":"Done","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Projects are isolated resource containers that form the principal"},{"line_number":112,"context_line":"organizational structure within the Nova service. They typically consist of an"},{"line_number":113,"context_line":"individual VLAN, and volumes, instances, images, keys, and users. A user can"},{"line_number":114,"context_line":"specify the project by appending ``project_id`` to their access key.  If no"},{"line_number":115,"context_line":"project is specified in the API request, Nova attempts to use a project with"},{"line_number":116,"context_line":"the same ID as the user."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4280a284_349679b1","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":15},"updated":"2022-02-02 19:42:13.000000000","message":"this sounds strange i woudl replace \"an indivigual vlan,\" with \"networks,\"\n\nin nova network it might have been true that each project was mapped to a vlan but that does not make sense any more.\ncan you adress this in your follow up patch","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d067835ba64898435f1eea5fd25678964c4f5fdf","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Projects are isolated resource containers that form the principal"},{"line_number":112,"context_line":"organizational structure within the Nova service. They typically consist of an"},{"line_number":113,"context_line":"individual VLAN, and volumes, instances, images, keys, and users. A user can"},{"line_number":114,"context_line":"specify the project by appending ``project_id`` to their access key.  If no"},{"line_number":115,"context_line":"project is specified in the API request, Nova attempts to use a project with"},{"line_number":116,"context_line":"the same ID as the user."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d8c53afe_ba1ea518","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":15},"in_reply_to":"4280a284_349679b1","updated":"2022-02-03 11:42:14.000000000","message":"Done","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":true,"context_lines":[{"line_number":113,"context_line":"individual VLAN, and volumes, instances, images, keys, and users. A user can"},{"line_number":114,"context_line":"specify the project by appending ``project_id`` to their access key.  If no"},{"line_number":115,"context_line":"project is specified in the API request, Nova attempts to use a project with"},{"line_number":116,"context_line":"the same ID as the user."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":119,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"}],"source_content_type":"text/x-rst","patch_set":1,"id":"55b13dac_76f8a127","line":116,"updated":"2022-02-02 19:42:13.000000000","message":"does it?\n\ni tought this was handeled by oslo midelware now and it did the project id resolution for us. so i dont think nova actully does this anymmore.\n\nwe still have https://github.com/openstack/nova/blob/master/nova/api/openstack/identity.py\n\nbut that assumes the project_id is passed in its no trying to figure it out form the user.\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/auth.py only provided noatugh midelware that is derived form oslo\n\nwhere do you think this fallback to the userid happens?","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d067835ba64898435f1eea5fd25678964c4f5fdf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"individual VLAN, and volumes, instances, images, keys, and users. A user can"},{"line_number":114,"context_line":"specify the project by appending ``project_id`` to their access key.  If no"},{"line_number":115,"context_line":"project is specified in the API request, Nova attempts to use a project with"},{"line_number":116,"context_line":"the same ID as the user."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":119,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a02ba63c_70c16002","line":116,"in_reply_to":"55b13dac_76f8a127","updated":"2022-02-03 11:42:14.000000000","message":"I\u0027ve no idea. tbh, I made very few changes other than some rewording to this section. I\u0027ve dropped this since it\u0027s not really relevant even if it is true (which we\u0027re not sure it is)","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09414e6870dca7de6d1f447a55a9b511fc0b999d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"individual VLAN, and volumes, instances, images, keys, and users. A user can"},{"line_number":114,"context_line":"specify the project by appending ``project_id`` to their access key.  If no"},{"line_number":115,"context_line":"project is specified in the API request, Nova attempts to use a project with"},{"line_number":116,"context_line":"the same ID as the user."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":119,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2e78524e_d28cd57b","line":116,"in_reply_to":"a02ba63c_70c16002","updated":"2022-02-03 15:43:26.000000000","message":"ack","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":true,"context_lines":[{"line_number":142,"context_line":"Block storage"},{"line_number":143,"context_line":"-------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"OpenStack provides two classes of block storage: ephemeral storage and"},{"line_number":146,"context_line":"persistent volume."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rubric:: Ephemeral storage"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6613977f_a213f5dc","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":18},"updated":"2022-02-02 19:42:13.000000000","message":"i dont agree with this by the way\n\nif we want to have only 2 classes of storage we should refer to them as volume backed and non volume backed.\n\nusing cinder volume does not give you better volume persitince or resilance then non vovlume strage take the lvm cinder backend as an exmaple or many san based soltion without internal ha.\n\nusing nvme over frabic often has no ha so if that disk dies your data is gon just as if the disk on the local storage died.\n\nwhen you use the rbd imageage backeend it has the same persitnace guarentees as a ceph cinder volume.\n\nepmeral and persitence have other implications and use ephemral to refer to root and not root disk is confusing more on that below.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09414e6870dca7de6d1f447a55a9b511fc0b999d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Block storage"},{"line_number":143,"context_line":"-------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"OpenStack provides two classes of block storage: ephemeral storage and"},{"line_number":146,"context_line":"persistent volume."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rubric:: Ephemeral storage"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ea37f013_d9bdc7ba","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":18},"in_reply_to":"6613977f_a213f5dc","updated":"2022-02-03 15:43:26.000000000","message":"Done","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rubric:: Ephemeral storage"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Ephemeral storage includes a root ephemeral volume and an additional ephemeral"},{"line_number":151,"context_line":"volume. These are provided by nova itself."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The root disk is associated with an instance, and exists only for the life of"},{"line_number":154,"context_line":"this very instance. Generally, it is used to store an instance\u0027s root file"}],"source_content_type":"text/x-rst","patch_set":1,"id":"065870bc_9adcc2ca","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":42},"updated":"2022-02-02 19:42:13.000000000","message":"no we really should not refer to the root disk as part of epmeral storage\n\nits not its tied to the lifetime of the instace yest but tha tis not what makes epmeral storage epmeral.\n\nwe should only use ephemeral to refer to the extra disk provded by flavor.epmermeral.\n\nthe root disk is its own thing. we have 3 types of storage and we should not try and group the root disk with addtioanl epmeral storage as we have very differnt guarnetees for them with regards to snapshots, evaculattion, rebuild and resize.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09414e6870dca7de6d1f447a55a9b511fc0b999d","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rubric:: Ephemeral storage"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Ephemeral storage includes a root ephemeral volume and an additional ephemeral"},{"line_number":151,"context_line":"volume. These are provided by nova itself."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The root disk is associated with an instance, and exists only for the life of"},{"line_number":154,"context_line":"this very instance. Generally, it is used to store an instance\u0027s root file"}],"source_content_type":"text/x-rst","patch_set":1,"id":"611e1083_736b6b50","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":42},"in_reply_to":"065870bc_9adcc2ca","updated":"2022-02-03 15:43:26.000000000","message":"Done","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8ad0022f5beffdd5ce9d3818a8f6bec594b9812c","unresolved":true,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Virtual hardware templates are called ``flavors``. By default, these are"},{"line_number":247,"context_line":"configurable by admin users, however, that behavior can be changed by redefining"},{"line_number":248,"context_line":"the access controls ``policy.yaml`` on the ``nova-compute`` server. For more"},{"line_number":249,"context_line":"information, refer to :doc:`/configuration/policy`."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"For a list of flavors that are available on your system:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8a9f22fe_ad24f501","line":248,"range":{"start_line":248,"start_character":45,"end_line":248,"end_character":57},"updated":"2022-02-01 21:10:04.000000000","message":"This should be nova-api, policy is not to be configured on compute hosts. Apparently in the past nova-api was sometimes called compute-api.\n\nNote: there is one legacy policy setting on compute hosts [1] that would be ideal to remove.\n\n[1] https://bugs.launchpad.net/nova/+bug/1675486","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d85872cbb2a8a620dcd6cb1eb87a326eabe7c369","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Virtual hardware templates are called ``flavors``. By default, these are"},{"line_number":247,"context_line":"configurable by admin users, however, that behavior can be changed by redefining"},{"line_number":248,"context_line":"the access controls ``policy.yaml`` on the ``nova-compute`` server. For more"},{"line_number":249,"context_line":"information, refer to :doc:`/configuration/policy`."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"For a list of flavors that are available on your system:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d5a7a4fd_53a284d5","line":248,"range":{"start_line":248,"start_character":45,"end_line":248,"end_character":57},"in_reply_to":"8a9f22fe_ad24f501","updated":"2022-02-02 12:18:17.000000000","message":"Done","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"}],"doc/source/admin/index.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc530dc82c0c90b4cf29853d36a6968a1f4cad65","unresolved":true,"context_lines":[{"line_number":103,"context_line":"  an end-user visible logical abstraction for partitioning a cloud without"},{"line_number":104,"context_line":"  knowing the physical infrastructure. They can be used to partition a cloud on"},{"line_number":105,"context_line":"  arbitrary factors, such as location (country, datacenter, rack), network"},{"line_number":106,"context_line":"  layout and/or power source."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* :placement-doc:`Placement service \u003c\u003e`: Overview of the placement"},{"line_number":109,"context_line":"  service, including how it fits in with the rest of nova."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b21d48e1_2b00738e","line":106,"updated":"2022-02-02 19:42:13.000000000","message":"can you add that AZ should not be assumed to map to fault domains and provide\nno intrinsic HA benift by them selves.\n\njust to hammer that home that openstack AZ are not amazon AZs\n\nthat also mostly ture for cells so perhaps one node to cover both would work.\n\ngiven we had to have talks on this i dont think we shoudl assume new admins know that.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d067835ba64898435f1eea5fd25678964c4f5fdf","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  an end-user visible logical abstraction for partitioning a cloud without"},{"line_number":104,"context_line":"  knowing the physical infrastructure. They can be used to partition a cloud on"},{"line_number":105,"context_line":"  arbitrary factors, such as location (country, datacenter, rack), network"},{"line_number":106,"context_line":"  layout and/or power source."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* :placement-doc:`Placement service \u003c\u003e`: Overview of the placement"},{"line_number":109,"context_line":"  service, including how it fits in with the rest of nova."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a396f71_743bd135","line":106,"in_reply_to":"b21d48e1_2b00738e","updated":"2022-02-03 11:42:14.000000000","message":"I added this but in the main AZ doc, since this is only a summary.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"}]}