)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7be6a55dc1c93c58ee46d8fc45dec23e0b8a5a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69743688_f670865c","updated":"2021-10-26 13:54:39.000000000","message":"-1 is more procedural due to the lack of a functional regression test and lack of fixes release note.\n\nat a quick glance this more or less makes sense to me i will try and finish reviewing it later.\n","commit_id":"b12d633ca49e44d9f09a4b992b0735e9d7b9c50f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"460820ea3d83a415f306a73a1d57e380bd9cc587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba11dcb1_525a8502","updated":"2021-10-26 13:39:31.000000000","message":"hum intersting i can see why this would be a problem only for sriov live migration.\n\ni need to think about this a little to make sure this is correct in all cases so ill try an review this fully later but ya sriov live migration in direct mdoe is diffent in that we will detach the VFs form the vm in live migration and would need to reattach them but if we fail in prelive migration we dont need to do that. for most or all?(i need to check that) other case we shoudl not have touched the netwoking config on the source node at all if we fail in pre-livemigration.\n\ni have started this in my dashboard and ill try to come back to it soon","commit_id":"b12d633ca49e44d9f09a4b992b0735e9d7b9c50f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fe5092d49f488db8e6f472f7e7dcb9fd9f89e67c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ebc10895_e5de6ba0","updated":"2022-02-10 14:06:18.000000000","message":"recheck","commit_id":"136a03a11942afaf92471ef0ca6340b4142c6b28"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d5076e903c7df8192d71aaa3724d079e044b382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d1fbfa1_15f3982d","updated":"2022-03-08 14:14:03.000000000","message":"could you add a fixes release note for this\n\notherwise i think im +2 on this.","commit_id":"cb410b63b665df53352d07a78851ebca7e1a0d45"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15da2ffe846810f6f3216e9ac8acc644e73d356d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ae17df71_c7eb8265","updated":"2022-03-09 14:15:34.000000000","message":"I\u0027ll +W this change once you reply.","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3d6d1aff6bf108591f2a3c1ac61f326d944961f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c01e9fc_55a2abd4","updated":"2022-03-10 14:02:31.000000000","message":"Removing my -2 as we found a bug.","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e39a47c73308b4438cf39b784649243ab5e2461b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"71ebbeea_813f74fb","updated":"2022-03-09 15:35:49.000000000","message":"Sean was already +2 and Erlon fixed some nits","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"937c1d1ca1ab03bb5471df10a4cb16a29145a595","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ce827cc6_03d9dddf","updated":"2022-03-10 12:34:56.000000000","message":"The functional test added in the parent patch and change here is unstable. See https://bugs.launchpad.net/nova/+bug/1964472 Please check the instability.","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aa11117b4b44b2c2ba264965e4efaf5cec3e702f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b4e141ff_ca061264","updated":"2022-03-10 13:15:22.000000000","message":"We reverted the parent patch due to test instability","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"382a7edf4f7b82fef3080da540f23fb7a036e039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"12d6a224_ecae09c5","updated":"2022-03-09 21:45:34.000000000","message":"recheck","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6f6c4f7615f824e9debc8acdd92ab3b4780afa04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3a596511_b695d553","updated":"2022-03-10 08:58:14.000000000","message":"recheck","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"8f9416765d51f6bf75080827e1e00dd133509320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3f05d62c_4fe1bd45","updated":"2022-03-09 19:01:34.000000000","message":"recheck","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fba23c981ea24d06df14d458d9150e1aa41e63bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"386b2bb4_36084e74","updated":"2022-03-09 15:45:05.000000000","message":"thanks sylvain and erlon for following up\nits already on its way but yes im am still ok with this so +2\nbut sylvain fast approval was also correct","commit_id":"947f41e00c1be878a8527bd3690d5d59ab95717b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"393b6061a7b707a047691c2f072d7e26ceab7092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8f865af2_958f5c30","updated":"2022-03-21 13:50:40.000000000","message":"can you update the comment otherwise it looks good\nill use this version to test the sability and upgrade to a +2 once this is updated.","commit_id":"0cfb1ac242a1f1d1cdb8cd738b57541e225e2fa6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"03cade9d6b02c72fe779c85d17c19af5c5252198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dc895341_72af22f5","updated":"2022-03-25 20:46:42.000000000","message":"This looks good and makes sense but could you please fix up the user-facing typos in the release note before I approve it?","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e2322d2896841e668a92f23f278194e6e7596bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4f23c508_9ec54741","updated":"2022-03-21 14:09:15.000000000","message":"got a little distracted \n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 85 tests in 776.6979 sec.\n - Passed: 85\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 393.3824 sec.\n\nso that ran for more then the 10 minutes i planned but it looks like the test is now stable so +2\n\nthis will have to wait till yoga is released to be backported but i think its fine to progress on the master branch in the interim","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a5b4f13347ae31f059be74ad342bd2cabbb5fea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ccd2a23f_4da64e9b","in_reply_to":"dc895341_72af22f5","updated":"2022-03-28 15:51:27.000000000","message":"Ack","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"65796f33a806b50d74a4c7e236970494352f60ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a5984dee_2d5c6923","updated":"2022-03-29 21:31:16.000000000","message":"This change looks good, I have just fixed a typo in the release note and Sean was previously +2 on PS13 and PS14-15 are spelling corrections, so approving.","commit_id":"63ffba7496182f6f6f49a380f3c639fc3ded9772"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"b532d95266c49d859eff86569cd4777551f142a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"574bde66_b47b26ee","updated":"2022-03-30 02:44:23.000000000","message":"vmware-recheck-patch","commit_id":"63ffba7496182f6f6f49a380f3c639fc3ded9772"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7be6a55dc1c93c58ee46d8fc45dec23e0b8a5a90","unresolved":true,"context_lines":[{"line_number":8331,"context_line":"        self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":8332,"context_line":"        # Make sure we set this for _rollback_live_migration()"},{"line_number":8333,"context_line":"        # so it can find it, as expected if it was called later"},{"line_number":8334,"context_line":"        migrate_data.migration \u003d migration"},{"line_number":8335,"context_line":"        self._rollback_live_migration(context, instance, dest,"},{"line_number":8336,"context_line":"                                      migrate_data\u003dmigrate_data,"},{"line_number":8337,"context_line":"                                      source_bdms\u003dsource_bdms,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8677e745_0cc083f4","line":8334,"range":{"start_line":8334,"start_character":8,"end_line":8334,"end_character":42},"updated":"2021-10-26 13:54:39.000000000","message":"we have the migration in the migrate_data object so we might not need to add a pre_live_migration parmater to the rollback function which is one of the things i want to chck however since this is an internal api it might be cleaner to just add the new parmater as you have.\n\nthe other thing i want to check before finsihing a fully review is that self.driver.rollback_live_migration_at_source\ndoes not do anything else we might want to do in the prelive migrate case but i dont think it does so i think this is likely a nice simple fix to this edge case.\n\nyou will need to add unit or fucntional test for this.\nif you have time could you create a functional repoduce patch below this that demonstartes the failure and then in this patch \n\n\nyou may not be able to fully repoduce the\n\"\"\"\nlibvirt.libvirtError: Requested operation is not valid: PCI device 0000:03:04.1 is in use by driver QEMU, domain instance-00000001\"\"\"\n\nexcption wiht our fixtures currently but you should be able to force the failure in pre_live_migrate and  mock _reattach_instance_vifs to raise that libvirt error then assert that its in the logs in a new regression test for this bug.\n\nhttps://github.com/openstack/nova/blob/66574018b517f14dc26e581d0ddaa7788806f83e/nova/virt/libvirt/driver.py#L10105\n\nin this patch which will be the follow up you can then leave the mock of _reattach_instance_vifs in place and assert that the libvirt error is not in the logs since that funcion will not be called with your patch.\n\n\nthat will fully prove taht 1 the bug happens and 2 that your proposed patch adresses it and finaly the regession test will ensure that it will not be reintoduced.","commit_id":"b12d633ca49e44d9f09a4b992b0735e9d7b9c50f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"b5c0de71986d75d3b1b08ece58ead1723ec0c541","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"        self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":8332,"context_line":"        # Make sure we set this for _rollback_live_migration()"},{"line_number":8333,"context_line":"        # so it can find it, as expected if it was called later"},{"line_number":8334,"context_line":"        migrate_data.migration \u003d migration"},{"line_number":8335,"context_line":"        self._rollback_live_migration(context, instance, dest,"},{"line_number":8336,"context_line":"                                      migrate_data\u003dmigrate_data,"},{"line_number":8337,"context_line":"                                      source_bdms\u003dsource_bdms,"}],"source_content_type":"text/x-python","patch_set":2,"id":"05c2acfb_2f13acae","line":8334,"range":{"start_line":8334,"start_character":8,"end_line":8334,"end_character":42},"in_reply_to":"6a2c8d6e_d51391f1","updated":"2022-02-10 17:05:34.000000000","message":"Done","commit_id":"b12d633ca49e44d9f09a4b992b0735e9d7b9c50f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fe5092d49f488db8e6f472f7e7dcb9fd9f89e67c","unresolved":true,"context_lines":[{"line_number":8331,"context_line":"        self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":8332,"context_line":"        # Make sure we set this for _rollback_live_migration()"},{"line_number":8333,"context_line":"        # so it can find it, as expected if it was called later"},{"line_number":8334,"context_line":"        migrate_data.migration \u003d migration"},{"line_number":8335,"context_line":"        self._rollback_live_migration(context, instance, dest,"},{"line_number":8336,"context_line":"                                      migrate_data\u003dmigrate_data,"},{"line_number":8337,"context_line":"                                      source_bdms\u003dsource_bdms,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a2c8d6e_d51391f1","line":8334,"range":{"start_line":8334,"start_character":8,"end_line":8334,"end_character":42},"in_reply_to":"8677e745_0cc083f4","updated":"2022-02-10 14:06:18.000000000","message":"Ack","commit_id":"b12d633ca49e44d9f09a4b992b0735e9d7b9c50f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f9c8c538e7cfa47dee8b8dc5112be992342bfc9","unresolved":true,"context_lines":[{"line_number":9133,"context_line":"        #                  for nova-network)"},{"line_number":9134,"context_line":"        # NOTE(mriedem): This is a no-op for neutron."},{"line_number":9135,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":9136,"context_line":""},{"line_number":9137,"context_line":"        if not pre_live_migration:"},{"line_number":9138,"context_line":"            self.driver.rollback_live_migration_at_source(context, instance,"},{"line_number":9139,"context_line":"                                                          migrate_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"8d69114d_5dd3a4bd","line":9136,"updated":"2021-12-17 12:56:09.000000000","message":"please add a comment here explaing why this is not need for pre_live_migration\n\nyou have explaied it in the commit message but it would be good to also capture it here and refercne the bug.","commit_id":"9275220a9bea93b78a3c291a9479eca5be82bb1c"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fe5092d49f488db8e6f472f7e7dcb9fd9f89e67c","unresolved":false,"context_lines":[{"line_number":9133,"context_line":"        #                  for nova-network)"},{"line_number":9134,"context_line":"        # NOTE(mriedem): This is a no-op for neutron."},{"line_number":9135,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"},{"line_number":9136,"context_line":""},{"line_number":9137,"context_line":"        if not pre_live_migration:"},{"line_number":9138,"context_line":"            self.driver.rollback_live_migration_at_source(context, instance,"},{"line_number":9139,"context_line":"                                                          migrate_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9b8903_7a51f067","line":9136,"in_reply_to":"8d69114d_5dd3a4bd","updated":"2022-02-10 14:06:18.000000000","message":"Done","commit_id":"9275220a9bea93b78a3c291a9479eca5be82bb1c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d5076e903c7df8192d71aaa3724d079e044b382","unresolved":true,"context_lines":[{"line_number":9112,"context_line":"        # NOTE(erlon): We should make sure that rollback_live_migration_at_src"},{"line_number":9113,"context_line":"        # is not called in the pre_live_migration rollback as that will trigger"},{"line_number":9114,"context_line":"        # the src host to re-attach interfaces which were not detached"},{"line_number":9115,"context_line":"        # previously."},{"line_number":9116,"context_line":"        if not pre_live_migration:"},{"line_number":9117,"context_line":"            self.driver.rollback_live_migration_at_source(context, instance,"},{"line_number":9118,"context_line":"                                                          migrate_data)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7ee23b2e_958f80e0","line":9115,"updated":"2022-03-08 14:14:03.000000000","message":"+1","commit_id":"cb410b63b665df53352d07a78851ebca7e1a0d45"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d0e2f4d83bab70cf6d7c33e022a48a581af9b2cd","unresolved":false,"context_lines":[{"line_number":9112,"context_line":"        # NOTE(erlon): We should make sure that rollback_live_migration_at_src"},{"line_number":9113,"context_line":"        # is not called in the pre_live_migration rollback as that will trigger"},{"line_number":9114,"context_line":"        # the src host to re-attach interfaces which were not detached"},{"line_number":9115,"context_line":"        # previously."},{"line_number":9116,"context_line":"        if not pre_live_migration:"},{"line_number":9117,"context_line":"            self.driver.rollback_live_migration_at_source(context, instance,"},{"line_number":9118,"context_line":"                                                          migrate_data)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fd1fd396_e0d3ac4a","line":9115,"in_reply_to":"7ee23b2e_958f80e0","updated":"2022-03-08 15:15:36.000000000","message":"Ack","commit_id":"cb410b63b665df53352d07a78851ebca7e1a0d45"}],"nova/tests/functional/regressions/test_bug_1944619.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dc453de973dad34cf32fdfc74cfb91e4531ff4d9","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        # Live migrate the instance to another host"},{"line_number":79,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027failed\u0027,"},{"line_number":80,"context_line":"                           server_expected_state\u003d\u0027MIGRATING\u0027)"},{"line_number":81,"context_line":"        # FIXME(erlon): In the current behavior,"},{"line_number":82,"context_line":"        # rollback_live_migration_at_source is called if an error happens"},{"line_number":83,"context_line":"        # during the  pre_live_migration phase on the destination and therefore"},{"line_number":84,"context_line":"        # triggers the observed bug. rollback_live_migration_at_source should"}],"source_content_type":"text/x-python","patch_set":9,"id":"774569f6_261d3470","line":81,"updated":"2022-03-09 14:14:42.000000000","message":"nit: you can remove the FIXME comment.","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d97cfc468242b0478a15b15e72e59afaa17adffb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # Live migrate the instance to another host"},{"line_number":79,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027failed\u0027,"},{"line_number":80,"context_line":"                           server_expected_state\u003d\u0027MIGRATING\u0027)"},{"line_number":81,"context_line":"        # FIXME(erlon): In the current behavior,"},{"line_number":82,"context_line":"        # rollback_live_migration_at_source is called if an error happens"},{"line_number":83,"context_line":"        # during the  pre_live_migration phase on the destination and therefore"},{"line_number":84,"context_line":"        # triggers the observed bug. rollback_live_migration_at_source should"}],"source_content_type":"text/x-python","patch_set":9,"id":"50bdaa8d_30622940","line":81,"in_reply_to":"774569f6_261d3470","updated":"2022-03-09 15:34:10.000000000","message":"Done","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"393b6061a7b707a047691c2f072d7e26ceab7092","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                self._live_migrate(self.server,"},{"line_number":73,"context_line":"                                   migration_expected_state\u003d\u0027failed\u0027,"},{"line_number":74,"context_line":"                                   server_expected_state\u003d\u0027MIGRATING\u0027)"},{"line_number":75,"context_line":"        # FIXME(erlon): In the current behavior,"},{"line_number":76,"context_line":"        # rollback_live_migration_at_source is called if an error happens"},{"line_number":77,"context_line":"        # during the  pre_live_migration phase on the destination and therefore"},{"line_number":78,"context_line":"        # triggers the observed bug. rollback_live_migration_at_source should"},{"line_number":79,"context_line":"        # *not* be called for when errors happen during pre_live_migration"},{"line_number":80,"context_line":"        # phase."},{"line_number":81,"context_line":"        mlpr.assert_not_called()"},{"line_number":82,"context_line":"        mlpp.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":12,"id":"f8b59385_03d95ada","line":80,"range":{"start_line":75,"start_character":8,"end_line":80,"end_character":16},"updated":"2022-03-21 13:50:40.000000000","message":"you need to update this now that you have fixed the issue","commit_id":"0cfb1ac242a1f1d1cdb8cd738b57541e225e2fa6"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c4f976d9f472701bbbf38c178a9a9818cb4b1d06","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                self._live_migrate(self.server,"},{"line_number":73,"context_line":"                                   migration_expected_state\u003d\u0027failed\u0027,"},{"line_number":74,"context_line":"                                   server_expected_state\u003d\u0027MIGRATING\u0027)"},{"line_number":75,"context_line":"        # FIXME(erlon): In the current behavior,"},{"line_number":76,"context_line":"        # rollback_live_migration_at_source is called if an error happens"},{"line_number":77,"context_line":"        # during the  pre_live_migration phase on the destination and therefore"},{"line_number":78,"context_line":"        # triggers the observed bug. rollback_live_migration_at_source should"},{"line_number":79,"context_line":"        # *not* be called for when errors happen during pre_live_migration"},{"line_number":80,"context_line":"        # phase."},{"line_number":81,"context_line":"        mlpr.assert_not_called()"},{"line_number":82,"context_line":"        mlpp.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":12,"id":"13b63133_11ef51dd","line":80,"range":{"start_line":75,"start_character":8,"end_line":80,"end_character":16},"in_reply_to":"f8b59385_03d95ada","updated":"2022-03-21 13:54:56.000000000","message":"Done","commit_id":"0cfb1ac242a1f1d1cdb8cd738b57541e225e2fa6"}],"releasenotes/notes/bug-1944619-fix-live-migration-rollback.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7853d45fde57acc5e34dff73d374a6a3b27675b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 1944619`_: The driver.rollback_live_migration_at_source function is"},{"line_number":5,"context_line":"    not called during pre_live_migration rollback anymore, solving this bug,"},{"line_number":6,"context_line":"    that caused failed migrations on SRIOV environments to leave left overs in"},{"line_number":7,"context_line":"    database."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"acbfb1bd_390116c0","line":7,"range":{"start_line":4,"start_character":3,"end_line":7,"end_character":13},"updated":"2022-03-08 15:19:08.000000000","message":"this is ok but a  better release not would have been something like\n\n\"\"\"\nInstances with hardware offloaded ovs ports no longer lose connectivity after a failed live migrations. The driver.rollback_live_migration_at_source function is\nno longer called during  during pre_live_migration rollback which previously\nresulted in connectivly loss following a failed live migraiton. See `Bug 1944619`_\nfor more details.\n\"\"\"\n\nbut what you have will work.\nif you do respin please update this","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d97cfc468242b0478a15b15e72e59afaa17adffb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 1944619`_: The driver.rollback_live_migration_at_source function is"},{"line_number":5,"context_line":"    not called during pre_live_migration rollback anymore, solving this bug,"},{"line_number":6,"context_line":"    that caused failed migrations on SRIOV environments to leave left overs in"},{"line_number":7,"context_line":"    database."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1c0eaef0_aafa28b1","line":7,"range":{"start_line":4,"start_character":3,"end_line":7,"end_character":13},"in_reply_to":"31307c4b_1c6361e1","updated":"2022-03-09 15:34:10.000000000","message":"Done","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d97cfc468242b0478a15b15e72e59afaa17adffb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 1944619`_: The driver.rollback_live_migration_at_source function is"},{"line_number":5,"context_line":"    not called during pre_live_migration rollback anymore, solving this bug,"},{"line_number":6,"context_line":"    that caused failed migrations on SRIOV environments to leave left overs in"},{"line_number":7,"context_line":"    database."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e3f21fc1_47ca431f","line":7,"range":{"start_line":4,"start_character":3,"end_line":7,"end_character":13},"in_reply_to":"31307c4b_1c6361e1","updated":"2022-03-09 15:34:10.000000000","message":"Done","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15da2ffe846810f6f3216e9ac8acc644e73d356d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 1944619`_: The driver.rollback_live_migration_at_source function is"},{"line_number":5,"context_line":"    not called during pre_live_migration rollback anymore, solving this bug,"},{"line_number":6,"context_line":"    that caused failed migrations on SRIOV environments to leave left overs in"},{"line_number":7,"context_line":"    database."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"31307c4b_1c6361e1","line":7,"range":{"start_line":4,"start_character":3,"end_line":7,"end_character":13},"in_reply_to":"acbfb1bd_390116c0","updated":"2022-03-09 14:15:34.000000000","message":"Can you please provide a FUP for this ?","commit_id":"a74d37c3c520726262e77293d74cf2e62be990d8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"03cade9d6b02c72fe779c85d17c19af5c5252198","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer loose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"22011559_379e2f5f","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":63},"updated":"2022-03-25 20:46:42.000000000","message":"lose","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a5b4f13347ae31f059be74ad342bd2cabbb5fea5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer loose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c6c8729b_e3bf63cd","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":63},"in_reply_to":"22011559_379e2f5f","updated":"2022-03-28 15:51:27.000000000","message":"Done","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"03cade9d6b02c72fe779c85d17c19af5c5252198","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer loose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"},{"line_number":8,"context_line":"    migration. See `Bug 1944619`_ for more details."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c06c830f_daad88fe","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":44},"updated":"2022-03-25 20:46:42.000000000","message":"connectivity","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a5b4f13347ae31f059be74ad342bd2cabbb5fea5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer loose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"},{"line_number":8,"context_line":"    migration. See `Bug 1944619`_ for more details."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9716d97c_f2100869","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":44},"in_reply_to":"c06c830f_daad88fe","updated":"2022-03-28 15:51:27.000000000","message":"Done","commit_id":"496ba798df5a4cc3cefdedd9c63de2c065dd06e4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0e8ea3d576202bf2244b382b1a567f6574900bb6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer lose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"},{"line_number":8,"context_line":"    migration. See `Bug 1944619`_ for more details."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"692824b3_773b9227","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":44},"updated":"2022-03-29 21:26:51.000000000","message":"This is still typo\u0027d unfortunately. I will fix it and approve to avoid holding this up longer.","commit_id":"96a325ba5c9f0480e96e694f3d047d74553b5910"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"65796f33a806b50d74a4c7e236970494352f60ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Instances with hardware offloaded ovs ports no longer lose connectivity"},{"line_number":5,"context_line":"    after failed live migrations. The driver.rollback_live_migration_at_source"},{"line_number":6,"context_line":"    function is no longer called during during pre_live_migration rollback"},{"line_number":7,"context_line":"    which previously resulted in connectivly loss following a failed live"},{"line_number":8,"context_line":"    migration. See `Bug 1944619`_ for more details."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1944619: https://bugs.launchpad.net/nova/+bug/1944619"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"94450f80_b9cc4b87","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":44},"in_reply_to":"692824b3_773b9227","updated":"2022-03-29 21:31:16.000000000","message":"Done","commit_id":"96a325ba5c9f0480e96e694f3d047d74553b5910"}]}