)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"24eac316fcea044c0286512a2edb48689e6cdeb1","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb059af9_ee6c129a","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"updated":"2021-10-26 13:22:32.000000000","message":"this call already logs an ERROR if there is a failure. See https://review.opendev.org/c/openstack/nova/+/815498/1/nova/scheduler/client/report.py#692","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a0bb76d0a8464c1696fcd2eec10c9578c28e1fde","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec6a5b2b_fde9634e","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"in_reply_to":"81d678ae_23e12c59","updated":"2021-10-28 13:56:27.000000000","message":"The existing message contains the status_code returned from placement. From the existing logic you see that 409 is translated to ResourceProviderInUse so the existing log has enough information.","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d7bbd41e9b832145371e929adbaab572011c5ae","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcd2b705_a45e181a","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"in_reply_to":"a1a3e90e_c1ca0f5b","updated":"2021-10-28 09:48:51.000000000","message":"Why? The exiting LOG already provides the placement response code as well as the response text at L692:\n\n        msg \u003d (\"[%(placement_req_id)s] Failed to delete resource provider \"\n               \"with UUID %(uuid)s from the placement API. Got \"\n               \"%(status_code)d: %(err_text)s.\")\n        args \u003d {\n            \u0027placement_req_id\u0027: get_placement_request_id(resp),\n            \u0027uuid\u0027: rp_uuid,\n            \u0027status_code\u0027: resp.status_code,\n            \u0027err_text\u0027: resp.text\n        }\n        LOG.error(msg, args)","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"2d7d19c617838c345bc36de9e2b5c6eb2b89fbf4","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1a3e90e_c1ca0f5b","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"in_reply_to":"bb059af9_ee6c129a","updated":"2021-10-27 02:38:28.000000000","message":"but we cannot know why delete provider failed in https://review.opendev.org/plugins/gitiles/openstack/nova/+/refs/heads/master/nova/api/openstack/compute/services.py#324","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"49172bb9f39f68e41f30d553e4fdf26b6b536f09","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"81d678ae_23e12c59","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"in_reply_to":"bcd2b705_a45e181a","updated":"2021-10-28 11:13:35.000000000","message":"this msg cannot distinguish the error is ResourceProviderInUse or ResourceProviderInUse.","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1e6faa5d47c3dcc1f60fcfd014a996f8df7093b5","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"            rp_uuid)"},{"line_number":2286,"context_line":"        for provider_uuid in provider_uuids[::-1]:"},{"line_number":2287,"context_line":"            try:"},{"line_number":2288,"context_line":"                self._delete_provider(provider_uuid,"},{"line_number":2289,"context_line":"                                      global_request_id\u003dcontext.global_id)"},{"line_number":2290,"context_line":"            except (exception.ResourceProviderInUse,"},{"line_number":2291,"context_line":"                    exception.ResourceProviderDeletionFailed) as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"935dae3e_adcbba50","line":2288,"range":{"start_line":2288,"start_character":21,"end_line":2288,"end_character":37},"in_reply_to":"ec6a5b2b_fde9634e","updated":"2021-10-29 08:32:16.000000000","message":"right, seem this is a valid log, abandoned.","commit_id":"336b2b63b2488b95143fcd048b3fd26645ab98ec"}]}