)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"232ab6211ab2c8f4ee90d36ac97d6c4cc2b15a33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44a50419_ae577777","updated":"2021-10-29 07:50:40.000000000","message":"Indeed the synchronized method gained the new `blocking` param [1].\nThese changes looks sensible.\n\n[1] https://opendev.org/openstack/oslo.concurrency/commit/a9ccf0a64deb63e7ea07d232437da797462d8f4b","commit_id":"be9b022bfc2c8b98d751b1f9a68ce55dd6ccf8b6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"111a3991bdc23a79458034ffddb4e565e453bea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"401f6bf0_11bd39fd","updated":"2021-11-02 01:37:19.000000000","message":"LGTM","commit_id":"be9b022bfc2c8b98d751b1f9a68ce55dd6ccf8b6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9d604fa1cde27765a0e6a0abc82aeeedfe989f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c90a1de0_3dfc48d4","updated":"2021-11-02 08:21:19.000000000","message":"LGTM.","commit_id":"be9b022bfc2c8b98d751b1f9a68ce55dd6ccf8b6"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83f63fd838e668b71bf3d83e6934ee335a15b0ae","unresolved":true,"context_lines":[{"line_number":10229,"context_line":"                             supports_attach_interface\u003dTrue),"},{"line_number":10230,"context_line":"            mock.patch("},{"line_number":10231,"context_line":"                \u0027nova.utils.synchronized\u0027,"},{"line_number":10232,"context_line":"                side_effect\u003dlambda lockname: lambda f: f),"},{"line_number":10233,"context_line":"            mock.patch(\"nova.network.neutron.API.create_resource_requests\"),"},{"line_number":10234,"context_line":"            mock.patch.object("},{"line_number":10235,"context_line":"                self.compute,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb3e8e82_d2f080c3","line":10232,"range":{"start_line":10232,"start_character":45,"end_line":10232,"end_character":56},"updated":"2021-10-29 10:14:20.000000000","message":"nit: this probably could have just been pass","commit_id":"be9b022bfc2c8b98d751b1f9a68ce55dd6ccf8b6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eebf0b8808d32e05940354d0e9ccb9f5a04482b5","unresolved":true,"context_lines":[{"line_number":10229,"context_line":"                             supports_attach_interface\u003dTrue),"},{"line_number":10230,"context_line":"            mock.patch("},{"line_number":10231,"context_line":"                \u0027nova.utils.synchronized\u0027,"},{"line_number":10232,"context_line":"                side_effect\u003dlambda lockname: lambda f: f),"},{"line_number":10233,"context_line":"            mock.patch(\"nova.network.neutron.API.create_resource_requests\"),"},{"line_number":10234,"context_line":"            mock.patch.object("},{"line_number":10235,"context_line":"                self.compute,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3373865_80665e5e","line":10232,"range":{"start_line":10232,"start_character":45,"end_line":10232,"end_character":56},"in_reply_to":"bb3e8e82_d2f080c3","updated":"2021-10-29 12:35:21.000000000","message":"actually im not why you need a side_effect at all is there a reason you added one.\n\nim sure this works but i would have expected just \nmock.patch(‘nova.utils.synchronized’) to work too","commit_id":"be9b022bfc2c8b98d751b1f9a68ce55dd6ccf8b6"}]}